From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0076.outbound.protection.outlook.com [104.47.41.76]) by dpdk.org (Postfix) with ESMTP id 4A51F1B3B0; Mon, 1 Oct 2018 17:54:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1RjPDFFqUJXoHPeKcNSFTi6S/NFIOH4N+SqhRxf8I+I=; b=cgGgX64VB0g3bGpCgJta/JvR0iFtnjs1hn9BdFcms1TDyRmtbQ5VJlo8lPOe43U300m1KlR8s+V63T6l1pCzSDFcwxctcohxXW6sybW0e2MjVGAHld6dshUGE2cKt18NHvUF8+MI/8ux6DvJgUOBRw0rHNd0T+a0v3j2jzAbapQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by BYAPR07MB4999.namprd07.prod.outlook.com (2603:10b6:a03:5b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Mon, 1 Oct 2018 15:54:15 +0000 Date: Mon, 1 Oct 2018 21:23:58 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: Olivier Matz , dev@dpdk.org, stable@dpdk.org, jiayu.hu@intel.com Message-ID: <20181001155357.GA1570@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20180913134707.23698-2-jerin.jacob@caviumnetworks.com> <20d2c484-6c86-7c55-4973-d55f1da20a6c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20d2c484-6c86-7c55-4973-d55f1da20a6c@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: PN1PR01CA0101.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::17) To BYAPR07MB4999.namprd07.prod.outlook.com (2603:10b6:a03:5b::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9d2d020-5ee4-4e2c-280d-08d627b6250e X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4999; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 3:cI1IYuqd4GIHC3NHtzSDJx0f2iNS6dssn9Tz8AHau5fjb0zDwubVaJRubbNpoR6GgdteZKPHYbrOwtyg9oKcMSG/d5OAg5zdds9UTPxK6SD3JKKiU4+JXHWd/CtQbGt5aNTmCjhUyaIfLuDkngAlr4zZtMK4+5SVRBdRqhxkyhHYqNrNZCJ9TJfr0KoFai/5dABLe+wtUHYl0Kn6yqpM1axcd3F1sqMMnj92+dFHic/JD5h5+7bjYHIlwIi9f6Ak; 25:JKSuN6g0EKV80XPn4iJd55UhJ2qLiIwcysU9Q7QBZrJrjylbb4nfPdOw++1gHi0B6ZczfV1nMPfECU1iCezH4KCA0DMEBm+zsiiekkH3dDfepEGzojB+iYRdIx/aOgVvBXAF9G4UB+AZqgCZwMCTV8/QUp1IGsjQxYF7votTMNbibQXD23rQUcIUvOWb3t1y7y7jV7bSrLplKGW4YdB54vTgW/klMi+fclokWEpf7jQiqvlAzsxn1i4GCM/53WraGwpthxJP2rpx6iezmn1mHkO3LdyNr68DO168U79hv62hU+gGJYB+HnUHw3J71KcamNLJCLwEiT5yVs3Gsz9BKQ==; 31:DpICoS/1XhmqiSUty+eHSUrdiozwn3YNfvIe80VwFYj1g6ZioJ+e96Tx5K7kBTXO2OuJrKjrUgXzqWMSeRvb0gGxNU16fVx1qds02VzGJa/Jtgd0ZXkqccBm9t6l+inGvCnBIrfhjzbXf0KO/n0KSZH/osr94fe6ECSY/ym1+eysCbDMS3utTlzMQa3Iel7r4rSVpknMd0OEy7bFqHt9EfHfGuN1hnifrktrmxREOPI= X-MS-TrafficTypeDiagnostic: BYAPR07MB4999: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 20:AZx4ZnwTkOs1jOWDZk0idkWwtXmiEsQDGW7EBElZL+IMc1WN6IIdbJypQbgUEOKw5QN1Vj85Bdp28dRmwJcTiZSDtfxdI5Xwe+AcgjeorUIL5IxQ1Ql3Ksy6/tsuWXIZXcDxwunoAKCZ1NhDt8/sOmCB+T+9uxFMrxgC3p0F5aaW8aDAlv63lQA37j2jbfdBfPr2qxm9+9yDO6yhlFs2GIG2MDj4FxHcqf/0GtCZSWrluX9THjy8CmSErWhiwpMfPOPP6h6xK0W8YevScHa09I/RvIIQSwzJvxELeKuDIFa8peYjwC01QE1Q6ViZjSMRdneiYXtyGPUc+sPNhP33t/DXo8Lnsqsu3b3QEkJY4wWSkwbraEBwwSsT0xiUlqHj6GfGGhCAIuUQz6nnwOPb0L+lbSgQG73NnPLBKtWUpch/gYJ0nozh1BTfybKKVxi0USO5HztJQyxoUiBn1VQ39OpELWtZtSTB9sr9NDNDJVYABfh03Nn7Q/UZ4dpnu+rC5ZLU2ZDjtc97/FXPRadBc8VhAzVU9LAmb/K9F6VRiVgu46l37PU5Zu9D2eBYR1OmAWxI6Vy4W3meHKONZKNEJhQX93pn9xyvmscplEnEMWk=; 4:laaPX/IEN4G2Xak8fE8u3q+AsCSZ9y6dPrp5T6ohaAG4wWDHhdTIwJSQBE9NSF77JidAVUm1ZAzBWfr4Mtu10MR+85nmUQqVr7GhnZL2pABBpGTgajt+GU6LR+lG/NQsZ3QAnNT+919gTyFhromy+DJeZE5WhskKGaVLpbqoodw0i9xRoseoaz+cVo4+uLt7Nte2nCjL0ea/MUgbblrJaY9MxIk9YWcM+rg6tqelt8Q4p3aOK+JCPHeGwWnBdea8fOxs7u+ljrVQGla59r0BlD9jsdM5S4zBQK1b/0nSMdhX8PwLk+daQggUH0ASs/yb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(149066)(150057)(6041310)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699051); SRVR:BYAPR07MB4999; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4999; X-Forefront-PRVS: 0812095267 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(136003)(39860400002)(396003)(13464003)(189003)(199004)(6666003)(6246003)(34290500001)(4326008)(16586007)(316002)(1076002)(3846002)(6116002)(23726003)(25786009)(33656002)(68736007)(8936002)(81156014)(8676002)(50466002)(81166006)(47776003)(66066001)(105586002)(106356001)(72206003)(97736004)(478600001)(33716001)(186003)(476003)(16526019)(446003)(956004)(7736002)(11346002)(6496006)(486006)(26005)(58126008)(386003)(5660300001)(53546011)(229853002)(55236004)(14444005)(2906002)(76176011)(52116002)(9686003)(33896004)(55016002)(42882007)(305945005)(44832011)(6916009)(53936002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4999; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4999; 23:giR3OZJ5X7RwxMpFaljHgaNeEzODw5JIe2o7cfQqR?= =?us-ascii?Q?bR1oCp8qElyXMwQPf0gLPVKHaWc5XOhq8l4iW9PseDnGojyy8wUlzqSArs2h?= =?us-ascii?Q?SyTbCLa6zSKoqldtknLSoRQ5ixGpC8Vc1+nww23bhC/wjmZqEdljj0ZuMPMu?= =?us-ascii?Q?O4i07mAX471U5OIHcOhQmL8JebibgqeRmP9w2cTG5O3DJeM/GeYNwqBd3ziP?= =?us-ascii?Q?YNWZmmckWCuc+ugeOeFyFL0htmEvy7eY8kYobFK16MdrRxSJ3edLLaTN4q53?= =?us-ascii?Q?VFheJWQZ15izJxVISDaso4nODgtnXU1uCV+zofoBmWBNu99CQEmhoz4EXCOs?= =?us-ascii?Q?f6Nb+MOUa3tJydc/KAmP02aEioxsi43Iv1N/pj9WT8Zw7bd2u2AupyBtA7Hb?= =?us-ascii?Q?WIEtvNMc6KhboM7SnfMzeqWTNL88St5kSaCyxKAIi/u0vlrZ+S4mQe6AAc70?= =?us-ascii?Q?WqY/oCsfrESAwu54VLXEvcsA2BJEQ+a0VpeW2iwMTFCLJ0XJ2bL9EaWvCx1K?= =?us-ascii?Q?wiohNLP3tYPPf1xXPuwot+TSL+BnDZZ/G9LBCNcJvbOKjTSwNP/0HqNBz6p7?= =?us-ascii?Q?4/l/HxMFeCJkeCR4e3uxCs9ipWoMUdrXN/M4zlyZqF3J0M1yLD3RD/uJ1REL?= =?us-ascii?Q?Yc+TusPKkkZ8YyWMrjrH1MCTecXAvmRM4dx+LuXF8+nCKJXbAx548OOZxvNQ?= =?us-ascii?Q?URgH0T8FlMGmiZ98Gqy9U1yJXzBvcoT899um27T1u+BfSUtJLedf5YVPzmu2?= =?us-ascii?Q?M2D7MLvTyEPbI6by2hxVu9tp8ZR8P5YKwZ10z3MA4tGBIfnDtlSL5GwYvPkH?= =?us-ascii?Q?gcUdSviJ92DRVgImCpP4aWfg0jT/H2z4lQrx3Fbv9hQOBKbQcSq8+fKtgUrZ?= =?us-ascii?Q?MhoNkK900McHZPRnvXYK3YXtMJ027wvG7rhGEAmpIEHsg/sOI1U+Ohe/tlPE?= =?us-ascii?Q?h/8eab8rQXi+aElfmCvwLt583S/RwIqxmo6ceA4tqR4IwGXkmNWdwOW+BhZ+?= =?us-ascii?Q?/IWHruP9HhFQTZqfjxjkwqFl2yL4wB7Sw5xQ1I9DL8VxOvgV8OerYVLlDGNx?= =?us-ascii?Q?v7VTSGKGI9uryc7XUsxQevZQPg27e3qdS+AzgWCVJ5n2Xvz17kN7RSmUlut3?= =?us-ascii?Q?gQLv5PAcWfjU42QREAYWxHAKbQBrULmftJP9TKkI9PF5Tgae3viTRJtFOzyb?= =?us-ascii?Q?cWsu3801rh38T6QzgMGX9BxTktw73c6c+rVvcoj0I7bXVjmAELnFtaxEmOkp?= =?us-ascii?Q?SwYSeCy6yf8/9xv4nRRSTNL3Nu1BgZ3sedBIs0aleGqZBR1HWMZLr4MSXXsf?= =?us-ascii?Q?XitqvmJ7ibvM9XKouCnbBjmBk+I3na6cZYAd48ntP4O9lej67ndBrrDt3VMH?= =?us-ascii?Q?tQUZyp0PUcLaeOY1nrR6ByGhLVR1urFRQ0lfwOGf00p9Rr9?= X-Microsoft-Antispam-Message-Info: driFjNyS48R4rQwMT5K8BbCVA64OD9HFhRMrkcWdMUc1TpilsnuYqBEyMFKWVT3lX+8q4GRqXWDXppXyd8rvtZkrgdDJeADaIJqAiJtmQyHs/s8auHH3pCxIyq3AZZzYPGX8S2BrPnbx25yuv2rdm37Yc1wMK8X3jsKwxH719cOmRZLKtCnomPVLG0K8eLb+Uel9zg54L7Z0x4cwEpxlQj/N9iBsW2py5KCn6z7Q2cBKi7jkOXxWaAKsX359BNvXeHMyJ9atKv043ZzVIaUtqElhtuQ0Z8lq2iF3gxZrjtJsIk8b5/DogNhuDHNu8vT4nmAvqvf1IQm5rm0+9tGK3mV4iB8qsCCEfuO/ee8C0NU= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 6:hVjoezLMWnVFJFbrVYsG3sbyNzNjAjwI7bx8FIJrHgHmDPG0Onjj7Jq3tTIDEIRsTa1obFUYMeC4wIYEncObPyUyxYQRTt5Boy1B+KC0X43DzjcooLZYXxr1rspJFOJtlkQoXFQbmTTBk1TE2xvdSNpbKcAIvFpjiPJiH07N2xq+2AX+qk76cGeE8lmq8NyfLdSON+AyGd+ARR9qo2ei/0Otx3m0lqtCtXZJD6gbMGpsicdLm7yPJgeseBa81NFCcBU+gaSHZ+57SRJtjSDgzNbqosotfwRBaDTJgQLFwIPU93fFu31jdh+dA0DMM+KEH9l1bCi309UY7t7abrC2La5hmn4aYcO5DRmicuoE77yZt0dNYSdvlK4cDfpniXso+v/mXVW78ZeNCrSFpAtuPjEDrZpUYMi+KCsxwD4SjotZkYHvOZP4iznHg9MbiinSGDKZF1Ioo+8dijaxoJahUQ==; 5:ypgTCr308N57hqGMYnUgWwViCFyWXbTjY3ha3W1xwgpqxQNpu9LDU7EoUS9Ec6zU9FoMWsF7+5Kven1LV1Vl7SypKD+Oto/zwWL5u2/ovRTjC/AwK5jSOA+Pp1WuTPw8PlQF0Im4t2vo/o4FKX92YLKSNyJds6wtZyv66It4M+s=; 7:AOMYKem/ZdctG6xkdXpp2JvqyPIyMkoW9vzY9KMAkjAgq3p/ttqU5pna8XFsSiszGVr3zMWK/yzYVn1fQt8VRe3353796R3AVSV85ff8pUmtuOkC4uYUMN5TtHpPc3NBNHmWBuvd3IdSCXaZH+e22oqR971EPreJ7nfl4sV4Y0+9Vs3XWEl5vRRelNnsQ+a1HgeMMfMrpymTYWF8H10B3cqXIWUEqGKwYj4xee0ki7RzR6Fm+HkpIZ4aUsWgX/pn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2018 15:54:15.0281 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9d2d020-5ee4-4e2c-280d-08d627b6250e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4999 Subject: Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 15:54:20 -0000 -----Original Message----- > Date: Mon, 1 Oct 2018 14:45:02 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Olivier Matz > > CC: dev@dpdk.org, stable@dpdk.org, jiayu.hu@intel.com > Subject: Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > > On 9/13/2018 2:47 PM, Jerin Jacob wrote: > > Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. > > > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > > Cc: stable@dpdk.org > > Cc: jiayu.hu@intel.com > > > > Signed-off-by: Jerin Jacob > > --- > > lib/librte_mbuf/rte_mbuf.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index 9ce5d76d7..6a5dbbc8f 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -343,7 +343,8 @@ extern "C" { > > PKT_TX_VLAN_PKT | \ > > PKT_TX_TUNNEL_MASK | \ > > PKT_TX_MACSEC | \ > > - PKT_TX_SEC_OFFLOAD) > > + PKT_TX_SEC_OFFLOAD | \ > > + PKT_TX_UDP_SEG) > > Also can you sort the list, it seem there was an intention to sort from high > bits to low, but broken, it makes easy to recognize missing items later. I think, sorting from high bits to low bits makes it easy to recognize. If it broken, How about fixing that(order based on bits) while rebasing to top of tree? I don't have strong opinion or sorting based on bit order vs name. Just shared my thought. Let me know your opinion, I will update it accordingly.