From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730045.outbound.protection.outlook.com [40.107.73.45]) by dpdk.org (Postfix) with ESMTP id B16112952 for ; Tue, 2 Oct 2018 10:53:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hQz70pBLMwt8MTZL605ZTWKjUcRsrfCpSquIhznRnbY=; b=JJeaM00F2pQCWCifMFMQEXIKA8+p9fOi5uneLn3Z8Z7SVIgoRCQwjPRI8T0peM3nPVj+XYnTeOBUdLeNHWs79kJWNw5mPb+rvruTfrPKQHAPjFgCQjHHsuzwRxu43xdF/OkWrHv/AF+A2SiAuXIlSRs9KDu1QfKsFF3AObRP9x8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by SN6PR07MB5007.namprd07.prod.outlook.com (2603:10b6:805:ac::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.23; Tue, 2 Oct 2018 08:53:19 +0000 Date: Tue, 2 Oct 2018 14:23:03 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Andrew Rybchenko , dev@dpdk.org Message-ID: <20181002085301.GA22870@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181001155945.GB1570@jerin> <7483435a-0c8e-47d6-0e4f-8fdc3741b2a7@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7483435a-0c8e-47d6-0e4f-8fdc3741b2a7@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR01CA0079.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::19) To SN6PR07MB5007.namprd07.prod.outlook.com (2603:10b6:805:ac::33) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 77816d7f-0695-457d-39bb-08d628448249 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5007; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5007; 3:+8ypkGoHlNxPzuic4OD4IV90YNBF9GQEg4NH6tesr3XPluTbzMDEDF7a54AgIKwtphNgfU/ixPpa1LhxAneV7UFwMEUpQ9u4ZR4vuY9JCvyzBqRGeV6YzTx9QbSBaFPL7KZnGKUJ73zfiTdQteOQlUFIGRN88mXiKOfoAl9ortw8ukIhrwv2idFqB4KZcbKhA9/S1OKZF1gKT+SQ/9Q+KHgwv3rr+JIgb/mkjMSKCUVll6fsPReqyDvZaKtWubEk; 25:1Yddo1aFiBstQNeoNv1LvmMGc5htlSBUSi9FD5ZUdLfBeEjeGFg+nTV+ROAbO3r7D5WQQupTI/b6grUlxuIWZpYRRbEWQaoDDVLlVAJUviT0IzQ/TuTOYCUQRfFLCnmo3zhmxxhc9tW2E7KyIZkIKz3EIt36pZx/No8mOt0ybfC7Zkv2J76DQ9qTa6770bSmAXfldrN3W1aZWlG4fmtAQiN2MLXf9n27o7oTK3ugspq/AcxyWo3nXf9pF7ClyJ9tBZjEg+rOM0xxp0yFAOsmJD9rxFF92briBAteIUvEZw/wngVsCZYROiAS/SO+avpOwVWzBCfH1DA6pw7JDH24ww==; 31:qZx9wXR2IbH3IBA2agnTUXpSDpqayzJrl1bp29cd8hJU0RWyNPz+QlvT/lOwfYP0knDtji2evfcH7vpXprmMJyX6pWs7tAeYXoH6uhYRtppcC/tqpcmqREg+gWdHQgJ9HZ/SDrwKJbXQP8NFxoPgEwXsOZJa+davUfNWUO2fuj046pfZl7nuzicYyomv5qvEy96Bjr8M8MhYV5/ANDMPiaham3uFJSVoivz282y9nYM= X-MS-TrafficTypeDiagnostic: SN6PR07MB5007: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5007; 20:Th1KFDvWBgBUwBDyXbXXlic7N/XfM7OxivdlOtsu1Ru2CBRnrT+d+Di72rMf3PIWvoJ2fZvB80I+yEVyvFgDJ3IwJix3hfSxuVyI/W66R9ZhEOLYw8eansvCTdCAaGzW6Cm561X1ZBFsR+sh/umC3FRqMFK4jWeoT2TMf1D4pA14UqWaZJaE7NFnIJ1e0nAW6AVpZE6yMoTlkAfkNrOXQut0uGEd2F2pGVGPg024MWWQD8AVWBV56+2ReDWM+jItey30Rqth17bMWQTTlsrItBGCx+hS2Kfti7w1bdrJ7S27RWsNifThDG5KojL1qGAyAN4/nGdbQ+B1S/+NE/FJpgnnC0zVWcNRlOqh1+PHCUnjYE4rm1L0x+pbwX+eQKyPJACaFsvmuqpAmt3DpAaAPl/fAU0YoO6aHlxdb9/PlKrpdR9Xz3SyEdCvDHNS9kQFHigP5Ec+eysh7Yhmzc48/4tNSwzF41wA/KDND2/3Li5kvww39LYlRu5jliX+JzgbLSKJLlsbfEprqJ2xnVgctCAcsHKsXfy9nPJIhiMmxtHhgwA2/coQLUfVoVMcoEJAxqSafcqFCXbXKa6ITcPtdeIxIedz1ESEzz5JKnDZ6/s=; 4:n65l5HYslrYc4qIEYPIi5UofD7FY+6lHFiQJo4mrxTPnok1fXYm1dDv645X8h3SOMCCEadpuB979I/GWMzob9cFhcOcDYbKK20Tx7D8dK42F21S+2xXL5tuTWvJJ/H2xetT/NnsM1mjrL1JJ7mKByaVFwuQY1gdvI/55kTMka8Da0OR1S6ew8BdFRO+XO+jmpEysI7lrLj8YN07ywfO1cEbLHgyF86WFajGanGB5r0PIUQZXpEdIoLmBhiP6BkzigcEVw8wXzVy7/x6WTSYa7GFTOfYpKUZndkCBmUWJzYkC3urukthY/4BgyXq3/8E4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(3231355)(944501410)(4982022)(52105095)(149066)(150057)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(201708071742011)(7699051); SRVR:SN6PR07MB5007; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5007; X-Forefront-PRVS: 0813C68E65 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(366004)(346002)(376002)(13464003)(199004)(189003)(16526019)(52116002)(42882007)(956004)(93886005)(6496006)(186003)(6666003)(6916009)(6306002)(55016002)(9686003)(316002)(33896004)(76176011)(486006)(26005)(14444005)(97736004)(53546011)(386003)(55236004)(476003)(11346002)(44832011)(53936002)(446003)(229853002)(50466002)(105586002)(25786009)(2906002)(16586007)(106356001)(23726003)(4326008)(47776003)(6246003)(6116002)(66066001)(54906003)(68736007)(7736002)(5660300001)(305945005)(81166006)(33656002)(8676002)(33716001)(8936002)(966005)(81156014)(72206003)(1076002)(3846002)(58126008)(478600001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5007; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5007; 23:URTjLK4kuZDYJqzFrIbMRu4O/l/LeptqKLQAqHE5b?= =?us-ascii?Q?wnHDIiEOmSOGsL8zUQrOB2QDs1n1b6rxwJ6qzDwLzBIK6tRy/aG0wv0TEs34?= =?us-ascii?Q?tF55/P/vDvs6pIrdSnDnJfVH83ww/MJ8NGfu4ohhbFqWE8cyvbvW+yc8egFJ?= =?us-ascii?Q?OP0tYbCqxLKf5l8Y9vgt+fWZkN90c93faVZyWwZ09C4dQhR4zEXWsWe/n5LL?= =?us-ascii?Q?6JePe6m8zFITjL1g/tBy+YZjIPPKP5B4ySVSFX/VbSUbeNJPVyRtjD1aSmQg?= =?us-ascii?Q?AhTDXCsEdyZQiYlEh+XXTVfAB4IJgFIwTOASG89WsLdWffEhujBuKVnRBab8?= =?us-ascii?Q?nj+vcmumzalNbjqvsDfBNAI0EV9T3e4IfbFVsQY2ZatlStWYf5zanJEIl3Py?= =?us-ascii?Q?8vVIEt+Kt3TQHMzGUQIYQfYgTKVKdCJ2HsHUlda7gkruNeeuHRoo+ZeBtxA5?= =?us-ascii?Q?5N7kRUu48Nv/qpz/K555lvOweFPG7N03MUNTPbJi7wf+pvPXEJBwUSWZUbtU?= =?us-ascii?Q?/RoQ7/AeIbQ0IfBMSj/+mymKebjHm3jBtp/iOdiL4rMrLboe2ktTmTzaIWTH?= =?us-ascii?Q?gxEubNaSVp37MNTrR7Ni8xEoS9G9IlPgXnfgnYjfSx6S/a5epXfEhnv3IT+T?= =?us-ascii?Q?I0fn/4S/cunO1a10d2tGwAucFC/9Y6sfYj7sQxE1B0eXZdajPe2tx1jGx2XQ?= =?us-ascii?Q?FSr2ue6DhTx0/VKyLOipct669wSv31PMXEkP3k1IDdv01FV25wCVIsgn7Xal?= =?us-ascii?Q?A9wnPf10xIdAmV9TcVB6mpNAMcI4+Uwat74e+vHyE/UZ1/ovyeY3aWhNv//d?= =?us-ascii?Q?G6aMgX5yuSvmF/XvAOBOefc1tHReh+ADb6IplxY3HdHnUgvIUegJmGaAAifA?= =?us-ascii?Q?6F5ndUzZKTdGvgVLa0LluZgxXnJ/LHVLusPiakTKbrwtWSLKoT/PDKPLU0iv?= =?us-ascii?Q?7gryYWeu5QpZuLrQPePj7FbeCCwZ1LbKa4EFJpxKalzOOpxj/MqTK6WbR4nc?= =?us-ascii?Q?L2ETOcL/3OeFaPj9ZlKXw5Eu2Rv2Sk/UH0OeJWn7eS6tlubW/VCLo3CkNV+E?= =?us-ascii?Q?DGHmxWZOqtN1ktf2lKhIJNWsR+O+HT+bXZy92ykxw46a78724+tj1A2kyRtb?= =?us-ascii?Q?PRuoMC1vBDFlvjCuSumaflfJLD0BFnXOyK8afFd+J0xJwhp7ytvgkUs+JR7i?= =?us-ascii?Q?eUnLDuFf+1JlGUE4vHDyLZbZtH8RmGoZnOJhdqUVvXz/5e8iAkPMbV1t5a6v?= =?us-ascii?Q?LIJK/J2UZrZr9ZqRn04N65i27wb2yf/81NdtiIWHcoy+/ZUGtiq6puoKlTml?= =?us-ascii?Q?vmo78rgQsYlAP5W0Xf5gCnwefuI+np34X5XozYShUEhk/lQJ5ZN83EJ8fUCz?= =?us-ascii?Q?MZT1AsfWo2Qi3bHZGH+R0UAwwxMYv6K1PJETE2o5JCe6lorB4+L99et2YhKt?= =?us-ascii?Q?i1IcH2foGpeO+o4mCLJGvG7Dy2oCRuFgPdkDjzsNQMwzZbQ9nF5?= X-Microsoft-Antispam-Message-Info: vaD4HpWvUYVoVPsNg8y91xCHXVuiM4EivKJ4uuAnKTyGfU9yfkgNkJBV7ARIz+2nTjfQdKdT6YRvRpLrtf1Tw6Quj+l4mU60IpgHldWJbjXMh3/8pa3wGT/eGCqTc2BWqQaTBRHLSjzfC8JWbMMciN/hJv4TMVsBvvg16mP+UjRiTFVREU22aakc8GMUenZRtyv1zpbbnOJdayoQ8vsekPwULdTCjJp4NTACOz7wGeMA4Ju/IiwqO1W0s1e8wjRhwkmjSG3QQGr9yL91EBdx36GmMzX9Cw/q0FfksmQpdCwlSIcmkYwng5iQ4yHd8qCNqL2LsiUc0D4os1NVnLXF7dcdZfUgmqmbRESHxGXUHFU= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5007; 6:/iIdVvrFLfO/kv1Xps0whwg9K9n8YDek3ukDLA+UMXHOMRmH8ivHG2R5d/6GBERpwPp6AiaLvZtSpZ57XxbGD6YTOk8rVopfCrNfO6ElsjOOL7YuMWcfKsA4NC3LX+ts5lRcPbkEVXzjqxfOVFTHm9K9ib8My5A7CZ5IMt6Lo4m+WIGVtoOI7nJFbuUSoL5xcV5gT5uvcSM4vFvumbYf1uOCgBKJu5EqOQN//Ey0aZjMiMrqPAtS3UpswcY0S1gAbAi3iOttPorAd+rmXiYNtOjucqIW8pfWub3Rh0w3foE2Tuac8C/T2xTQPASH8sTKih7saYg3vc3uV6JhlBYCUzZJ6Ay13436c0OJ0xFKYCwD5YbMNSL2cdF5OYjc9Rp/7hr5OAHI2sRdrYWcucOiDa+Kh2YpGkKHOExI3XOj7J2zw/Rlgui4Ism//f1c9laR5y1QXmKa67sFiSKF0aOmBg==; 5:XdhCvExDjAjr954lsA1+vM7M01iW4F+jfJZz41+JZXxI+Rx7UWXQ/ILH6lVvYFQj2lWHrh3SvvAhzBh9Z5/aXarn2wGR3FzLrH6h17mMS64h7f5HCdu+77SnJkWwdWnQXePh/VhfzWTWhHElHdc2zujCB08+7LuPh5BMMfT2qa8=; 7:L1GeiEb2F23sJEjPYqtYioUwNWeUmPxY+43iLQviOp+o1FFG8UWMRTFaVNP0TIc++NsThvLPxwdUJoKyHBhI8GSbQCfulQJd7k5/jWlJQoRTLt33ZZCeYwSSdJE6yRSKLZc8upmoOvG9Ee4egnlw8bZuOTJLQJIAck3v4UlX+DXM/uSna3gpM7vxryq49UgQBF/yaejphK4hcu7IbINJyPtaGzCI1PlqCoCOS9VPrfVzultdboPGPH4O0JYITAr6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2018 08:53:19.2290 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77816d7f-0695-457d-39bb-08d628448249 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5007 Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 08:53:25 -0000 -----Original Message----- > Date: Mon, 1 Oct 2018 17:11:50 +0100 > From: Ferruh Yigit > To: Jerin Jacob > CC: Wenzhuo Lu , Jingjing Wu , > Bernard Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Andrew Rybchenko > , dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload > support > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > On 10/1/2018 4:59 PM, Jerin Jacob wrote: > > -----Original Message----- > >> Date: Mon, 1 Oct 2018 14:46:39 +0100 > >> From: Ferruh Yigit > >> To: Jerin Jacob , Wenzhuo Lu > >> , Jingjing Wu , Bernard > >> Iremonger , John McNamara > >> , Marko Kovacevic , > >> Thomas Monjalon , Andrew Rybchenko > >> > >> CC: dev@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload > >> support > >> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > >> Thunderbird/52.9.1 > >> > >> > >> On 9/13/2018 2:47 PM, Jerin Jacob wrote: > >>> Signed-off-by: Jerin Jacob > >> > >> Overall set looks good to me, I put some comments on individual patches. > >> > >> And can you please rebase on top of latest head? > > > > Sure. > > > > Regarding space issue mentioned in other email in this thread. > > It looks like similar space added in other offloads. > > example: http://git.dpdk.org/dpdk/tree/app/test-pmd/config.c#n571 > > Hi Jerin, > > This is just detail, the alignment is broken in the output of the log, for > others on/off start from column 56, for this one it is 57, just delete a space > from printf please. Sure Ferruh. Will add it in v2 > > > > > So, I expect no change in this patch other than rebase to latest head. > > If not, let me know. > > > >> > >> Thanks, > >> ferruh > >> >