DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, tredaelli@redhat.com,
	christian.ehrhardt@canonical.com, mvarlese@suse.de,
	Luca Boccassi <bluca@debian.org>
Subject: [dpdk-dev] [PATCH v4 2/2] build: add drivers_install_subdir meson option
Date: Tue,  2 Oct 2018 17:20:46 +0100	[thread overview]
Message-ID: <20181002162046.13668-2-bluca@debian.org> (raw)
In-Reply-To: <20181002162046.13668-1-bluca@debian.org>

Allow users and packagers to override the default dpdk/drivers
subdirectory where the PMDs get installed under $lib.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
v3: changed default value to <VERSION> and use string.contains rather
    than exact equivalence
v4: further optimisations suggested by review

 meson.build       | 7 +++++--
 meson_options.txt | 2 ++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/meson.build b/meson.build
index 4bd04b9de3..11697861c4 100644
--- a/meson.build
+++ b/meson.build
@@ -20,8 +20,11 @@ dpdk_extra_ldflags = []
 pver = meson.project_version().split('.')
 major_version = '@0@.@1@'.format(pver.get(0), pver.get(1))
 
-driver_install_path = join_paths(get_option('libdir'), 'dpdk',
-	'pmds-' + major_version)
+pmd_subdir_opt = get_option('drivers_install_subdir')
+if pmd_subdir_opt.contains('<VERSION>')
+	pmd_subdir_opt = major_version.join(pmd_subdir_opt.split('<VERSION>'))
+endif
+driver_install_path = join_paths(get_option('libdir'), pmd_subdir_opt)
 eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
 
 # configure the build, and make sure configs here and in config folder are
diff --git a/meson_options.txt b/meson_options.txt
index d14bde892d..10b5416151 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,5 +1,7 @@
 option('allow_invalid_socket_id', type: 'boolean', value: false,
 	description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly')
+option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
+	description: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')
 option('enable_driver_mlx_glue', type: 'boolean', value: false,
 	description: 'Enable glue library for Mellanox PMDs')
 option('enable_kmods', type: 'boolean', value: true,
-- 
2.19.0

  reply	other threads:[~2018-10-02 16:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 17:58 [dpdk-dev] [PATCH] " Luca Boccassi
2018-10-01  9:17 ` Bruce Richardson
2018-10-01  9:25   ` Bruce Richardson
2018-10-01  9:46     ` Luca Boccassi
2018-10-01 10:01       ` Bruce Richardson
2018-10-01 10:42       ` Timothy Redaelli
2018-10-01 11:06         ` Bruce Richardson
2018-10-01 11:24           ` Luca Boccassi
2018-10-02 11:02             ` Marco Varlese
2018-10-02 12:23               ` Bruce Richardson
2018-10-02 13:07                 ` Luca Boccassi
2018-10-02 13:06 ` [dpdk-dev] [PATCH v2 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY Luca Boccassi
2018-10-02 13:06   ` [dpdk-dev] [PATCH v2 2/2] build: add drivers_install_subdir meson option Luca Boccassi
2018-10-02 14:28     ` Bruce Richardson
2018-10-02 14:59       ` Luca Boccassi
2018-10-02 15:19         ` Bruce Richardson
2018-10-02 15:26           ` Luca Boccassi
2018-10-02 15:25 ` [dpdk-dev] [PATCH v3 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY Luca Boccassi
2018-10-02 15:25   ` [dpdk-dev] [PATCH v3 2/2] build: add drivers_install_subdir meson option Luca Boccassi
2018-10-02 15:58     ` Bruce Richardson
2018-10-02 16:21       ` Luca Boccassi
2018-10-02 16:20 ` [dpdk-dev] [PATCH v4 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY Luca Boccassi
2018-10-02 16:20   ` Luca Boccassi [this message]
2018-10-02 16:30     ` [dpdk-dev] [PATCH v4 2/2] build: add drivers_install_subdir meson option Bruce Richardson
2018-10-05 16:00     ` Timothy Redaelli
2018-10-02 16:28   ` [dpdk-dev] [PATCH v4 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY Bruce Richardson
2018-10-05 16:00   ` Timothy Redaelli
2018-10-27 21:19   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002162046.13668-2-bluca@debian.org \
    --to=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=mvarlese@suse.de \
    --cc=tredaelli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).