From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1561F201 for ; Wed, 3 Oct 2018 01:06:13 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 16:06:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,333,1534834800"; d="scan'208";a="96890706" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207]) by orsmga002.jf.intel.com with ESMTP; 02 Oct 2018 16:05:39 -0700 Date: Wed, 3 Oct 2018 13:53:19 +0800 From: Ye Xiaolong To: Ferruh Yigit Cc: dev@dpdk.org, Maxime Coquelin , Tiwei Bie , Zhihong Wang , xiao.w.wang@intel.com, Rami Rosen , Wang Haiyue Message-ID: <20181003055319.GA78385@intel.com> References: <20180928112344.42791-1-xiaolong.ye@intel.com> <20180928214747.48938-1-xiaolong.ye@intel.com> <20180928214747.48938-2-xiaolong.ye@intel.com> <07075871-63c3-7773-ba89-00155cc7cba7@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07075871-63c3-7773-ba89-00155cc7cba7@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v8 1/2] vhost: introduce API to get vDPA device number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 23:06:14 -0000 Hi, Ferruh, On 10/02, Ferruh Yigit wrote: >On 9/28/2018 10:47 PM, Xiaolong Ye wrote: >> It's used to get number of available registered vDPA devices. >> >> Signed-off-by: Xiaolong Ye >> Acked-by: Xiao Wang >> Reviewed-by: Maxime Coquelin >> --- >> lib/librte_vhost/rte_vdpa.h | 3 +++ >> lib/librte_vhost/rte_vhost_version.map | 1 + >> lib/librte_vhost/vdpa.c | 6 ++++++ >> 3 files changed, 10 insertions(+) >> >> diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h >> index 90465ca26..b8223e337 100644 >> --- a/lib/librte_vhost/rte_vdpa.h >> +++ b/lib/librte_vhost/rte_vdpa.h >> @@ -84,4 +84,7 @@ rte_vdpa_find_device_id(struct rte_vdpa_dev_addr *addr); >> struct rte_vdpa_device * __rte_experimental >> rte_vdpa_get_device(int did); >> >> +/* Get current available vdpa device number */ >> +int __rte_experimental >> +rte_vdpa_get_device_num(void); > >Hi Xiaolong, > >Is rte_vdpa_get_device_num() an public API? (It should be since it will be used >in an application in next patch.) > >If so, header needs to be part of API documentation: >1- Update doc/api/doxy-api-index.md to include this header. >2- Update all APIs comments to be an doxygen comment. >3- Add doxygen comment to all data structures. > >I can see rte_vdpa.h not documented at all, it is not just this API, so it can >be better to send a new patch to address above items. Thanks for the reminder, I'll send a new patch for it. Thanks, Xiaolong > >Thanks, >ferruh