From: Bruce Richardson <bruce.richardson@intel.com>
To: "agalyax.babu.radhakrishnan" <agalyabx@ecsmtp.ir.intel.com>
Cc: dev@dpdk.org, alejandro.lucero@netronome.com,
allain.legacy@windriver.com, jasvinder.singh@intel.com,
keith.wiles@intel.com, matan@mellanox.com,
reshma.pattan@intel.com,
Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/6] build: fix for FREEBSD build via meson
Date: Wed, 3 Oct 2018 16:33:39 +0100 [thread overview]
Message-ID: <20181003153338.GA4596@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1538574386-21771-2-git-send-email-agalyabx@wgcvswdev001.ir.intel.com>
On Wed, Oct 03, 2018 at 02:46:21PM +0100, agalyax.babu.radhakrishnan wrote:
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
>
> FreeBSD compilation was failing through meson build.
> RTE_EAL_VFIO is not supported in FreeBSD.
> But RTE_EAL_VFIO was enabled for both linux and freebsd.
> So RTE_EAL_VFIO is removed from config/rte_config.h and
> based on the platform RTE_EAL_VFIO flag is enabled/disabled appropriately.
>
> Fixes: 6e8a721044 ("vfio: export functions even when disabled")
>
The actual commit that introduced the offending line i.e. the RTE_EAL_VFIO
one in rte_config.h was 844514c735, eal: build with meson.
With correct fixline:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
prev parent reply other threads:[~2018-10-03 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1538054652-20820-1>
2018-10-03 14:00 ` [dpdk-dev] [PATCH v2 0/6] fix for meson builds in freebsd Agalya Babu RadhaKrishnan
2018-10-03 14:00 ` [dpdk-dev] [PATCH v2 1/6] build: fix for FREEBSD build via meson Agalya Babu RadhaKrishnan
2018-10-03 15:42 ` Bruce Richardson
2018-10-03 14:00 ` [dpdk-dev] [PATCH v2 2/6] net/nfp: disable nfp build in FREEBSD Agalya Babu RadhaKrishnan
2018-10-03 14:00 ` [dpdk-dev] [PATCH v2 3/6] net/avp: disable avp " Agalya Babu RadhaKrishnan
2018-10-03 15:12 ` Legacy, Allain
2018-10-03 14:00 ` [dpdk-dev] [PATCH v2 4/6] net/softnic: disable softnic " Agalya Babu RadhaKrishnan
2018-10-03 15:36 ` Singh, Jasvinder
2018-10-03 14:00 ` [dpdk-dev] [PATCH v2 5/6] net/tap: disable tap " Agalya Babu RadhaKrishnan
2018-10-03 14:24 ` Wiles, Keith
2018-10-03 14:00 ` [dpdk-dev] [PATCH v2 6/6] net/vdev_netvsc: disable vdev netvsc " Agalya Babu RadhaKrishnan
2018-10-03 15:10 ` Stephen Hemminger
[not found] ` <1538574386-21771-2-git-send-email-agalyabx@wgcvswdev001.ir.intel.com>
2018-10-03 15:33 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003153338.GA4596@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=agalyabx@ecsmtp.ir.intel.com \
--cc=agalyax.babu.radhakrishnan@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=keith.wiles@intel.com \
--cc=matan@mellanox.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).