From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CD6161B443 for ; Wed, 3 Oct 2018 17:33:52 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 08:33:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,336,1534834800"; d="scan'208";a="95744496" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga001.fm.intel.com with SMTP; 03 Oct 2018 08:33:42 -0700 Received: by (sSMTP sendmail emulation); Wed, 03 Oct 2018 16:33:39 +0100 Date: Wed, 3 Oct 2018 16:33:39 +0100 From: Bruce Richardson To: "agalyax.babu.radhakrishnan" Cc: dev@dpdk.org, alejandro.lucero@netronome.com, allain.legacy@windriver.com, jasvinder.singh@intel.com, keith.wiles@intel.com, matan@mellanox.com, reshma.pattan@intel.com, Agalya Babu RadhaKrishnan Message-ID: <20181003153338.GA4596@bricha3-MOBL.ger.corp.intel.com> References: <1538054652-20820-1> <1538574386-21771-2-git-send-email-agalyabx@wgcvswdev001.ir.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1538574386-21771-2-git-send-email-agalyabx@wgcvswdev001.ir.intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 1/6] build: fix for FREEBSD build via meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 15:33:53 -0000 On Wed, Oct 03, 2018 at 02:46:21PM +0100, agalyax.babu.radhakrishnan wrote: > From: Agalya Babu RadhaKrishnan > > FreeBSD compilation was failing through meson build. > RTE_EAL_VFIO is not supported in FreeBSD. > But RTE_EAL_VFIO was enabled for both linux and freebsd. > So RTE_EAL_VFIO is removed from config/rte_config.h and > based on the platform RTE_EAL_VFIO flag is enabled/disabled appropriately. > > Fixes: 6e8a721044 ("vfio: export functions even when disabled") > The actual commit that introduced the offending line i.e. the RTE_EAL_VFIO one in rte_config.h was 844514c735, eal: build with meson. With correct fixline: Acked-by: Bruce Richardson