From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680050.outbound.protection.outlook.com [40.107.68.50]) by dpdk.org (Postfix) with ESMTP id 2F8244F9B for ; Wed, 3 Oct 2018 20:14:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4MboJNQhcQ3HOERvvH6PZ0k9lRCwODin29kNiooLRkI=; b=NJgxpKL+PmKDWoAdkt7OXFWbHKEBlvgIuwPyOpK1QYaOPMGBnZtx42D8cEsUNOroMKsiGjQbbodfLEX8IcSLN93CZ4V4FZWifG2y9DpkUNP933YnhXMxbrkahKUEnXZiF/i0pDSYLZB1I8OIYK8fUQjn3g1CA9M9UqVsRZFzRfs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.201.57.251) by BL0PR07MB4994.namprd07.prod.outlook.com (2603:10b6:208:49::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.18; Wed, 3 Oct 2018 18:14:30 +0000 Date: Wed, 3 Oct 2018 23:44:13 +0530 From: Jerin Jacob To: Andrew Rybchenko Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Olivier Matz , dev@dpdk.org, shahafs@mellanox.com, "Ananyev, Konstantin" Message-ID: <20181003181412.GA8662@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <20181003075712.GA2003@jerin> <20181003171252.GA3193@jerin> <209397d1-f1ee-befb-1593-5adb58045bc5@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <209397d1-f1ee-befb-1593-5adb58045bc5@solarflare.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [106.201.57.251] X-ClientProxiedBy: SG2PR06CA0228.apcprd06.prod.outlook.com (2603:1096:4:68::36) To BL0PR07MB4994.namprd07.prod.outlook.com (2603:10b6:208:49::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 380d9b5b-7cf6-4194-5f6f-08d6295c12c3 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4994; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4994; 3:UOzAbozf84N/oaTVe6wOetbzPAseqd9G+tqM10+AQBUP9YdO6ogTPJzbEm8B2vKG6VdaTrS7ie6TQpgjusbt/3ocO/JQ1jnLjNWBHulC6KZcppB/9lZ/UPD2K3G+sZQjkxw0s8EMKTXegnhG596tVIdyIuIfepO12SMe0wfN9x178oV+ICbQIfjwIxTUn0qSqOv2Qf+CuVLARY9FhzI3rzhjH3ie4qa71gkrFavmkGDoyY7LzKLOP/VJp0tHZtnm; 25:BDSJ9HrgdQKQdHEFufgN0WQXnOPX+FWz/Y2n0iXi9299HI9N2DKN8fQ3psqN9uK7PewXDxBEYf4IXHlRD2g40XiBaptpEL+DWFk1ipwvMiRbjVrLCB4Dq/x7pu6tUdA632eLALD73vloe9q7yJoiNbqoK6kwCfiDjDS2CmDfiyBBl9wh8KGzfnUKxeGIUhZtT3mRiaMHneLfGKh93aW0OsN/BEN44GwVZJKRx2gu6ylC5KkWPgAOgrRfusQw0xce2i+RnTKvLvX51gNnag0NA0z9DUl0N04d3VdF/t/9S3B8P7TFzMms2QafPLMlJpE81qicRwtAFcbS63GGcOkLVQ==; 31:bainqoD3WrffB4ajx6+WUrnVP64tESDYLuI9JoCRXQX3GkqBaKgCz49ThJaJkOzVMhRXbobv7/+b6PLCb/h4HCzUp6cEJSADjZ6HsDSkvS/6xDmyf0KTsV6pkrOyfMEKwWXRT1OFdVxORepdl+vwsVoiTqFeYUzT3sTjtMXVJq4pEkjBaXpH9/Az1P/27E2zEgDqadUOlvRDwEFvxBRoa0eYPsDwgs/yUNL9S5vLBhQ= X-MS-TrafficTypeDiagnostic: BL0PR07MB4994: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4994; 20:SqL/Nc9fPCE+AT0TC+4RTg094nNPhTzOTlBvP4Xc0oHATChDnI3g/94Gh7Iee1Km9zNXipGnSTpHC88Zf2SD1cTuIDeb3kRzMv9hknL6WXA1S7e4ftURlaj0uhhQ3Pa/chHIYpD+mt/1X69gEfpjdUYc72RPWss2cVnzf0+1+DfrNu05raxYupxPkBQVO1gjfto8F+wTSASPzy6ZRa1DJq3UFAE8PshZFzVZIejFPTc4zcfB5GUwQf8nCOUZpauX0yPWF7Ee/yyPMqnHAaDh6OjmKDvXg70Nk9W+L7nv+Coc3+ICiAsErI2XSclRlZJVcvE+xNwvW3YY5+JqZnhaEE1dDLpvCEsxxyEfXoBPCA5OcaRWFElct0iUjqyPowOdku070cMKSuUN+yY8MyxGVSntWFhVH1hj56w+aQZoYuLyzOvi7DkckBx3+VfmwFdBe6NnNxPYgSFwg2oQ1GV5idS0cbAYw/4OxlbB7HtqX9KY3OgO7Dn4/JrMpRtmDyKQok3jSuZ0SoKv901OxFDMLwbF839e5krwoAR2uK2SMaJcTXnBGMDabixIGoJ2XxU7x4sTtXgwGotwt7ZfzPKnh9daBwR3eAK3KgRaPyQy+Oc=; 4:iW3F/IQCEPQnhH10yOeup8B2IlFfjbzPGSx//tyi3wbaiC48gtzVnjhzL9VBTqgCVUj/ULbG7E4l9O0Tv9GomhaAFm5NA7ieOcB7R2Jm2zDjAXz115PX85t6exK8VHxvK0VCjf9GZ3JsYqgFTJiq6wx1FQWEUbnY1MssVuVCoDub+fahwikNM2JIzdirtRWqa34pM+6+a+MiEjE8ngyv4sWkYERJZ41bgl7OXSb/KvVwineYQ0UqRqXWDwQFqHLpj4939sIQxJd8h+Mx/FLMAyY9fnlMou4Ej2RPyhbA+vnoZ/iInshNw0LyEOFS8+f5 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231355)(944501410)(52105095)(3002001)(93006095)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051); SRVR:BL0PR07MB4994; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4994; X-Forefront-PRVS: 0814A2C7A3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(136003)(39860400002)(396003)(199004)(189003)(13464003)(76176011)(8676002)(6496006)(93886005)(47776003)(68736007)(3846002)(5660300001)(55016002)(6116002)(1076002)(6666003)(5009440100003)(4326008)(6916009)(81166006)(33656002)(25786009)(81156014)(105586002)(106356001)(23726003)(8936002)(229853002)(50466002)(7416002)(33716001)(53546011)(386003)(478600001)(55236004)(26005)(53936002)(14444005)(186003)(956004)(476003)(486006)(11346002)(446003)(42882007)(16526019)(44832011)(9686003)(54906003)(58126008)(316002)(97736004)(33896004)(66066001)(16586007)(305945005)(72206003)(7736002)(52116002)(2906002)(6246003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4994; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4994; 23:MWRX8OjZE+dJiIb/8zi9lyY2wO3Q6REBmoF/01qOz?= =?us-ascii?Q?AjvXPz8jcrRmIvB9/xOeHYVuztcaQFU51R1yHITbcHFvzThM/H5gpjmU0uif?= =?us-ascii?Q?TMv3/MHYGGBPNTXweWDFWeWzdkbJcixrul7fniARknICiuUMdwOBJcBC4fBe?= =?us-ascii?Q?Vv7++V/Os/vaZjm+ySQs0pPJimXid+zM9QqerB4PttZvV79/ty802Y0prgjh?= =?us-ascii?Q?D+yCDbKrCGeubQsW9wmuSgePRykTi0OW4rFwF95J0kP1Hd+kj5sIOjAvj738?= =?us-ascii?Q?jy6upN/r1lZpaAHgfcsDfCVY2FRwy+BihdceNsTxMuS2TJMTvXcv4mZ7NlB2?= =?us-ascii?Q?yW2k+GLUDbs5Pf7Fd7qQpsNVJryd1Pgd23N8F+QLdzvbdpEMkN1sjIH/6YTf?= =?us-ascii?Q?n0VCnIsf8vvTO7VR8RT3tYkUJ2ssYtMZhq1DBRwZzGPfKj5qEJ2ecJxHJm+D?= =?us-ascii?Q?ggl1ASttWUpQco/fDJTnghP0PcLT+H0IU4VJ3KknSYlPfUYYugUAls3cSah3?= =?us-ascii?Q?3Im3ae6izI2c2HEuk7Tipu5mxQEa0Bfhku8rw8+8nfbn7dNVAM550aoH/Gn2?= =?us-ascii?Q?Wrj7Ew1Etngd/3nhiFBbC5KNLGES5oOBt/7av+QGvS41pRV4YiJaNJzLylt9?= =?us-ascii?Q?QfvFBJ18/wxhR+PP9KpPBEuHLdm4S7tESEXBRQytryy9no3crrzBguursFFV?= =?us-ascii?Q?Zft+PKLiW1ae/6F7iwDnHaFUx832HL9KwYvJVGOZ7RoWt1D0rVSSfzBRzIee?= =?us-ascii?Q?NExlIhP4qepoAMbAwDLMqcFwcpu4cAiQfunLUkIx0c6xAzNDnJr4aO5qvH8D?= =?us-ascii?Q?NeKPQtSfek/lAlMtU+kKpSu+9BcHSJjMRfKDFXcXe49cPjKjMU56VDgjf8Ka?= =?us-ascii?Q?pz5Pnxy1QEa1McDSx7FH2jvqHfWK9IAGmuk0Wxz6Z/Li15M+lsAJLTT6slC5?= =?us-ascii?Q?cujtcF87nY/FWFwH4bQiALbkFyMscNvnejONWd7NjQqJh8Pmn6Utr0/opVDN?= =?us-ascii?Q?USIrBpRwq2tMgFotKrRdQQ57m084ZaoKe5fpHih0Q5AKu3xSkW80upURunm+?= =?us-ascii?Q?4jVUaRRZOYSQCJiUpUTbbAQMbtVQJKv0Fl5GAMEtZ33vyrQexOHx3ab3ysKe?= =?us-ascii?Q?+i3StQx8QivkR/51NdCyJ/0OyEnpGSoUG7L60Qy4hZfooYuuE07TbxXA58xm?= =?us-ascii?Q?yJKreAd3y4iyAeic0L1ZzjDtPK4/uYqn2Uxa4qilMdvVzfJIqK6KpLYbMong?= =?us-ascii?Q?PbmsXuli7rCS7UbMlb5Ys0GBtzwRxPxN56RmNJz9ZdxWfonCq4Wq/yuFrcc6?= =?us-ascii?Q?H8X6luhdkdI3gSTW0r9bqQEHwSctmPv0OsLwgvh3IGIdmJSufFPQBGYEjFqB?= =?us-ascii?Q?4JlYt9iJO+f9gw4yVOAGooJNaNjoWpIgIZLwtko93Yq1DXBtu2yp9QgJhS4y?= =?us-ascii?Q?hl1/5Mh27s/O+xhskEA+vafhwuSq91QDzlP02yCOnBS6Dij+EHFMz3/ai21f?= =?us-ascii?Q?VgWtFxnLVcEFQ=3D=3D?= X-Microsoft-Antispam-Message-Info: eoie1s4wdUYgnPA0wnq24qsf/eR9VPur1avC698GL3Fi5btF+xgt9GCb2BecBgotvlsoCuGqwc+Tj2G1Ni39GTEWZoFWmbJ1DZ4rdgz5LBMs4ErmjlaiSwm02LPXs0PnGp5xMypf7hPC8UXFMq+LfT3l0ZZP4nwCP4E2j5cwfYHLaJ3+DT0b90bxPMHwz0nj4lpHnnwmRI8/l4HmoQaMovsgGp0fxiO1EfNZzydpNcQ1wRdaF7i5qiJGm7aBXzDRat18lo0KAb/gcM30vur0cUtz5Ni9wMtOmYqNi2z7AQqabQV340y9CKzkJPI6Zj3SweXjXc8W2zt4yEO+Ep0WtqYyqdYc7kHdZOTu/56PJKk= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4994; 6:X2ZGdw+z8g71KzlBJRT/IS3ABmeDJaf5CxRVghHM4fPHAkzNOpOoH25r2Fr5FyJ02tgtan39xNUer2NtQbk9R8I41zOTuVLl5cUcSuGEUjputEw+XcjzKgo+nce+Hw1ULG/ABon8wYwVIT3vH9p/mdEt+8I/73MrVVeFXELCX+nbEgiRDg8Aj+Ou9vlmxhu3DMlunTkK23UX5W+NjAeUbJOJKWEhTt17ynsNYiPwK2pBd7Q4HB2m98OxjRJaOw20p/NoGdNe0MVw54m/ihn2C7I2y84UTAvEYHe45VyxWAO+dczI8hBBrjOgWkhlgK66nZd4t50dihE2r4QFCiv+PydFvLOokPCucyCYE1qvbpRCd0u1JusOWl9wqMYgWCwBuuyWmbxi7lV3qewOF6jZRohMIHYEcf9L4lGQj1BPivTo9iPFVuOqmPNINM8fNOVzHjI1knKVLxY9O3/PJbSL2g==; 5:7fz/u51EP214Qts8SlGf4wMFXTtS/xsAqze7m32gWxfM24QBVQmD/ZiYYITpFmsGAy2Pdisfuy0w+ky2weS8JJ3qcNsXV86BYhciZENHrkBuGwqCADU6lUvDHxq297OAi1uouNQtaLPkf2c3QAMgXKp9iGkg4IEzuaZ4qO6arS0=; 7:lEb8tbnsmT+J7FDVFHQlkQaCOBcrqprZ5XRidqFvGur2TWS+3dm9faF0X46T5yF/9uEaWEEUqDNZAlh0GvS+23S8vkZpVEyktt6pdbbWuwX2CNSfBc1sTG8qXYQrc+gougIcL/T2ka8yuaC9uO54AdxILn7ZCW7PcxcA9yPvcPTNBt6krQy7cxem6abUhN79+e7Fay6iHvn7rn2VcALeQQZMHbR9tz8sOp5+IS6n7eQHq94VoxuU9a7nwIDnCEAd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2018 18:14:30.2558 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 380d9b5b-7cf6-4194-5f6f-08d6295c12c3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4994 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 18:14:36 -0000 -----Original Message----- > Date: Wed, 3 Oct 2018 21:00:37 +0300 > From: Andrew Rybchenko > To: Jerin Jacob > CC: Wenzhuo Lu , Jingjing Wu , > Bernard Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Ferruh Yigit > , Olivier Matz , > dev@dpdk.org, shahafs@mellanox.com, "Ananyev, Konstantin" > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > On 03.10.2018 20:12, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Wed, 3 Oct 2018 13:27:13 +0530 > > > From: Jerin Jacob > > > To: Andrew Rybchenko > > > CC: Wenzhuo Lu , Jingjing Wu , > > > Bernard Iremonger , John McNamara > > > , Marko Kovacevic , > > > Thomas Monjalon , Ferruh Yigit > > > , Olivier Matz , > > > dev@dpdk.org, shahafs@mellanox.com, "Ananyev, Konstantin" > > > > > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > > > checksum definition > > > User-Agent: Mutt/1.10.1 (2018-07-13) > > > > > > External Email > > > > > > -----Original Message----- > > > > Date: Wed, 3 Oct 2018 10:34:52 +0300 > > > > From: Andrew Rybchenko > > > > To: Jerin Jacob , Wenzhuo Lu > > > > , Jingjing Wu , Bernard > > > > Iremonger , John McNamara > > > > , Marko Kovacevic , > > > > Thomas Monjalon , Ferruh Yigit > > > > , Olivier Matz > > > > CC: dev@dpdk.org, shahafs@mellanox.com, "Ananyev, Konstantin" > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > > > > checksum definition > > > > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 > > > > Thunderbird/60.0 > > > > > > > > > > > > On 10/2/18 10:24 PM, Jerin Jacob wrote: > > > > > > > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and > > > > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum > > > > failure. > > > > > > > > - To use hardware Rx outer UDP checksum offload, the user needs to > > > > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath. > > > > > > > > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum failure > > > > similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag. > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > > > 1. I'm not sure that it is OK that mbuf and ethdev changes go in one patch. > > > > It seems typically mbuf changes go separately and mbuf changes should > > > > be applied to main dpdk repo. > > > > > > I don't have strong opinion on this. If there are no other objection, I > > > will split the patch further as mbuf and ethdev as you pointed out. > > > > > > > 2. I'd like to see thought why single bit is used for outer L2 checksum when > > > > 2 bits (UNKNOWN, BAD, GOOD, NONE) are used for PKT_RX_L4_CKSUM. > > > > May be it is OK, but it would be useful to state explicitly why it is decided > > > > to go this way. > > > I am following the scheme similar to OUTER IP checksum where we have only > > > one bit filed(PKT_RX_EIP_CKSUM_BAD). I will mention in the git commit. > > > > > > > > > > 3. PKT_RX_L4_CKSUM_MASK description says nothing if it is inner or outer. > > > > May be it is not directly related to changeset, but I think it would be really > > > > useful to clarify it. > > > I will update the comment. > > Hi Andrew, > > > > I looked at the other definitions in mbuf.h, according the documentation, > > If nothing is mentioned it is treated as inner if the packet is > > tunneled else it is outer most. So I would like avoid confusion by > > adding "inner" in the exiting PKT_RX_L4_CKSUM_MASK comment. > > Technically it is not correct to say "inner" if the packet is not > > tunneled. So I am untouching the exiting comment. > > > > Yes, it is incorrect to say that it is inner. How does application find > how to treat PKT_RX_L4_CKSUM (inner or outer)? > Should it rely on packet type provided in mbuf? AFAIK, Finding is it a tunneled packet or not is through ptype or SW has to parse the packet. For example, testpmd chooses later method using "csum parse-tunnel on " to detect the presence of the tunnel. > Is it specified/mentioned somewhere? I don't know. It it not directly related to this change set, Olivier may know additional details. > > Andrew.