* Re: [dpdk-dev] [PATCH] examples/vdpa: replace strncpy with strscpy function
2018-10-03 19:34 ` [dpdk-dev] [PATCH] examples/vdpa: replace strncpy with strscpy function Xiaolong Ye
@ 2018-10-03 13:31 ` Maxime Coquelin
2018-10-03 20:28 ` Ye Xiaolong
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Coquelin @ 2018-10-03 13:31 UTC (permalink / raw)
To: Xiaolong Ye, dev, Tiwei Bie, Zhihong Wang
Cc: xiao.w.wang, Rami Rosen, Wang Haiyue
On 10/03/2018 09:34 PM, Xiaolong Ye wrote:
> rte_strscpy is safer to use.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> examples/vdpa/main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
I'll squash it into initial commit.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vdpa: replace strncpy with strscpy function
2018-10-03 20:28 ` Ye Xiaolong
@ 2018-10-03 14:13 ` Maxime Coquelin
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2018-10-03 14:13 UTC (permalink / raw)
To: Ye Xiaolong
Cc: dev, Tiwei Bie, Zhihong Wang, xiao.w.wang, Rami Rosen, Wang Haiyue
On 10/03/2018 10:28 PM, Ye Xiaolong wrote:
> On 10/03, Maxime Coquelin wrote:
>>
>>
>> On 10/03/2018 09:34 PM, Xiaolong Ye wrote:
>>> rte_strscpy is safer to use.
>>>
>>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>>> ---
>>> examples/vdpa/main.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
>> I'll squash it into initial commit.
Squashed and pushed to dpdk-next-virtio.
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] examples/vdpa: replace strncpy with strscpy function
[not found] <32f53ad0-92f4-4415-7a05-eff0c6fa779d@redhat.com>
@ 2018-10-03 19:34 ` Xiaolong Ye
2018-10-03 13:31 ` Maxime Coquelin
0 siblings, 1 reply; 4+ messages in thread
From: Xiaolong Ye @ 2018-10-03 19:34 UTC (permalink / raw)
To: dev, Maxime Coquelin, Tiwei Bie, Zhihong Wang
Cc: xiao.w.wang, Rami Rosen, Wang Haiyue, Xiaolong Ye
rte_strscpy is safer to use.
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
examples/vdpa/main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
index f96fa88b7..c5e8f58ec 100644
--- a/examples/vdpa/main.c
+++ b/examples/vdpa/main.c
@@ -13,6 +13,7 @@
#include <rte_vhost.h>
#include <rte_vdpa.h>
#include <rte_pci.h>
+#include <rte_string_fns.h>
#include <cmdline_parse.h>
#include <cmdline_socket.h>
@@ -73,7 +74,7 @@ parse_args(int argc, char **argv)
case 0:
if (strncmp(long_option[idx].name, "iface",
MAX_PATH_LEN) == 0) {
- strncpy(iface, optarg, MAX_PATH_LEN);
+ rte_strscpy(iface, optarg, MAX_PATH_LEN);
printf("iface %s\n", iface);
}
if (!strcmp(long_option[idx].name, "interactive")) {
@@ -325,7 +326,7 @@ static void cmd_create_vdpa_port_parsed(void *parsed_result,
struct cmd_create_result *res = parsed_result;
struct rte_vdpa_dev_addr addr;
- strncpy(vports[devcnt].ifname, res->socket_path, MAX_PATH_LEN);
+ rte_strscpy(vports[devcnt].ifname, res->socket_path, MAX_PATH_LEN);
if (rte_pci_addr_parse(res->bdf, &addr.pci_addr) != 0) {
cmdline_printf(cl, "Unable to parse the given bdf.\n");
return;
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vdpa: replace strncpy with strscpy function
2018-10-03 13:31 ` Maxime Coquelin
@ 2018-10-03 20:28 ` Ye Xiaolong
2018-10-03 14:13 ` Maxime Coquelin
0 siblings, 1 reply; 4+ messages in thread
From: Ye Xiaolong @ 2018-10-03 20:28 UTC (permalink / raw)
To: Maxime Coquelin
Cc: dev, Tiwei Bie, Zhihong Wang, xiao.w.wang, Rami Rosen, Wang Haiyue
On 10/03, Maxime Coquelin wrote:
>
>
>On 10/03/2018 09:34 PM, Xiaolong Ye wrote:
>> rte_strscpy is safer to use.
>>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>> examples/vdpa/main.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>
>Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
>I'll squash it into initial commit.
Thanks.
Xiaolong
>
>Thanks,
>Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-03 14:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <32f53ad0-92f4-4415-7a05-eff0c6fa779d@redhat.com>
2018-10-03 19:34 ` [dpdk-dev] [PATCH] examples/vdpa: replace strncpy with strscpy function Xiaolong Ye
2018-10-03 13:31 ` Maxime Coquelin
2018-10-03 20:28 ` Ye Xiaolong
2018-10-03 14:13 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).