* [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede [not found] <CGME20181004131626eucas1p1161f9245280c8a4ca3a7d5b2f93b8ee2@eucas1p1.samsung.com> @ 2018-10-04 13:18 ` Ilya Maximets 2018-10-04 13:37 ` Bruce Richardson 2018-10-04 14:51 ` Ferruh Yigit 0 siblings, 2 replies; 7+ messages in thread From: Ilya Maximets @ 2018-10-04 13:18 UTC (permalink / raw) To: dev, Bruce Richardson; +Cc: Luca Boccassi, Ilya Maximets This functionality was missed while adding new drivers to the meson build. Fixes: 1d75caf81474 ("net/avf: add meson support") Fixes: 30d3d0168301 ("net/qede: add in meson build") Signed-off-by: Ilya Maximets <i.maximets@samsung.com> --- drivers/net/avf/base/meson.build | 3 +++ drivers/net/qede/base/meson.build | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build index 90fd6b445..6f3d7192e 100644 --- a/drivers/net/avf/base/meson.build +++ b/drivers/net/avf/base/meson.build @@ -8,6 +8,9 @@ sources = [ error_cflags = ['-Wno-pointer-to-int-cast'] c_args = cflags +if allow_experimental_apis + c_args += '-DALLOW_EXPERIMENTAL_API' +endif foreach flag: error_cflags if cc.has_argument(flag) c_args += flag diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build index 59b41c895..71b89737d 100644 --- a/drivers/net/qede/base/meson.build +++ b/drivers/net/qede/base/meson.build @@ -45,6 +45,9 @@ error_cflags = [ '-Wno-pointer-bool-conversion', ] c_args = cflags +if allow_experimental_apis + c_args += '-DALLOW_EXPERIMENTAL_API' +endif foreach flag: error_cflags if cc.has_argument(flag) c_args += flag -- 2.17.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede 2018-10-04 13:18 ` [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede Ilya Maximets @ 2018-10-04 13:37 ` Bruce Richardson 2018-10-26 13:56 ` Ferruh Yigit 2018-10-04 14:51 ` Ferruh Yigit 1 sibling, 1 reply; 7+ messages in thread From: Bruce Richardson @ 2018-10-04 13:37 UTC (permalink / raw) To: Ilya Maximets; +Cc: dev, Luca Boccassi On Thu, Oct 04, 2018 at 04:18:35PM +0300, Ilya Maximets wrote: > This functionality was missed while adding new drivers to > the meson build. > > Fixes: 1d75caf81474 ("net/avf: add meson support") > Fixes: 30d3d0168301 ("net/qede: add in meson build") > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com> > --- Acked-by: Bruce Richardson <bruce.richardson@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede 2018-10-04 13:37 ` Bruce Richardson @ 2018-10-26 13:56 ` Ferruh Yigit 0 siblings, 0 replies; 7+ messages in thread From: Ferruh Yigit @ 2018-10-26 13:56 UTC (permalink / raw) To: Bruce Richardson, Ilya Maximets; +Cc: dev, Luca Boccassi On 10/4/2018 2:37 PM, Bruce Richardson wrote: > On Thu, Oct 04, 2018 at 04:18:35PM +0300, Ilya Maximets wrote: >> This functionality was missed while adding new drivers to >> the meson build. >> >> Fixes: 1d75caf81474 ("net/avf: add meson support") >> Fixes: 30d3d0168301 ("net/qede: add in meson build") >> >> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> >> --- > Acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede 2018-10-04 13:18 ` [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede Ilya Maximets 2018-10-04 13:37 ` Bruce Richardson @ 2018-10-04 14:51 ` Ferruh Yigit 2018-10-04 15:10 ` Ilya Maximets 1 sibling, 1 reply; 7+ messages in thread From: Ferruh Yigit @ 2018-10-04 14:51 UTC (permalink / raw) To: Ilya Maximets, dev, Bruce Richardson; +Cc: Luca Boccassi On 10/4/2018 2:18 PM, Ilya Maximets wrote: > This functionality was missed while adding new drivers to > the meson build. Is there any call from base code to experimental APIs? What do you think adding this when we need it, since I have feeling that this may not be needed. > > Fixes: 1d75caf81474 ("net/avf: add meson support") > Fixes: 30d3d0168301 ("net/qede: add in meson build") > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com> > --- > drivers/net/avf/base/meson.build | 3 +++ > drivers/net/qede/base/meson.build | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build > index 90fd6b445..6f3d7192e 100644 > --- a/drivers/net/avf/base/meson.build > +++ b/drivers/net/avf/base/meson.build > @@ -8,6 +8,9 @@ sources = [ > > error_cflags = ['-Wno-pointer-to-int-cast'] > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: error_cflags > if cc.has_argument(flag) > c_args += flag > diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build > index 59b41c895..71b89737d 100644 > --- a/drivers/net/qede/base/meson.build > +++ b/drivers/net/qede/base/meson.build > @@ -45,6 +45,9 @@ error_cflags = [ > '-Wno-pointer-bool-conversion', > ] > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: error_cflags > if cc.has_argument(flag) > c_args += flag > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede 2018-10-04 14:51 ` Ferruh Yigit @ 2018-10-04 15:10 ` Ilya Maximets 2018-10-04 15:23 ` Bruce Richardson 2018-10-25 13:29 ` Ferruh Yigit 0 siblings, 2 replies; 7+ messages in thread From: Ilya Maximets @ 2018-10-04 15:10 UTC (permalink / raw) To: Ferruh Yigit, dev, Bruce Richardson; +Cc: Luca Boccassi On 04.10.2018 17:51, Ferruh Yigit wrote: > On 10/4/2018 2:18 PM, Ilya Maximets wrote: >> This functionality was missed while adding new drivers to >> the meson build. > > Is there any call from base code to experimental APIs? What do you think adding > this when we need it, since I have feeling that this may not be needed. The patch itself does not enable the experimental APIs, it only adds the ability to enable them in the future. It's actually pretty hard for the person that not much familiar with meson to find out why your code provides deprecation warnings. I spent few hours trying to make it work but failed. After that Bruce found that 'base' code parts ignores 'allow_experimental_apis' flag and prepared the patch. Thank you, Bruce! This patch possibly will save a few hours for someone like me, who will try to enable experimental APIs for avf and qede drivers. And I already need avf part for my patch set with nanosleep based delay: http://patches.dpdk.org/cover/46088/ > >> >> Fixes: 1d75caf81474 ("net/avf: add meson support") >> Fixes: 30d3d0168301 ("net/qede: add in meson build") >> >> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> >> --- >> drivers/net/avf/base/meson.build | 3 +++ >> drivers/net/qede/base/meson.build | 3 +++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build >> index 90fd6b445..6f3d7192e 100644 >> --- a/drivers/net/avf/base/meson.build >> +++ b/drivers/net/avf/base/meson.build >> @@ -8,6 +8,9 @@ sources = [ >> >> error_cflags = ['-Wno-pointer-to-int-cast'] >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: error_cflags >> if cc.has_argument(flag) >> c_args += flag >> diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build >> index 59b41c895..71b89737d 100644 >> --- a/drivers/net/qede/base/meson.build >> +++ b/drivers/net/qede/base/meson.build >> @@ -45,6 +45,9 @@ error_cflags = [ >> '-Wno-pointer-bool-conversion', >> ] >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: error_cflags >> if cc.has_argument(flag) >> c_args += flag >> > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede 2018-10-04 15:10 ` Ilya Maximets @ 2018-10-04 15:23 ` Bruce Richardson 2018-10-25 13:29 ` Ferruh Yigit 1 sibling, 0 replies; 7+ messages in thread From: Bruce Richardson @ 2018-10-04 15:23 UTC (permalink / raw) To: Ilya Maximets; +Cc: Ferruh Yigit, dev, Luca Boccassi On Thu, Oct 04, 2018 at 06:10:12PM +0300, Ilya Maximets wrote: > On 04.10.2018 17:51, Ferruh Yigit wrote: > > On 10/4/2018 2:18 PM, Ilya Maximets wrote: > >> This functionality was missed while adding new drivers to > >> the meson build. > > > > Is there any call from base code to experimental APIs? What do you think adding > > this when we need it, since I have feeling that this may not be needed. > > The patch itself does not enable the experimental APIs, it only > adds the ability to enable them in the future. It's actually > pretty hard for the person that not much familiar with meson to > find out why your code provides deprecation warnings. I spent > few hours trying to make it work but failed. After that Bruce found > that 'base' code parts ignores 'allow_experimental_apis' flag and > prepared the patch. Thank you, Bruce! > This patch possibly will save a few hours for someone like me, who > will try to enable experimental APIs for avf and qede drivers. > > And I already need avf part for my patch set with nanosleep > based delay: > http://patches.dpdk.org/cover/46088/ > +1, I think it should be added, as it basically just is allowing passthrough of the flag to the base drivers. /Bruce ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede 2018-10-04 15:10 ` Ilya Maximets 2018-10-04 15:23 ` Bruce Richardson @ 2018-10-25 13:29 ` Ferruh Yigit 1 sibling, 0 replies; 7+ messages in thread From: Ferruh Yigit @ 2018-10-25 13:29 UTC (permalink / raw) To: Ilya Maximets, dev, Bruce Richardson; +Cc: Luca Boccassi On 10/4/2018 4:10 PM, Ilya Maximets wrote: > On 04.10.2018 17:51, Ferruh Yigit wrote: >> On 10/4/2018 2:18 PM, Ilya Maximets wrote: >>> This functionality was missed while adding new drivers to >>> the meson build. >> >> Is there any call from base code to experimental APIs? What do you think adding >> this when we need it, since I have feeling that this may not be needed. > > The patch itself does not enable the experimental APIs, it only > adds the ability to enable them in the future. It's actually > pretty hard for the person that not much familiar with meson to > find out why your code provides deprecation warnings. I spent > few hours trying to make it work but failed. After that Bruce found > that 'base' code parts ignores 'allow_experimental_apis' flag and > prepared the patch. Thank you, Bruce! > This patch possibly will save a few hours for someone like me, who > will try to enable experimental APIs for avf and qede drivers. > > And I already need avf part for my patch set with nanosleep > based delay: > http://patches.dpdk.org/cover/46088/ Taking into account that there is already a need, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-26 13:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20181004131626eucas1p1161f9245280c8a4ca3a7d5b2f93b8ee2@eucas1p1.samsung.com>
2018-10-04 13:18 ` [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede Ilya Maximets
2018-10-04 13:37 ` Bruce Richardson
2018-10-26 13:56 ` Ferruh Yigit
2018-10-04 14:51 ` Ferruh Yigit
2018-10-04 15:10 ` Ilya Maximets
2018-10-04 15:23 ` Bruce Richardson
2018-10-25 13:29 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).