From: Ilya Maximets <i.maximets@samsung.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
jfreimann@redhat.com, nicknickolaev@gmail.com,
bruce.richardson@intel.com, alejandro.lucero@netronome.com
Cc: dgilbert@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 01/19] vhost: fix messages error checks
Date: Thu, 4 Oct 2018 17:48:22 +0300 [thread overview]
Message-ID: <20181004144603eucas1p1ffc413c11739c71590426be86ee2122d~abxYy6JFu2771527715eucas1p1h@eucas1p1.samsung.com> (raw)
In-Reply-To: <20181004081403.8039-2-maxime.coquelin@redhat.com>
On 04.10.2018 11:13, Maxime Coquelin wrote:
> Return of message handling has now changed to an enum that can
> take non-negative value that is not zero in case a reply is
> needed. But the code checking the variable afterwards has not
> been updated, leading to success messages handling being
> treated as errors.
>
> Fixes: 2f270595c05d ("vhost: rework message handling as a callback array")
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
Acked-by: Ilya Maximets <i.maximets@samsung.com>
next prev parent reply other threads:[~2018-10-04 14:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 8:13 [dpdk-dev] [PATCH v3 00/19] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 01/19] vhost: fix messages error checks Maxime Coquelin
2018-10-04 14:48 ` Ilya Maximets [this message]
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 02/19] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-04 14:48 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 03/19] vhost: clarify reply-ack in case a reply was already sent Maxime Coquelin
2018-10-04 14:50 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 04/19] vhost: fix payload size of reply Maxime Coquelin
2018-10-04 14:49 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-04 14:59 ` Ilya Maximets
2018-10-04 15:06 ` Maxime Coquelin
2018-10-04 15:11 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 06/19] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-04 14:59 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 07/19] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-05 9:56 ` Ilya Maximets
2018-10-08 12:56 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 08/19] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 09/19] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 10/19] vhost: add config flag for postcopy feature Maxime Coquelin
2018-10-05 11:55 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 11/19] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-05 11:58 ` Ilya Maximets
2018-10-05 13:36 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 12/19] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-05 12:02 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 13/19] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-05 12:34 ` Ilya Maximets
2018-10-08 13:03 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 14/19] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-05 12:37 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 15/19] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-04 8:14 ` [dpdk-dev] [PATCH v3 16/19] vhost: add support to postcopy's end request Maxime Coquelin
2018-10-04 8:14 ` [dpdk-dev] [PATCH v3 17/19] vhost: enable postcopy protocol feature Maxime Coquelin
2018-10-04 8:14 ` [dpdk-dev] [PATCH v3 18/19] vhost: add flag to enable postcopy live-migration Maxime Coquelin
2018-10-05 14:24 ` Ilya Maximets
2018-10-08 16:25 ` Ilya Maximets
2018-10-08 16:54 ` Maxime Coquelin
2018-10-04 8:14 ` [dpdk-dev] [PATCH v3 19/19] net/vhost: add parameter to enable postcopy support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20181004144603eucas1p1ffc413c11739c71590426be86ee2122d~abxYy6JFu2771527715eucas1p1h@eucas1p1.samsung.com' \
--to=i.maximets@samsung.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dgilbert@redhat.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).