From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 94F021B4A3 for ; Thu, 4 Oct 2018 16:48:30 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181004144830euoutp01e0892b4b0658091a05df3992d1a0bb44~abzhTZQDp0389703897euoutp01L for ; Thu, 4 Oct 2018 14:48:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181004144830euoutp01e0892b4b0658091a05df3992d1a0bb44~abzhTZQDp0389703897euoutp01L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1538664510; bh=9UqHXu3diBJ1kqpSjUiy71eFBVFH7LfjfY2d2S95Xfc=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=P6Oi3f85MCjaksFhAmnQkFl/E7G1UA0BXFXSo8maE+apowKZK/2gSsAXJQBxq/fZA 0+9ViJPhEDzffy0Sjesq9tUtHexZu/ULjH9HMbKlqEn3/1M+l1iGsfjS4t45Jc1S9x aS9nl0AWAN7YC1RiLE+h+Y9OogIlHsoitAlWLXMU= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181004144829eucas1p19c9c803a4ea2cf53722b2139de6a186d~abzg3cDhu2644026440eucas1p1e; Thu, 4 Oct 2018 14:48:29 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 84.59.04806.D3826BB5; Thu, 4 Oct 2018 15:48:29 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181004144829eucas1p20df7fb6baf537a04c5b29ad090db7b66~abzgFItes0950109501eucas1p2C; Thu, 4 Oct 2018 14:48:29 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181004144828eusmtrp1935f37a1759611d4c917005ba9ab4217~abzfzc1F_2449724497eusmtrp1i; Thu, 4 Oct 2018 14:48:28 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-df-5bb6283de1da Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 97.85.04128.C3826BB5; Thu, 4 Oct 2018 15:48:28 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181004144828eusmtip171565623ce90270c41711dae322c160a~abzfJKRRQ0267902679eusmtip1K; Thu, 4 Oct 2018 14:48:28 +0000 (GMT) To: Maxime Coquelin , dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com Cc: dgilbert@redhat.com, stable@dpdk.org From: Ilya Maximets Date: Thu, 4 Oct 2018 17:50:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181004081403.8039-4-maxime.coquelin@redhat.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHec85247a5DgVH6wIl4iKl0qL86GyomAQQYIfrH3QpQcVncrm XSqtTLOUZYK1wjRz1vKCqbNiWM7LyJGmqSl5v0QzVHKaaOZyO0p++z3P/7n9X14SF7RzXMmY +CRGFi+JE3JtCU3nWo/vCU+N+JB51YPuXlJh9JA6iF5YasboAs0Yj+7PXePR3dWVBN15R0vQ hvJBgt7M2+DRTVlmjG7oLcJO2YnWyyo5orfKUZ6oQmvERCV3J3HRYssAV1TYqEYXuZdtj0cy cTEpjMz/ZLht9P0yPZ5YSKTV9uaiLFSD5yMbEqhA6FOouPnIlhRQLxDU5ixhbLCMYKrfsB2Y EJjUBbydlqLs94gVqhDock1WQUD9QvB9A1nYkboEXx5qrd1O1AiC/so+rkXAKU+oG5ixFnEp H+h61W5lgnIHbZaCY2FnKhTaJ8qteT7lAB8fzRAWtqGCYN04sj3HBW4sv+SwfACa55/glmVA DfLg87gRZ5tTwJA9jdizz8KyeZHLsiPM6Ru37ewDw4N7BMvXYfyWEbGD8hCU6DYxVgiCxp/d Ww3k1jYvqHvnz6ZPQ7vCYozcYnsYmndg77GHIk0Jzqb5kHdbwFa7w5/Wqu13d4XhBRNPgYTK XS6Vu5wpdzlT/t9bhgg1cmGS5dIoRh4Qz6T6ySVSeXJ8lF9EgvQ12vpbhk39yhvUsnFFhygS CffwfxzUiAUcSYo8XapDQOJCJ37HZpNYwI+UpGcwsoQwWXIcI9ehvSQhdOGrSuvFAipKksTE MkwiI9tRMdLGNQt1BfZ+Mub360Mx36b6qckavDj477Xmttjm3+HO6iZz+IWOrw7flKlH4Hlc R8jss0yxyTDdmXTsTJuPSlW6WjG3VpvRFkDNegWWng9uaL36OCwiM1KhDYksPTc25J3pcTQt ZCC4a1Snr87hPt3/oXhhwtxjt47K3CpuDge7DfqvCAl5tOSwNy6TS/4B0u4x1FcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t/xu7o2GtuiDf516Vqc+7SMyeLGKnuL d5+2M1n0brvHbnGl/Se7xbk1S1ksjnXuYbE4vfAai8W/jj/sFlsb/jNZbL44icmB2+PXgqWs Hjtn3WX3WLznJZPH9O6HzB7v911l8+jbsooxgC1Kz6Yov7QkVSEjv7jEVina0MJIz9DSQs/I xFLP0Ng81srIVEnfziYlNSezLLVI3y5BL2PiguPMBX0sFesutjM2MK5l7mLk5JAQMJGY1Lif sYuRi0NIYCmjxPTVTawQCSmJH78uQNnCEn+udbGB2EIC7xklLh4RArGFBSIlLs/YwwTSLCJw h1Fiy6wzjCAJZgENifVXn0BNPc4osffGe7BJbAI6EqdWHwEr4hWwk5h25BlYnEVARWJPwwQw W1QgQmL18hesEDWCEidnPmEBsTkF7CV+vbzDBrFAXeLPvEvMELa4RNOXlawQtrzE9rdzmCcw Cs1C0j4LScssJC2zkLQsYGRZxSiSWlqcm55bbKRXnJhbXJqXrpecn7uJERip24793LKDsetd 8CFGAQ5GJR7eCYrbooVYE8uKK3MPMUpwMCuJ8B79tzVaiDclsbIqtSg/vqg0J7X4EKMp0HMT maVEk/OBSSSvJN7Q1NDcwtLQ3Njc2MxCSZz3vEFllJBAemJJanZqakFqEUwfEwenVAPj5Gg+ wVimM18eMZcccomd0fVp9/NS9d2BivPuiHWJcs3dvCkwaLWM/V6R2mc3apof/mXa1mKxx3at 9WIZjpa6/zVZpV0H2DWVd/8pXlhrH7jx5sfeU2ohe4yUPh6+Yr8ipqPlWM+Ni6HSLxPXhL89 seJwec6D25/C7h9SC5S8unzB01KxnZXpSizFGYmGWsxFxYkAtxsMP+oCAAA= Message-Id: <20181004144829eucas1p20df7fb6baf537a04c5b29ad090db7b66~abzgFItes0950109501eucas1p2C@eucas1p2.samsung.com> X-CMS-MailID: 20181004144829eucas1p20df7fb6baf537a04c5b29ad090db7b66 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181004081432epcas5p1905cb5fc4acfa5fca3c8dc93b596382c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181004081432epcas5p1905cb5fc4acfa5fca3c8dc93b596382c References: <20181004081403.8039-1-maxime.coquelin@redhat.com> <20181004081403.8039-4-maxime.coquelin@redhat.com> Subject: Re: [dpdk-dev] [PATCH v3 03/19] vhost: clarify reply-ack in case a reply was already sent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 14:48:30 -0000 On 04.10.2018 11:13, Maxime Coquelin wrote: > For messages that require a reply, a second ack should not be > sent when reply-ack protocol feature is negotiated, even if > the corresponding flag is set in the message. > > The code is compliant with the spec but it isn't clear it is, > so this patch adds a comment to make it explicit. > > Suggested-by: Ilya Maximets > Signed-off-by: Maxime Coquelin > --- Acked-by: Ilya Maximets