From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id CAE0D1B4EA for ; Thu, 4 Oct 2018 16:56:48 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181004145647euoutp016c63df2efe5e616b46acf3d3c9fcd207~ab6wjsLyU0930109301euoutp01J for ; Thu, 4 Oct 2018 14:56:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181004145647euoutp016c63df2efe5e616b46acf3d3c9fcd207~ab6wjsLyU0930109301euoutp01J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1538665007; bh=zeTZT3S+TCPtzMeh96ZFmp3ICEe/dwRSgQ6l9kiyKiw=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=fNNjCLn4YTTHwf2DLgsRkpsID3J3bZi3u+o0Xmp0vecltAEqOjSiA3PkaIXLIIrHD cJWUnN9iSf1jzi5gWc89PILbYHB1wbppuW9JgMlHLbIP4hvZe/e0sdW/nq6TE16Ur9 hZN5isgTqrD+q0AJ+C5jsUxsmSh8RmWyEFBTMEtA= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181004145647eucas1p2e50ad77bf614a9b492b38fca7744fffc~ab6wBOdK42748327483eucas1p2n; Thu, 4 Oct 2018 14:56:47 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id E0.93.04294.E2A26BB5; Thu, 4 Oct 2018 15:56:46 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181004145646eucas1p11bcd0adb05bc38ff89e19c60b5af0734~ab6vFE4Uy0940809408eucas1p15; Thu, 4 Oct 2018 14:56:46 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181004145645eusmtrp241c280bd64a6a03cbc1941c38f73cbc4~ab6u0IZhu2923429234eusmtrp29; Thu, 4 Oct 2018 14:56:45 +0000 (GMT) X-AuditID: cbfec7f4-835ff700000010c6-2e-5bb62a2e5abd Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 7A.B6.04128.D2A26BB5; Thu, 4 Oct 2018 15:56:45 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181004145645eusmtip2b71f023d0d1b2e738b3929055ba2837b~ab6uHxHH50097800978eusmtip2Q; Thu, 4 Oct 2018 14:56:45 +0000 (GMT) To: Maxime Coquelin , dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com Cc: dgilbert@redhat.com, stable@dpdk.org From: Ilya Maximets Date: Thu, 4 Oct 2018 17:59:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181004081403.8039-6-maxime.coquelin@redhat.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMKsWRmVeSWpSXmKPExsWy7djP87p6WtuiDT4sM7Q492kZk8WNVfYW 7z5tZ7Lo3XaP3eJK+092i3NrlrJYHOvcw2JxeuE1Fot/HX/YLbY2/Gey2HxxEpMDt8evBUtZ PXbOusvusXjPSyaP6d0PmT3e77vK5tG3ZRVjAFsUl01Kak5mWWqRvl0CV8au+z/ZC25wVWz7 cIClgfE4RxcjJ4eEgInE6u997F2MXBxCAisYJY50/WSGcL4wSiz9dpoJwvnMKHF561V2mJYt rT8YQWwhgeWMEifmyUIUfWSU+D9hF1iRsECoxIEV09hAEiICdxglriy9xAaSYBbQkFh/9QlY N5uAjsSp1UfAbBYBFYmGN7uZQWxRgQiJIw8WgsV5BQQlTs58wgJicwrYS9zpfQ01R1yi6ctK VghbXmL72zlgd0sI3GKXOHj3JFRzmUTrzDWsEGe7SJy885wZwhaWeHV8C9Q7MhL/d85ngrDr Je63vGSEGNTBKDH90D+ohL3EltfngBo4gLZpSqzfpQ9iSgg4SvSvdYIw+SRuvBWEOIdPYtK2 6cwQYV6JjjYhiBkqEr8PLoc6QEri5rvP7BMYlWYheXIWksdmIXlsFsLaBYwsqxjFU0uLc9NT i43yUsv1ihNzi0vz0vWS83M3MQKT1ul/x7/sYNz1J+kQowAHoxIP7wvlbdFCrIllxZW5hxgl OJiVRHhvawCFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8y6btzFaSCA9sSQ1OzW1ILUIJsvEwSnV wGhZ8+CZMMu9kGz2O7Lda1VXerJOi5uooGn68LuIbR/XRB+HrCtXs2yPcXPPOBdqKmXB4JfT kPs3J72peJp7utmtAgbWbtfmlsAww2P80V37jeyb5Sr5v0+w9RQ+uCrr9uOnlmIl//g/sJsw Pkx3/a6peSH1yRzNl0dFeO/JidV7ns2RcepQYinOSDTUYi4qTgQA15phdlYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t/xe7q6WtuiDX5sNrU492kZk8WNVfYW 7z5tZ7Lo3XaP3eJK+092i3NrlrJYHOvcw2JxeuE1Fot/HX/YLbY2/Gey2HxxEpMDt8evBUtZ PXbOusvusXjPSyaP6d0PmT3e77vK5tG3ZRVjAFuUnk1RfmlJqkJGfnGJrVK0oYWRnqGlhZ6R iaWeobF5rJWRqZK+nU1Kak5mWWqRvl2CXsau+z/ZC25wVWz7cIClgfE4RxcjJ4eEgInEltYf jF2MXBxCAksZJY69vMkIkZCS+PHrAiuELSzx51oXG0TRe0aJSzMus4EkhAVCJQ6smAaWEBG4 wyixZdYZsG5mAQ2J9VefQI09zihx6t1zJpAEm4COxKnVR4ASHBy8AnYSs/fogoRZBFQkGt7s ZgaxRQUiJFYvfwG2mVdAUOLkzCcsIDangL3End7XbBDz1SX+zLvEDGGLSzR9WckKYctLbH87 h3kCo9AsJO2zkLTMQtIyC0nLAkaWVYwiqaXFuem5xUZ6xYm5xaV56XrJ+bmbGIGRuu3Yzy07 GLveBR9iFOBgVOLhnaC4LVqINbGsuDL3EKMEB7OSCO9tDaAQb0piZVVqUX58UWlOavEhRlOg 5yYyS4km5wOTSF5JvKGpobmFpaG5sbmxmYWSOO95g8ooIYH0xJLU7NTUgtQimD4mDk6pBsbd HVtX5jpZNKg86tbKetT+X/WqKmOa+Nv+cu1fN4R6p/+qXXYxf4PHSx3Zf/yfbXJVFXfMZpqR /6T94Mypi6T6H+g47ZjrUWJ0rsAhyvj6FOso9Wv2DJyzXk5KW6croeX30+ToyofL/kneivwm I9z35HXpu+6vRi6R3WJ/985+U3do2dTT9x4rsRRnJBpqMRcVJwIA/m2doOoCAAA= Message-Id: <20181004145646eucas1p11bcd0adb05bc38ff89e19c60b5af0734~ab6vFE4Uy0940809408eucas1p15@eucas1p1.samsung.com> X-CMS-MailID: 20181004145646eucas1p11bcd0adb05bc38ff89e19c60b5af0734 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181004081447epcas2p25e5251e517f9f2a465106cb0681b16f7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181004081447epcas2p25e5251e517f9f2a465106cb0681b16f7 References: <20181004081403.8039-1-maxime.coquelin@redhat.com> <20181004081403.8039-6-maxime.coquelin@redhat.com> Subject: Re: [dpdk-dev] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 14:56:48 -0000 On 04.10.2018 11:13, Maxime Coquelin wrote: > When the memory table gets updated, the rings addresses need > to be translated again. If it fails, we need to exit cleanly > by unmapping memory regions. > > Fixes: d5022533c20a ("vhost: retranslate vring addr when memory table changes") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin > --- Acked-by: Ilya Maximets Minor comments inline. > lib/librte_vhost/vhost_user.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index 8ffe5aa66..b6eae8dc5 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -964,7 +964,8 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg) > > dev = translate_ring_addresses(dev, i); > if (!dev) > - return VH_RESULT_ERR; > + goto err_mmap; > + 1. No need to have two empty lines. (You could fix this while applying) 2. In current code, error on message handling will cause disconnect and memory regions will be freed anyway. So, the change is not very important for master (maybe just for consistency with surrounding code) but it could be important for stable versions. > > *pdev = dev; > } >