From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id E991F1B4FC for ; Thu, 4 Oct 2018 17:07:55 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181004150754euoutp0267f8eea35abae3c42101a4fa41f8389a~acEd6U8S52554325543euoutp023 for ; Thu, 4 Oct 2018 15:07:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181004150754euoutp0267f8eea35abae3c42101a4fa41f8389a~acEd6U8S52554325543euoutp023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1538665675; bh=hxLmkMRub6Nbry5D+RlNhY11TeGXZprmeypw66SNvWg=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=qZv30PPQSeQLO1HJ0uTATXRW9rlbI7x4uRmTjRkUWbPDfc1EXv2D1oXguJQZT9MYE 1HOXMr3VAfHltMgQWi0KE+hDjXhZ/dgA7Eo9DeDkUysBQryD9NLGs88REsL4Q5CKNj zkxqWh0vl7eHlJbavwRJqcjR/VKNJTGdIGimUnCQ= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181004150754eucas1p1b3ae9cba3770c6aa60ffac8995db3804~acEdfDLn32164421644eucas1p19; Thu, 4 Oct 2018 15:07:54 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id C3.35.04294.ACC26BB5; Thu, 4 Oct 2018 16:07:54 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181004150753eucas1p133ed4baaba8d86c54dc88a91a9407644~acEckwbDw2158121581eucas1p1z; Thu, 4 Oct 2018 15:07:53 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181004150753eusmtrp2e47e8fe6f97dbf3aaa238354704b7f2a~acEcUEacl3219732197eusmtrp2h; Thu, 4 Oct 2018 15:07:53 +0000 (GMT) X-AuditID: cbfec7f4-835ff700000010c6-01-5bb62cca8147 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 47.B9.04284.9CC26BB5; Thu, 4 Oct 2018 16:07:53 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181004150752eusmtip1e0917eb0a68302746bcf35411ba4693b~acEb46ZwW0711207112eusmtip1x; Thu, 4 Oct 2018 15:07:52 +0000 (GMT) To: Ferruh Yigit , dev@dpdk.org, Bruce Richardson Cc: Luca Boccassi From: Ilya Maximets Date: Thu, 4 Oct 2018 18:10:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6bbd22f9-fa94-677c-2ea8-e6290a843007@intel.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsWy7djPc7qndLZFG7xdxmUxp2kdu8WNVfYW 7z5tZ7K4s/c0u8WV9p/sDqwev9rmMnv8WrCU1WPxnpdMHn1bVjEGsERx2aSk5mSWpRbp2yVw ZeycG1SwWaiiYeJ31gbGX3xdjJwcEgImEuv+XGXsYuTiEBJYwShx9u07JgjnC6NE7+sprBDO Z0aJdx+3sMO0TJ52ACqxnFGi8VQjVP9HRomTa9pYQKqEBWIlbj3YwwhiiwhkSCxZux3MZhZQ kVgwbwobiM0moCNxavURsDgLUPz4zKesILaoQITEkQcLweK8AoISJ2c+AZvJKWArsfj1NyaI OeISTV9WskLY8hLb385hBjlCQmAyu8TKU7eZIJrLJH50bgBaxgGUcJFoP60F8YGwxKvjMN/I SPzfOZ8Jwq6XuN/ykhFiTgejxPRD/6AS9hJbXp9jB5nDLKApsX6XPkTYUaLj/Ht2iPF8Ejfe CkKcwycxadt0Zogwr0RHmxBEtYrE74PLmSFsKYmb7z6zT2BUmoXkyVlIHpuF5LFZCHsXMLKs YhRPLS3OTU8tNspLLdcrTswtLs1L10vOz93ECEwxp/8d/7KDcdefpEOMAhyMSjy8L5S3RQux JpYVV+YeYpTgYFYS4b2tARTiTUmsrEotyo8vKs1JLT7EKM3BoiTOu2zexmghgfTEktTs1NSC 1CKYLBMHp1QDo12QICvP7nn5xXx3n6l/3irFKLYv+tUPfpfUKz+sjsjdMn8xTzuKy8WKa9Fk 5cQnxw9ZFSzs8MpwmDVbMUF4+ivtPawM+jUCOimF/UV3zoUwmToGqyY9aAjv3J/ZfsVr/fuW 3j2dbdM3bHvkV5bGybrFJzqt7sJiVgc/922eoR9lZSwstW4psRRnJBpqMRcVJwIAQE/x0y0D AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t/xu7ondbZFG7xdw2Uxp2kdu8WNVfYW 7z5tZ7K4s/c0u8WV9p/sDqwev9rmMnv8WrCU1WPxnpdMHn1bVjEGsETp2RTll5akKmTkF5fY KkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk5mSWpRbp2yXoZeycG1SwWaiiYeJ31gbGX3xd jJwcEgImEpOnHWDtYuTiEBJYyihx4+AyRoiElMSPXxdYIWxhiT/Xutggit4zSsw4NpUZJCEs ECuxcfU7JhBbRCBDYuqeSSwgNrOAisSCeVOgGg4xSmxY9gcswSagI3Fq9RGwDbwCdhJnTvxi B7FZgBqOz3wKtk1UIEJi9fIXrBA1ghInZz4B6+UUsJVY/PobE8QCdYk/8y4xQ9jiEk1fVrJC 2PIS29/OYZ7AKDQLSfssJC2zkLTMQtKygJFlFaNIamlxbnpusaFecWJucWleul5yfu4mRmBc bTv2c/MOxksbgw8xCnAwKvHwvlDeFi3EmlhWXJkL9CAHs5II720NoBBvSmJlVWpRfnxRaU5q 8SFGU6DnJjJLiSbnA2M+ryTe0NTQ3MLS0NzY3NjMQkmc97xBZZSQQHpiSWp2ampBahFMHxMH p1QDY5Dfqrw2JpbvPYfF2kJm1767n67W837OjrDJHIm/JPOf/Ir1kFXUO/FQROqEzGTObwrR i58xrHBeomvnenbiR5/Gt8uMBJv0zdL/iy44fjC4xp39wFuBhdbXOFvuaUps1Lnj1Zh9aA4D 746nRfU72NMenGVbWrvCZqfqrYVhaoeFt3p4nWi5r8RSnJFoqMVcVJwIAMjFrfDBAgAA Message-Id: <20181004150753eucas1p133ed4baaba8d86c54dc88a91a9407644~acEckwbDw2158121581eucas1p1z@eucas1p1.samsung.com> X-CMS-MailID: 20181004150753eucas1p133ed4baaba8d86c54dc88a91a9407644 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181004131626eucas1p1161f9245280c8a4ca3a7d5b2f93b8ee2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181004131626eucas1p1161f9245280c8a4ca3a7d5b2f93b8ee2 References: <20181004131835.32734-1-i.maximets@samsung.com> <6bbd22f9-fa94-677c-2ea8-e6290a843007@intel.com> Subject: Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 15:07:56 -0000 On 04.10.2018 17:51, Ferruh Yigit wrote: > On 10/4/2018 2:18 PM, Ilya Maximets wrote: >> This functionality was missed while adding new drivers to >> the meson build. > > Is there any call from base code to experimental APIs? What do you think adding > this when we need it, since I have feeling that this may not be needed. The patch itself does not enable the experimental APIs, it only adds the ability to enable them in the future. It's actually pretty hard for the person that not much familiar with meson to find out why your code provides deprecation warnings. I spent few hours trying to make it work but failed. After that Bruce found that 'base' code parts ignores 'allow_experimental_apis' flag and prepared the patch. Thank you, Bruce! This patch possibly will save a few hours for someone like me, who will try to enable experimental APIs for avf and qede drivers. And I already need avf part for my patch set with nanosleep based delay: http://patches.dpdk.org/cover/46088/ > >> >> Fixes: 1d75caf81474 ("net/avf: add meson support") >> Fixes: 30d3d0168301 ("net/qede: add in meson build") >> >> Signed-off-by: Ilya Maximets >> --- >> drivers/net/avf/base/meson.build | 3 +++ >> drivers/net/qede/base/meson.build | 3 +++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build >> index 90fd6b445..6f3d7192e 100644 >> --- a/drivers/net/avf/base/meson.build >> +++ b/drivers/net/avf/base/meson.build >> @@ -8,6 +8,9 @@ sources = [ >> >> error_cflags = ['-Wno-pointer-to-int-cast'] >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: error_cflags >> if cc.has_argument(flag) >> c_args += flag >> diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build >> index 59b41c895..71b89737d 100644 >> --- a/drivers/net/qede/base/meson.build >> +++ b/drivers/net/qede/base/meson.build >> @@ -45,6 +45,9 @@ error_cflags = [ >> '-Wno-pointer-bool-conversion', >> ] >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: error_cflags >> if cc.has_argument(flag) >> c_args += flag >> > > >