From: Bruce Richardson <bruce.richardson@intel.com>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede
Date: Thu, 4 Oct 2018 16:23:04 +0100 [thread overview]
Message-ID: <20181004152304.GB16212@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20181004150753eucas1p133ed4baaba8d86c54dc88a91a9407644~acEckwbDw2158121581eucas1p1z@eucas1p1.samsung.com>
On Thu, Oct 04, 2018 at 06:10:12PM +0300, Ilya Maximets wrote:
> On 04.10.2018 17:51, Ferruh Yigit wrote:
> > On 10/4/2018 2:18 PM, Ilya Maximets wrote:
> >> This functionality was missed while adding new drivers to
> >> the meson build.
> >
> > Is there any call from base code to experimental APIs? What do you think adding
> > this when we need it, since I have feeling that this may not be needed.
>
> The patch itself does not enable the experimental APIs, it only
> adds the ability to enable them in the future. It's actually
> pretty hard for the person that not much familiar with meson to
> find out why your code provides deprecation warnings. I spent
> few hours trying to make it work but failed. After that Bruce found
> that 'base' code parts ignores 'allow_experimental_apis' flag and
> prepared the patch. Thank you, Bruce!
> This patch possibly will save a few hours for someone like me, who
> will try to enable experimental APIs for avf and qede drivers.
>
> And I already need avf part for my patch set with nanosleep
> based delay:
> http://patches.dpdk.org/cover/46088/
>
+1, I think it should be added, as it basically just is allowing
passthrough of the flag to the base drivers.
/Bruce
next prev parent reply other threads:[~2018-10-04 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181004131626eucas1p1161f9245280c8a4ca3a7d5b2f93b8ee2@eucas1p1.samsung.com>
2018-10-04 13:18 ` Ilya Maximets
2018-10-04 13:37 ` Bruce Richardson
2018-10-26 13:56 ` Ferruh Yigit
2018-10-04 14:51 ` Ferruh Yigit
2018-10-04 15:10 ` Ilya Maximets
2018-10-04 15:23 ` Bruce Richardson [this message]
2018-10-25 13:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004152304.GB16212@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=i.maximets@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).