From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CC96F1B51F for ; Thu, 4 Oct 2018 17:23:08 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 08:23:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,340,1534834800"; d="scan'208";a="76202374" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga008.fm.intel.com with SMTP; 04 Oct 2018 08:23:05 -0700 Received: by (sSMTP sendmail emulation); Thu, 04 Oct 2018 16:23:04 +0100 Date: Thu, 4 Oct 2018 16:23:04 +0100 From: Bruce Richardson To: Ilya Maximets Cc: Ferruh Yigit , dev@dpdk.org, Luca Boccassi Message-ID: <20181004152304.GB16212@bricha3-MOBL.ger.corp.intel.com> References: <20181004131835.32734-1-i.maximets@samsung.com> <6bbd22f9-fa94-677c-2ea8-e6290a843007@intel.com> <20181004150753eucas1p133ed4baaba8d86c54dc88a91a9407644~acEckwbDw2158121581eucas1p1z@eucas1p1.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181004150753eucas1p133ed4baaba8d86c54dc88a91a9407644~acEckwbDw2158121581eucas1p1z@eucas1p1.samsung.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 15:23:09 -0000 On Thu, Oct 04, 2018 at 06:10:12PM +0300, Ilya Maximets wrote: > On 04.10.2018 17:51, Ferruh Yigit wrote: > > On 10/4/2018 2:18 PM, Ilya Maximets wrote: > >> This functionality was missed while adding new drivers to > >> the meson build. > > > > Is there any call from base code to experimental APIs? What do you think adding > > this when we need it, since I have feeling that this may not be needed. > > The patch itself does not enable the experimental APIs, it only > adds the ability to enable them in the future. It's actually > pretty hard for the person that not much familiar with meson to > find out why your code provides deprecation warnings. I spent > few hours trying to make it work but failed. After that Bruce found > that 'base' code parts ignores 'allow_experimental_apis' flag and > prepared the patch. Thank you, Bruce! > This patch possibly will save a few hours for someone like me, who > will try to enable experimental APIs for avf and qede drivers. > > And I already need avf part for my patch set with nanosleep > based delay: > http://patches.dpdk.org/cover/46088/ > +1, I think it should be added, as it basically just is allowing passthrough of the flag to the base drivers. /Bruce