DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
Date: Fri, 5 Oct 2018 07:06:15 +0000	[thread overview]
Message-ID: <20181005070605.GA6990@jerin> (raw)
In-Reply-To: <8c49c8fe-db03-8d2c-bce0-eb6998544f30@solarflare.com>

-----Original Message-----
> Date: Fri, 5 Oct 2018 09:44:43 +0300
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, John McNamara
>  <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>
> CC: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com,
>  olivier.matz@6wind.com, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
>  Thunderbird/60.0
> 
> External Email
> 
> On 10/5/18 7:46 AM, Jerin Jacob wrote:
> 
> Based on PKT_TX_IP_CKSUM definition the user needs
> to fill l2_len and l3_len mbuf fields before issuing
> HW Tx checksum request.
> 
> Fixes: dad1ec72a377 ("doc: document NIC features")
> Cc: stable@dpdk.org<mailto:stable@dpdk.org>
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com><mailto:jerin.jacob@caviumnetworks.com>
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com><mailto:arybchenko@solarflare.com>
> 
> plus one question below
> 
> 
> ---
> 
> See PKT_TX_IP_CKSUM at
> https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283
> 
> ---
> doc/guides/nics/features.rst | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index b085bda86..e726a6bb8 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -562,6 +562,7 @@ Supports L3 checksum offload.
> * **[uses]     rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``.
> * **[uses]     mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``,
>   ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``.
> 
> Shouldn't PKT_TX_IPV6 be removed above since L3 checksum offload is not applicable for IPv6?

I think, some HW(What I am aware of) need to provide following[1] info in Tx
descriptors for checksum. IPV6 may be used by the HW in case, packet is
tunneled to see where inner start etc(thought it has outer_l3_len)(not strictly from outer checksum
perspective)

[1]
- IPV4
- IPV4 with csum
- IPV6


> 
> 
> 
> +* **[uses]     mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
> * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` |
>   ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` |
>   ``PKT_RX_IP_CKSUM_NONE``.
> 
> 

  reply	other threads:[~2018-10-05  7:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  4:46 Jerin Jacob
2018-10-05  4:46 ` [dpdk-dev] [PATCH 2/2] doc: clarify L4 " Jerin Jacob
2018-10-05  6:45   ` Andrew Rybchenko
2018-10-05  6:44 ` [dpdk-dev] [PATCH 1/2] doc: clarify L3 " Andrew Rybchenko
2018-10-05  7:06   ` Jerin Jacob [this message]
2018-10-09 10:19   ` Ferruh Yigit
2018-10-05 19:56 ` Ferruh Yigit
2018-10-06  8:05   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181005070605.GA6990@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).