From: Ilya Maximets <i.maximets@samsung.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
jfreimann@redhat.com, nicknickolaev@gmail.com,
bruce.richardson@intel.com, alejandro.lucero@netronome.com
Cc: dgilbert@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 12/19] vhost: add support for postcopy's listen message
Date: Fri, 5 Oct 2018 15:02:42 +0300 [thread overview]
Message-ID: <20181005120024eucas1p16e3484dd8d92c422f99ba1774b338ca1~atKCBaG2Y0203402034eucas1p1d@eucas1p1.samsung.com> (raw)
In-Reply-To: <20181004081403.8039-13-maxime.coquelin@redhat.com>
Same here. 'postcopy_listening' should be cleared on backend cleanup.
One minor comment inline.
Best regards, Ilya Maximets.
On 04.10.2018 11:13, Maxime Coquelin wrote:
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> lib/librte_vhost/vhost.h | 1 +
> lib/librte_vhost/vhost_user.c | 19 +++++++++++++++++++
> lib/librte_vhost/vhost_user.h | 3 ++-
> 3 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 21722d8a8..9453cb28d 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -364,6 +364,7 @@ struct virtio_net {
> rte_spinlock_t slave_req_lock;
>
> int postcopy_ufd;
> + int postcopy_listening;
>
> /*
> * Device id to identify a specific backend device.
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index 3d4fc60fc..ffb3ea60a 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -76,6 +76,7 @@ static const char *vhost_message_str[VHOST_USER_MAX] = {
> [VHOST_USER_CRYPTO_CREATE_SESS] = "VHOST_USER_CRYPTO_CREATE_SESS",
> [VHOST_USER_CRYPTO_CLOSE_SESS] = "VHOST_USER_CRYPTO_CLOSE_SESS",
> [VHOST_USER_POSTCOPY_ADVISE] = "VHOST_USER_POSTCOPY_ADVISE",
> + [VHOST_USER_POSTCOPY_LISTEN] = "VHOST_USER_POSTCOPY_LISTEN",
> };
>
> /* The possible results of a message handling function */
> @@ -1552,6 +1553,23 @@ vhost_user_set_postcopy_advise(struct virtio_net **pdev,
> #endif
> }
>
> +static int
> +vhost_user_set_postcopy_listen(struct virtio_net **pdev,
> + struct VhostUserMsg *msg __rte_unused,
> + int main_fd __rte_unused)
> +{
> + struct virtio_net *dev = *pdev;
> +
> + if (dev->mem && dev->mem->nregions) {
> + RTE_LOG(ERR, VHOST_CONFIG,
> + "Regions already registered at postcopy-listen\n");
> + return VH_RESULT_ERR;
> + }
> + dev->postcopy_listening = 1;
> +
> + return VH_RESULT_OK;
> +}
> +
> typedef int (*vhost_message_handler_t)(struct virtio_net **pdev,
> struct VhostUserMsg *msg,
> int main_fd);
> @@ -1580,6 +1598,7 @@ static vhost_message_handler_t vhost_message_handlers[VHOST_USER_MAX] = {
> [VHOST_USER_SET_SLAVE_REQ_FD] = vhost_user_set_req_fd,
> [VHOST_USER_IOTLB_MSG] = vhost_user_iotlb_msg,
> [VHOST_USER_POSTCOPY_ADVISE] = vhost_user_set_postcopy_advise,
> + [VHOST_USER_POSTCOPY_LISTEN] = vhost_user_set_postcopy_listen,
> };
>
>
> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
> index 2030b40a5..298279b91 100644
> --- a/lib/librte_vhost/vhost_user.h
> +++ b/lib/librte_vhost/vhost_user.h
> @@ -51,7 +51,8 @@ typedef enum VhostUserRequest {
> VHOST_USER_CRYPTO_CREATE_SESS = 26,
> VHOST_USER_CRYPTO_CLOSE_SESS = 27,
> VHOST_USER_POSTCOPY_ADVISE = 28,
> - VHOST_USER_MAX = 29
> + VHOST_USER_POSTCOPY_LISTEN = 29,
> + VHOST_USER_MAX = 31
You didn't change the MAX value after moving the END request to another patch.
Not sure if this is important, but I'd like to keep it correct here.
> } VhostUserRequest;
>
> typedef enum VhostUserSlaveRequest {
>
next prev parent reply other threads:[~2018-10-05 12:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 8:13 [dpdk-dev] [PATCH v3 00/19] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 01/19] vhost: fix messages error checks Maxime Coquelin
2018-10-04 14:48 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 02/19] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-04 14:48 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 03/19] vhost: clarify reply-ack in case a reply was already sent Maxime Coquelin
2018-10-04 14:50 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 04/19] vhost: fix payload size of reply Maxime Coquelin
2018-10-04 14:49 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-04 14:59 ` Ilya Maximets
2018-10-04 15:06 ` Maxime Coquelin
2018-10-04 15:11 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 06/19] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-04 14:59 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 07/19] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-05 9:56 ` Ilya Maximets
2018-10-08 12:56 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 08/19] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 09/19] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 10/19] vhost: add config flag for postcopy feature Maxime Coquelin
2018-10-05 11:55 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 11/19] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-05 11:58 ` Ilya Maximets
2018-10-05 13:36 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 12/19] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-05 12:02 ` Ilya Maximets [this message]
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 13/19] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-05 12:34 ` Ilya Maximets
2018-10-08 13:03 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 14/19] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-05 12:37 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-dev] [PATCH v3 15/19] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-04 8:14 ` [dpdk-dev] [PATCH v3 16/19] vhost: add support to postcopy's end request Maxime Coquelin
2018-10-04 8:14 ` [dpdk-dev] [PATCH v3 17/19] vhost: enable postcopy protocol feature Maxime Coquelin
2018-10-04 8:14 ` [dpdk-dev] [PATCH v3 18/19] vhost: add flag to enable postcopy live-migration Maxime Coquelin
2018-10-05 14:24 ` Ilya Maximets
2018-10-08 16:25 ` Ilya Maximets
2018-10-08 16:54 ` Maxime Coquelin
2018-10-04 8:14 ` [dpdk-dev] [PATCH v3 19/19] net/vhost: add parameter to enable postcopy support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20181005120024eucas1p16e3484dd8d92c422f99ba1774b338ca1~atKCBaG2Y0203402034eucas1p1d@eucas1p1.samsung.com' \
--to=i.maximets@samsung.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dgilbert@redhat.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).