From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com,
olivier.matz@6wind.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
Date: Sat, 6 Oct 2018 13:35:26 +0530 [thread overview]
Message-ID: <20181006080524.GA21149@jerin> (raw)
In-Reply-To: <d3d809fa-2f29-74bc-fbb7-9f0bfbe9bfb3@intel.com>
-----Original Message-----
> Date: Fri, 5 Oct 2018 20:56:47 +0100
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, John McNamara
> <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>
> CC: dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com,
> olivier.matz@6wind.com, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
> Thunderbird/52.9.1
>
> External Email
>
> On 10/5/2018 5:46 AM, Jerin Jacob wrote:
> > Based on PKT_TX_IP_CKSUM definition the user needs
> > to fill l2_len and l3_len mbuf fields before issuing
> > HW Tx checksum request.
> >
> > Fixes: dad1ec72a377 ("doc: document NIC features")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >
> > See PKT_TX_IP_CKSUM at
> > https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283
> >
> > ---
> > doc/guides/nics/features.rst | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> > index b085bda86..e726a6bb8 100644
> > --- a/doc/guides/nics/features.rst
> > +++ b/doc/guides/nics/features.rst
> > @@ -562,6 +562,7 @@ Supports L3 checksum offload.
> > * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``.
> > * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``,
> > ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``.
> > +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
>
> Thanks this was missing.
>
> ``mbuf.l2_len``, ``mbuf.l3_len`` are required for TX CKSUM offload, in
> documentation there is no distinction for Rx or Tx, do you think does it worth
> to clarify PMD `uses` these values for Tx cksum offload only?
IMO, there will not be any confusion as mbuf.l2_len comes under
uint64_t tx_offload in struct rte_mbuf.
>
>
> > * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` |
> > ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` |
> > ``PKT_RX_IP_CKSUM_NONE``.
> >
>
prev parent reply other threads:[~2018-10-06 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 4:46 Jerin Jacob
2018-10-05 4:46 ` [dpdk-dev] [PATCH 2/2] doc: clarify L4 " Jerin Jacob
2018-10-05 6:45 ` Andrew Rybchenko
2018-10-05 6:44 ` [dpdk-dev] [PATCH 1/2] doc: clarify L3 " Andrew Rybchenko
2018-10-05 7:06 ` Jerin Jacob
2018-10-09 10:19 ` Ferruh Yigit
2018-10-05 19:56 ` Ferruh Yigit
2018-10-06 8:05 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006080524.GA21149@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).