From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0055.outbound.protection.outlook.com [104.47.32.55]) by dpdk.org (Postfix) with ESMTP id 3446D152A; Sat, 6 Oct 2018 10:05:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DEuyB2HhjoQFGHM1lkwSlUu+W3YQeGQDe28uegWchKI=; b=l+I9VKBnVeZTj4FXAUHCFgEO6UnAzRezTH1VPkdISyMlrDko5qa+yb9mBzdZR68rwaiFewbS8AZ9oUv5u18NajT0AP0cLY8zndHZ/BWWIwqthuCIL5rTB91tj6YuITLz4CkKE/VczyNeNwxWx+ZPqTciw8EK7iE0NHOXgyKzzIA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by BL0PR07MB4993.namprd07.prod.outlook.com (2603:10b6:208:49::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Sat, 6 Oct 2018 08:05:42 +0000 Date: Sat, 6 Oct 2018 13:35:26 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: John McNamara , Marko Kovacevic , dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com, olivier.matz@6wind.com, stable@dpdk.org Message-ID: <20181006080524.GA21149@jerin> References: <20181005044606.27026-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR01CA0111.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::27) To BL0PR07MB4993.namprd07.prod.outlook.com (2603:10b6:208:49::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 784148e8-67a4-4038-7866-08d62b6284c6 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4993; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4993; 3:LLJe2v5vNcudCutOeBb1hpzNJ4SiBNNFmHy72m9n9gnVwzVcLAzcy/OrTqq500WSaqiK4iZfVl0coyoVmmvAaiUWMJP7DK1O2pLeNODbg0XcRM1+eQ9L0J/ai0GFbYHGAc52FzSzleVtjmYzRvyBii0+84ez4LWeU9KaYHoV8RyeyusCucgE/aPZcgZsmJJitmFxLm1uy9rrziml5y01yba04cmD4uYLvkjR9JUP8PnbHp+6NAtkZxYkN0YqH2/S; 25:zdP2AYvWJKjMIQ/Sglh0gTehD0ddFah4pGMnP+oy81Sz28L3xPYhEkCvjNNqf8I6XAHdGKpSSH11LZstEtWrMCServetn8JsMgtnXjbBHXa6+lOQxyICIGHOT6UVelHhNkqmznadUekwM3rXFiBNTlkd4COzU/yQ0YrOt86SsKt0gVg+purAY7CxRXclP+6rRSWiiaih8CIahUCgTLiWxlv1rU9Cv6gvhQj70xMkZLVoLNWZXjwg0pbfp0roOtVjaRftfFhdv0aRn1r7G3YQmokFYwY75xJs5zwXUD+AX2czNoYzTL5XOd7A82panFESKUMqXFHhsvB5NvgX+C+vxA==; 31:FGtQGS6cXA9uBnLkS4vsmSgo0tf8QwSj7OiPYyjwOp1PAZhvky+7xvnnJibah1J+SHpVHxuimSB3WDQZO4eS5fRu9szCznv7lgNYeyTtNG8LwcRvZGfKbU8sqWoZrOcGLWF+DfbpxdIq5nTrb+HZ/ZGOfCYl/TWcTo/HXWOjoc5Rw2VRzVuYuENu6j9eeFBnsuowWiaLs+UJ4U0rpIYim2t2yfnniqjvFhVOsiuvMLo= X-MS-TrafficTypeDiagnostic: BL0PR07MB4993: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4993; 20:TMlu52FW9hZ/XS1XCSCTYKKEzqqSCLb+2m1ZVWOkqXsyFQIrTvlp7D/tthvuNpbA/DkSF3EEMv+99+DFpC6vNTWzdZF3YrA1aYQO+jGTYTVmZ0NS7ItcyT1qcl+Ynj1xVOuuHUZLygiL7D5U+jRHm23V2WUOTVULBEVMATk7MIfm4eunr1NmV+s6Lxk68hVDWaYPM7NhXgCqwgYiyWfv7px6HuxHgEwhCeXMY3Hk3eH65GhUMubZehuUa95JLrahAT3YdcHs2OdDzmQArjDb7IsE1eKg/bmmld+MTO+Vwl8GMupmoxK13I0v/kFNbdqPOzzbDOeKv0eBmd+NelAOsxeRCssqUPPLNiSS1Dhly+Ur7QP5WlUJk3T7OtwIRHIlmadkuvD5O6ZnxaT77j7Ky0bmmQld0dnE1tH/7ZfjyOb1XEdnOVz2v9GujhQdUbLsdAQf+7grMcvLszKIFC+eFoFeJ7Cf9h+/MfL+PAnE7zxiaKPm93F5xXf955P7dBlk9kL4F1OpUVgctAo2j0gpH1rKZYgZPBT9cLPify/FMFF7aky2NXe9lalMnAdoX1FijZL7EmffzbtCOlwrrmRuF+Y6Ek/ucj1HLabxyg9R59E=; 4:l1gQ/EdNQEQJNTBW/DoyM0GFrqchWd3Knv9JqTq3gNwidODuZwmjKb1q/uryyljUzbIOTJKHZc0PbQdU0Fj+bE20RfEmQawGqX9aC4hTQdfH+NqAUftHMi5+FL241vNytTtJGcZl0LI0KvIt8hn8rFYCMKVrxi9hwjKj6jCUpKmv7rSKWavXZvE03YLA0Z2RVDOGibUL6iopVAhikI0z9bViSNC7c84sGNGl9IHo977UtOOfqBlwi6oRs9Ldi3abFEXfpbgTuYAOvuICiUvvqEUKsQpJmSqef08PzCrcjKJg/Ro4UxESx65KJhVJyxZw X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231355)(944501410)(52105095)(3002001)(93006095)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:BL0PR07MB4993; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4993; X-Forefront-PRVS: 0817737FD1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(396003)(39850400004)(346002)(376002)(366004)(189003)(199004)(13464003)(7736002)(186003)(33716001)(305945005)(229853002)(81156014)(5660300001)(8936002)(72206003)(1076002)(50466002)(8676002)(4326008)(6916009)(68736007)(33656002)(478600001)(3846002)(25786009)(81166006)(55236004)(23726003)(6306002)(966005)(53936002)(26005)(6666003)(9686003)(55016002)(6116002)(16526019)(6496006)(76176011)(97736004)(53546011)(386003)(52116002)(33896004)(2906002)(316002)(47776003)(44832011)(14444005)(956004)(11346002)(446003)(486006)(106356001)(66066001)(105586002)(54906003)(476003)(58126008)(16586007)(42882007)(6246003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4993; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4993; 23:7H/4yQqZ4OzcLVoItNbtLceP2YJWJOrx22BcGrD60?= =?us-ascii?Q?V7ez3JerSoabYMNIqbopx03Bm97pvlR516qOlV1lvEogmqH94gQgVnCxhdcc?= =?us-ascii?Q?yU1ibb37FnW7Tmvy5iCZoGx8cWejuuH4IwXR24hSjzc9t3tlnBejG+BaCwNj?= =?us-ascii?Q?+zENe9KX6KYtaEdZjXYs2BX5nltSx2XcqeUALklVkIPdjKtvZbPhj5XPgcbk?= =?us-ascii?Q?D6mzChrtq6tnH0Xm8FcNS1e9bh0MFsKfh3OnrL6Z9VM3j64lIC1hPNkyIqWP?= =?us-ascii?Q?w76Nt6ZSQTSdC3WToKPYLANlTsEeXCHQHJolWi0SKyThauefwarLIgseZY9/?= =?us-ascii?Q?MAJdk3XKuMRLjq0tZeiQfRGO/EEC3BJtIL5hqRbxMltJ+vK0cbUzBpazZJYJ?= =?us-ascii?Q?fZlCp3IgcjJsg9h2XCs1RtPnmhtVAP6Iqh9HsBoS8npTYaOvX3xcTPVWPbUG?= =?us-ascii?Q?vHAw+HSSINVLDDH3IB9DIc7O2zuEPYVqFrnvgNvAYx4P4PbZSb8JCuGY7Lr6?= =?us-ascii?Q?yUcb8LaD+N+ygOzztbbfyQ5G7B68aHK/+KStsw+DFof4v069G7WuD4zmpuJ7?= =?us-ascii?Q?hPzocBQZdEL61YORAJO/OpfezUEbBxn9wyob+KgdcTE/Ey6GSpeLJ1c7JJHJ?= =?us-ascii?Q?VYSWHL2AgUKspgmF3G3CUc5I3L0QLPsRbyZs/sf2GXJghCcXzjQ0aiSmWEPI?= =?us-ascii?Q?CJRmd4u7ce8EpBYLmkfNY6xBMOtA6S2sFAFHIvHeGTZZbVQL6FbcxSlUHyij?= =?us-ascii?Q?ecrVytHMuUlOeIthvg1jk0ypJGAY0A3wngINjqy7xcmUJWLDBJ1fgphOcAhH?= =?us-ascii?Q?lU+dYU/rCke+rxAj2erQ8glzkG0Y1VemxZxMRvMoJL2FVQzMMoP7B9VfQcW2?= =?us-ascii?Q?/dDX2lVkvyAdTVCTytzhmcnnp5hfLWWa8+J+Kdl6EzHUtTtm0INYBCBxYlCM?= =?us-ascii?Q?JTT2crqDBZuCEV7LbszkwvklN2xhRYFTn8mUjTGqaR9nubAn08c8IOxcKNCb?= =?us-ascii?Q?de1pJ0lVaw7wCRHywjQdn6aKIsF51RrqHzGmKoVXoVqacsg5nBVrggSxhMfC?= =?us-ascii?Q?0FBTeNdcnLQQ02WC4bpFcQRI1fZSWss2LbSyHzNYMHMw/0/PS0TB9GXvbUdW?= =?us-ascii?Q?38tTo+I839W8SDa0//x1hQ76MoylGOljsfdWymnjORmdlCVN1xFlTNTBQP/v?= =?us-ascii?Q?i90e3VnEu3mUhBIpYh/ko8pD2LnbNSBKLCuSL4uraBfbqCWw4M6V+IwjlFmX?= =?us-ascii?Q?QSvIR9L6Fcvtqb17jwI2zDnwZg4dUqkb0TigIHhdQVKoVKcuBtVadzSQBAh9?= =?us-ascii?Q?pYI3Dv4rQOkVxtbMMsyUJ+Ee/1oelJBwifv3wHwKnlevatjPS8v30/xjaPzU?= =?us-ascii?Q?klBX9CeBy8x8erhA3aqGTAEReU/keXBdfzYuFEtSlefnA+sMnt/UOQh5Zxim?= =?us-ascii?Q?VKPeXd1/R/HVDeqg8k3Kxrz7ujjqB4=3D?= X-Microsoft-Antispam-Message-Info: mnVKU/pXXF+Jz741pM8UQ2r9dJ4cdYWkdnAyct5qNeTJxN56a2BgTfp2CsnPuLyecNGT7Y4fhkUKUhUMBl+3LB/t5o1XjIkFV+CiQSpfjmyrTLcids2Yw8gr4zOtaKjEFPs2sYDFVxOH7OsDP7Xta2XnEG8ecjSZzqFS1+6QUQ1dNwMI3RVKlbx7JEyquXPioLkvtPVQg/h38iHr5hRxdv6eU6xHKTW0RB9JuBZQOfVLx50lmHYSjq7t+zaXAs1b46sX9Oxi95fneJZbK6BgHD3aHM74sc9inATeQN529Jyy9K5fl0UVcEgvPGGMDHAfC9CjgwbDzMznzX0cQzT7Tl3wvaSPfoIs2rnNsz7Whtk= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4993; 6:lhn6ipGGg0TkH9wolN2hyedZbndLB7gnXXo6re+Siw1Cn49ECfLvKhGLSDqQOHs+mb633qZnsYMKtRInjdPBM2A3G/MDcpacCcMFGBQdPCUGnS9KS1zkbFLLv13KBcoxLjKmxadM/wYAnXStDQkiLulp6jMRHto+s2fUZtSd/+ZL4r4yNLtsnOJqFU7QL6DETG2rDlXK09D8EK1R3/adok3+f5H5B56OCsEJoeH41BSxatwD0a+CUnWIIkDgEirllSKEomod01nU/nGlLpInJGcDVt8cHhVptmHAkE1LeP2JpamL0WdoP66PI4EfzvCBR5LTQa3v8wWOXeZ3mB3foh0O/ODyhbtI32HFtg0u6BgMS9uuU3rQPA+p1enhrjuBGPkZUo4A/fqCHVggX+fvqmW4wicrUIztHiehv3r2+nP56ylvK/YP70daOYFfZ4bTM8lmQ087YhhwpTa6pbmC7A==; 5:5yi0r1fny1mo3pqH2JMzcKfL0ng6ioMm76m7SijNokIKkYTd67vUluC+dw6ra6Brs7K2QKLPQcVacufyI0aAgQsaJIo4wFv74+eazCkb5ftlzo4T++cQYYCjVXRbgSVj148sS6AD9jTh2D9TJ6F6BwgSjXxRC7SDDEH3rtFZPUU=; 7:va7S9VY1yHCt+NbG3ZCSit/um/oW9wcgRxKFqKoQI5gf0tdhh5SD161onswRAYsuH5vuPziYT4cYRaGOsU8SwRdbhiRF+qShxJWkv1H+s9qjyUUctAwl+XpHXdRT3lWz/l9KjPaQu/iujePCZmjJdjkBEjdNSAvax/PwGNnX177Og/zqLDC5nOj8jp4cSOnhLPPI+oNCSWrBE38hasAoX7u+0u+BGxKg3h3D4TNpHQs+AqyGoVx5nrwNC/j8fFuu SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2018 08:05:42.4210 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 784148e8-67a4-4038-7866-08d62b6284c6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4993 Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2018 08:05:49 -0000 -----Original Message----- > Date: Fri, 5 Oct 2018 20:56:47 +0100 > From: Ferruh Yigit > To: Jerin Jacob , John McNamara > , Marko Kovacevic > CC: dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com, > olivier.matz@6wind.com, stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > External Email > > On 10/5/2018 5:46 AM, Jerin Jacob wrote: > > Based on PKT_TX_IP_CKSUM definition the user needs > > to fill l2_len and l3_len mbuf fields before issuing > > HW Tx checksum request. > > > > Fixes: dad1ec72a377 ("doc: document NIC features") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jerin Jacob > > --- > > > > See PKT_TX_IP_CKSUM at > > https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283 > > > > --- > > doc/guides/nics/features.rst | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > > index b085bda86..e726a6bb8 100644 > > --- a/doc/guides/nics/features.rst > > +++ b/doc/guides/nics/features.rst > > @@ -562,6 +562,7 @@ Supports L3 checksum offload. > > * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``. > > * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``, > > ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``. > > +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``. > > Thanks this was missing. > > ``mbuf.l2_len``, ``mbuf.l3_len`` are required for TX CKSUM offload, in > documentation there is no distinction for Rx or Tx, do you think does it worth > to clarify PMD `uses` these values for Tx cksum offload only? IMO, there will not be any confusion as mbuf.l2_len comes under uint64_t tx_offload in struct rte_mbuf. > > > > * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` | > > ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` | > > ``PKT_RX_IP_CKSUM_NONE``. > > >