From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00061.outbound.protection.outlook.com [40.107.0.61]) by dpdk.org (Postfix) with ESMTP id 8D3E11B3F5 for ; Mon, 8 Oct 2018 20:02:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vpn/fWAYfkZy9C4+vozs47V9mDOpNN16T2QsZbCe6vM=; b=oCmHQSNIwN2LrAw6tcn71mfqpoOMNb5RZfUtiJdAaaVIkn0LWksQ4ufdIFSGksvXB+fPxgZvwlR0STeSGg8kT7jBQbTgUFAA+IsjHfyePGKTZvKUCNrjemX5jGgR51K3PYEuxG2kHumirDwZb0eBKFghmEglbeUOGQVungGDmLU= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4074.eurprd05.prod.outlook.com (52.134.72.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.22; Mon, 8 Oct 2018 18:02:10 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045%2]) with mapi id 15.20.1207.024; Mon, 8 Oct 2018 18:02:10 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" , Yongseok Koh , Ori Kam Thread-Topic: [PATCH 1/7] net/mlx5: fix wrong flow action macro usage Thread-Index: AQHUXzEIqAkNL04+1UqcScsq6jzJCA== Date: Mon, 8 Oct 2018 18:02:09 +0000 Message-ID: <20181008180150.39273-2-yskoh@mellanox.com> References: <20181008180150.39273-1-yskoh@mellanox.com> In-Reply-To: <20181008180150.39273-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR02CA0016.namprd02.prod.outlook.com (2603:10b6:a02:ee::29) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4074; 6:FhGmwVz9onK9jmY5f9OAi4QZGDJMbcI1/xY4CEu+zE8nAG2IQlNbgxEat6xxgL8MCEgfBtkehwPRjTm1KQFg4C6fmLf8e/wsT5R5xjdeDcZZLskDSGrNXqunwybADhhP+hiOYiOgcuZVbmoTjLpsc5IgYheKbSCv6iELfX/LSnzZ0/ixvKDcnEruk91qv1OxS8cKd3pbEjRFUHD84Xisbt16Gu8hIUle+0Rvxun5PcgnYo+qf5DjKdkdTBmZ+qFtybTfIIqus73RebyF5yC7zyuWmQNTdFLJuEi1Pr3xxIqbQhd7skesQRbgya9jTs6QtSFA/eglFJx5sjrgGsPLEyv/T78flC2OjMkAVzCA7GmuKzKfULyu7jDxlFoprXzFOJJJMth6XH5JI7kcSjWVflMjamlNTNwt5eK6ui7ucTE5sAvLLDP/6gqFSoUTz58pNibrsbXwLVFjfLqPYTPvIQ==; 5:nSZtaNLyrYfVi4tcXtC9GRMD4MQAkXxc94EqscQ7cFf10xN7PF76hEy25nm3PnMuKy5+OYxjFPW2TDYtQLJiAyj4MJlMHPu6o1lPqW0OV/IuTqMDIRQuHWFy46eJPkH51XggBVrRyOtUOOnVPtP1VcSj0yhBDGGSP7w1LdFlqqE=; 7:nEdLvW+IulvDsBiy9W91kU5RYp+an5bGbU4tzxUuHsBC+oSkcx4SZyRarRi0G1BUhnHR6PBwYuRjHj9vDZ33RhLFQ/P3UV4PMgP/0rU1SxpEqjbXNvqE110GjN2mxkzeLsDy7fNbnN11FL8ogkgCCixk0qzEfjmP9thHjiKTfYqjHSD7gXb2vNlODgIf015GVADa1iQ+nF4luRqX+S2LT74aWuQbo5OYvF9S1ovNhqdXSXr/35Pi23EpT1eQesyv x-ms-office365-filtering-correlation-id: fced7f61-e54e-4630-f4eb-08d62d482ab9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4074; x-ms-traffictypediagnostic: DB3PR0502MB4074: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:DB3PR0502MB4074; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4074; x-forefront-prvs: 081904387B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(396003)(136003)(366004)(199004)(189003)(37006003)(53936002)(54906003)(71190400001)(14454004)(4326008)(26005)(97736004)(86362001)(5660300001)(71200400001)(66066001)(6512007)(186003)(446003)(316002)(6436002)(478600001)(25786009)(102836004)(476003)(8936002)(11346002)(81156014)(106356001)(6862004)(7736002)(8676002)(305945005)(81166006)(6486002)(256004)(486006)(2900100001)(2616005)(36756003)(105586002)(1076002)(6116002)(386003)(5250100002)(2906002)(3846002)(76176011)(6506007)(52116002)(68736007)(6636002)(99286004)(107886003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4074; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: PrEzUs59VX1H5CyRpOPGn/Lsmzsq1WCdOZjZ7/t1QElWvoI5kPIo1NIn5SOwgIDzfv0c4ZQEmLifJ/EbSYenXa1zqfC1NhB0Pk5tfFEKOMCHl4BEHGeTrRviGeWQEAuWM/jfSftOtf0S7Ddv5TaRULK/I0V3FKkeCg0y9SplvayeAW9oufB4Caogyb3YNZ75NQ5TfIe196tABQEkihRDJ9b9XGXVrF8frfMwjSfu+qmkCtJnYps/iLh9OcB1OqHJyojkxhE1JELf8LbAetzC+zWZqNC7XjJsZwlOZYBQdy7cTHx8Omq8p8btZmZqbaB+4hBAAlGs7Ra7cNu6DiBBgiFrc0ndPKXtJpMtPdQn3F8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fced7f61-e54e-4630-f4eb-08d62d482ab9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2018 18:02:10.0181 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4074 Subject: [dpdk-dev] [PATCH 1/7] net/mlx5: fix wrong flow action macro usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 18:02:11 -0000 Fixes: 5c83c536783c ("net/mlx5: add Direct Verbs final functions") Cc: Ori Kam Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.h | 10 ---------- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index a91f9911d..79d4a2619 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -65,16 +65,6 @@ (MLX5_FLOW_LAYER_INNER_L2 | MLX5_FLOW_LAYER_INNER_L3 | \ MLX5_FLOW_LAYER_INNER_L4) =20 -/* Actions that modify the fate of matching traffic. */ -#define MLX5_FLOW_FATE_DROP (1u << 0) -#define MLX5_FLOW_FATE_QUEUE (1u << 1) -#define MLX5_FLOW_FATE_RSS (1u << 2) - -/* Modify a packet. */ -#define MLX5_FLOW_MOD_FLAG (1u << 0) -#define MLX5_FLOW_MOD_MARK (1u << 1) -#define MLX5_FLOW_MOD_COUNT (1u << 2) - /* Actions */ #define MLX5_ACTION_DROP (1u << 0) #define MLX5_ACTION_QUEUE (1u << 1) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_d= v.c index 7d325320a..5678dc35f 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -1251,7 +1251,7 @@ flow_dv_apply(struct rte_eth_dev *dev, struct rte_flo= w *flow, LIST_FOREACH(dev_flow, &flow->dev_flows, next) { struct mlx5_flow_dv *dv =3D &dev_flow->dv; if (dv->hrxq) { - if (flow->actions & MLX5_FLOW_FATE_DROP) + if (flow->actions & MLX5_ACTION_DROP) mlx5_hrxq_drop_release(dev); else mlx5_hrxq_release(dev, dv->hrxq); --=20 2.11.0