* [dpdk-dev] [PATCH] failsafe: use prefix for set_burst_fn
@ 2018-10-08 22:31 Stephen Hemminger
2018-10-09 7:45 ` Gaëtan Rivet
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2018-10-08 22:31 UTC (permalink / raw)
To: Gaetan Rivet; +Cc: dev, Stephen Hemminger
All other visible functions in failsafe driver have 'failsafe_'
prefix.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/failsafe/failsafe_ether.c | 2 +-
drivers/net/failsafe/failsafe_private.h | 4 ++--
drivers/net/failsafe/failsafe_rxtx.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c
index 51c96f78ba71..b0376c931c63 100644
--- a/drivers/net/failsafe/failsafe_ether.c
+++ b/drivers/net/failsafe/failsafe_ether.c
@@ -571,7 +571,7 @@ failsafe_eth_rmv_event_callback(uint16_t port_id __rte_unused,
/* Switch as soon as possible tx_dev. */
fs_switch_dev(sdev->fs_dev, sdev);
/* Use safe bursts in any case. */
- set_burst_fn(sdev->fs_dev, 1);
+ failsafe_set_burst_fn(sdev->fs_dev, 1);
/*
* Async removal, the sub-PMD will try to unregister
* the callback at the source of the current thread context.
diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h
index abbe73e872fa..7845c68fed16 100644
--- a/drivers/net/failsafe/failsafe_private.h
+++ b/drivers/net/failsafe/failsafe_private.h
@@ -190,7 +190,7 @@ int failsafe_hotplug_alarm_cancel(struct rte_eth_dev *dev);
/* RX / TX */
-void set_burst_fn(struct rte_eth_dev *dev, int force_safe);
+void failsafe_set_burst_fn(struct rte_eth_dev *dev, int force_safe);
uint16_t failsafe_rx_burst(void *rxq,
struct rte_mbuf **rx_pkts, uint16_t nb_pkts);
@@ -470,7 +470,7 @@ fs_switch_dev(struct rte_eth_dev *dev,
} else {
return;
}
- set_burst_fn(dev, 0);
+ failsafe_set_burst_fn(dev, 0);
rte_wmb();
}
diff --git a/drivers/net/failsafe/failsafe_rxtx.c b/drivers/net/failsafe/failsafe_rxtx.c
index 7bd0f963e5da..034f47b87f83 100644
--- a/drivers/net/failsafe/failsafe_rxtx.c
+++ b/drivers/net/failsafe/failsafe_rxtx.c
@@ -29,7 +29,7 @@ fs_tx_unsafe(struct sub_device *sdev)
}
void
-set_burst_fn(struct rte_eth_dev *dev, int force_safe)
+failsafe_set_burst_fn(struct rte_eth_dev *dev, int force_safe)
{
struct sub_device *sdev;
uint8_t i;
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] failsafe: use prefix for set_burst_fn
2018-10-08 22:31 [dpdk-dev] [PATCH] failsafe: use prefix for set_burst_fn Stephen Hemminger
@ 2018-10-09 7:45 ` Gaëtan Rivet
2018-10-09 15:03 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Gaëtan Rivet @ 2018-10-09 7:45 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On Mon, Oct 08, 2018 at 03:31:40PM -0700, Stephen Hemminger wrote:
> All other visible functions in failsafe driver have 'failsafe_'
> prefix.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> drivers/net/failsafe/failsafe_ether.c | 2 +-
> drivers/net/failsafe/failsafe_private.h | 4 ++--
> drivers/net/failsafe/failsafe_rxtx.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] failsafe: use prefix for set_burst_fn
2018-10-09 7:45 ` Gaëtan Rivet
@ 2018-10-09 15:03 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-10-09 15:03 UTC (permalink / raw)
To: Gaëtan Rivet, Stephen Hemminger; +Cc: dev
On 10/9/2018 8:45 AM, Gaëtan Rivet wrote:
> On Mon, Oct 08, 2018 at 03:31:40PM -0700, Stephen Hemminger wrote:
>> All other visible functions in failsafe driver have 'failsafe_'
>> prefix.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-09 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-08 22:31 [dpdk-dev] [PATCH] failsafe: use prefix for set_burst_fn Stephen Hemminger
2018-10-09 7:45 ` Gaëtan Rivet
2018-10-09 15:03 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).