From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 1909B4C96; Tue, 9 Oct 2018 10:06:42 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 01:06:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,359,1534834800"; d="scan'208";a="79670624" Received: from btwcube1.sh.intel.com (HELO debian) ([10.67.104.158]) by orsmga007.jf.intel.com with ESMTP; 09 Oct 2018 01:06:37 -0700 Date: Tue, 9 Oct 2018 16:05:22 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com, dgilbert@redhat.com, stable@dpdk.org Message-ID: <20181009080522.GA24789@debian> References: <20181008152557.14275-1-maxime.coquelin@redhat.com> <20181008152557.14275-3-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181008152557.14275-3-maxime.coquelin@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v4 02/19] vhost: fix return code of messages requiring replies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 08:06:43 -0000 On Mon, Oct 08, 2018 at 05:25:40PM +0200, Maxime Coquelin wrote: > VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE > and VHOST_USER_SET_LOG_BASE require replies, so their handlers > should return VH_RESULT_REPLY, not VH_RESULT_OK. > > Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature") > > Signed-off-by: Maxime Coquelin > Acked-by: Ilya Maximets > --- > lib/librte_vhost/vhost_user.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Tiwei Bie