From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 988135B38; Tue, 9 Oct 2018 10:13:35 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 01:13:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,359,1534834800"; d="scan'208";a="269702618" Received: from btwcube1.sh.intel.com (HELO debian) ([10.67.104.158]) by fmsmga005.fm.intel.com with ESMTP; 09 Oct 2018 01:13:32 -0700 Date: Tue, 9 Oct 2018 16:12:17 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com, dgilbert@redhat.com, stable@dpdk.org Message-ID: <20181009081217.GB24789@debian> References: <20181008152557.14275-1-maxime.coquelin@redhat.com> <20181008152557.14275-4-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181008152557.14275-4-maxime.coquelin@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v4 03/19] vhost: clarify reply-ack in case a reply was already sent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 08:13:36 -0000 On Mon, Oct 08, 2018 at 05:25:41PM +0200, Maxime Coquelin wrote: > For messages that require a reply, a second ack should not be > sent when reply-ack protocol feature is negotiated, even if > the corresponding flag is set in the message. > > The code is compliant with the spec but it isn't clear it is, > so this patch adds a comment to make it explicit. > > Suggested-by: Ilya Maximets > Signed-off-by: Maxime Coquelin > Acked-by: Ilya Maximets > --- > lib/librte_vhost/vhost_user.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Tiwei Bie