From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Ori Kam <orika@mellanox.com>,
Mordechay Haimovsky <motih@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
"orika@contextream.com" <orika@contextream.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] ethdev: fix flow API item/action name conversion
Date: Tue, 9 Oct 2018 15:54:06 +0200 [thread overview]
Message-ID: <20181009135406.GJ18937@6wind.com> (raw)
In-Reply-To: <1b66f1f8-8eda-19ce-b7ca-04cc3463f3ab@intel.com>
Hi,
Jumping in although I cannot spend much time on rte_flow at the moment,
please see below.
On Tue, Oct 09, 2018 at 02:21:23PM +0100, Ferruh Yigit wrote:
> On 10/7/2018 5:31 PM, Ori Kam wrote:
> >
> >
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Mordechay Haimovsky
> >> Sent: Sunday, October 7, 2018 7:22 PM
> >> To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Shahaf Shuler
> >> <shahafs@mellanox.com>; orika@contextream.com
> >> Cc: dev@dpdk.org; Mordechay Haimovsky <motih@mellanox.com>
> >> Subject: [dpdk-dev] [PATCH v1] ethdev: fix flow API item/action name
> >> conversion
> >>
> >> This patch fixes a typecast bug found in rte_flow_conv_name routine
> >> used in rte_flow item/action name conversion.
> >>
> >> Fixes: 0c2640cbfa7a ("ethdev: add flow API item/action name conversion")
> >>
> >> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> <...>
> > Acked-by: Ori Kam <orika@mellanox.com>
>
> Series applied to dpdk-next-net/master, thanks.
>
> (please confirm latest next-net head)
Please revert, it breaks something that didn't need to be fixed. I don't
think this patch was validated properly.
As documented in RTE_FLOW_CONV_OP_ITEM_NAME, RTE_FLOW_CONV_OP_ACTION_NAME,
RTE_FLOW_CONV_OP_ITEM_NAME_PTR and RTE_FLOW_CONV_OP_ACTION_NAME_PTR:
@p src type:
@code (const void *)enum rte_flow_item_type @endcode
With the following reminder in rte_flow_conv_name()'s Doxygen documentation:
@param[in] src
Depending on @p is_action, source pattern item or action type cast as a
pointer.
Hence the original conversion results in the expected behavior while this
one is almost guaranteed to trigger a segfault:
- unsigned int type = (uintptr_t)src;
+ unsigned int type = *(const unsigned int *)src;
This can be validated with testpmd. See what happens with "flow list".
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2018-10-09 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 15:38 [dpdk-dev] [PATCH] " Mordechay Haimovsky
2018-10-07 16:22 ` [dpdk-dev] [PATCH v1] " Mordechay Haimovsky
2018-10-07 16:31 ` Ori Kam
2018-10-09 13:21 ` Ferruh Yigit
2018-10-09 13:38 ` Ferruh Yigit
2018-10-09 13:54 ` Adrien Mazarguil [this message]
2018-10-11 10:14 ` Ferruh Yigit
2018-10-11 10:36 ` Mordechay Haimovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009135406.GJ18937@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=motih@mellanox.com \
--cc=orika@contextream.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).