DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com,
	ferruh.yigit@intel.com, arybchenko@solarflare.com,
	olivier.matz@6wind.com, remy.horton@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/4] mk: remove broken check
Date: Tue, 9 Oct 2018 14:11:20 -0400	[thread overview]
Message-ID: <20181009181120.GB17331@hmswarspite.think-freely.org> (raw)
In-Reply-To: <4229908.dRXGeFGLpr@xps>

On Tue, Oct 09, 2018 at 01:53:46PM +0200, Thomas Monjalon wrote:
> 09/10/2018 13:43, Neil Horman:
> > On Tue, Oct 09, 2018 at 04:18:56AM +0200, Thomas Monjalon wrote:
> > > Next patch does not pass the experimental check
> > > because it has an (unrelated) experimental function in his context.
> > > 
> > > Cc: Neil Horman <nhorman@tuxdriver.com>
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > >  mk/internal/rte.compile-pre.mk | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk
> > > index a734cbbd0..acb9796fa 100644
> > > --- a/mk/internal/rte.compile-pre.mk
> > > +++ b/mk/internal/rte.compile-pre.mk
> > > @@ -75,7 +75,6 @@ C_TO_O_DO = @set -e; \
> > >  	echo $(C_TO_O_DISP); \
> > >  	$(C_TO_O) && \
> > >  	$(PMDINFO_TO_O) && \
> > > -	$(CHECK_EXPERIMENTAL) && \
> > >  	echo $(C_TO_O_CMD) > $(call obj2cmd,$(@)) && \
> > >  	sed 's,'$@':,dep_'$@' =,' $(call obj2dep,$(@)).tmp > $(call obj2dep,$(@)) && \
> > >  	rm -f $(call obj2dep,$(@)).tmp
> > 
> > NACK.
> 
> Yes, of course.
> I have added this patch in the series in order to allow building the patches.
> 
> > Its a bit vague to get the meaning of your changelog, but based on the
> > context of the actual other patch I think what you're saying is that patch 3/4 in
> > this series has the __rte_experimental token in it as part of the context of a
> > diff, rather than as a change itself, and the check-experimental-syms script is
> > matching on that when it shouldn't.  The correct fix is to teach the difference
> > between changes and context to the check-experimental-syms.sh script, not to
> > break the whole thing by just removing the call to the script.
> 
> I agree, but I don't understand how the patch context is related
> to the checks done in buildtools.
> Please could you fix it? It is blocking the integration of this series.
> 
Yeah, I'll get to it as soon as possible, but please lead with this rather than
just dismantling the feature :)

Neil

> Thanks
> 
> 
> 

  reply	other threads:[~2018-10-09 18:12 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09  2:18 [dpdk-dev] [PATCH 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-09  2:18 ` [dpdk-dev] [PATCH 1/4] kvargs: support list value Thomas Monjalon
2018-10-09 14:14   ` Gaëtan Rivet
2018-10-09 14:31     ` Thomas Monjalon
2018-10-09 15:11       ` Stephen Hemminger
2018-10-09 17:11         ` Thomas Monjalon
2018-10-10 13:12         ` Remy Horton
2018-10-09  2:18 ` [dpdk-dev] [PATCH 2/4] mk: remove broken check Thomas Monjalon
2018-10-09 11:43   ` Neil Horman
2018-10-09 11:53     ` Thomas Monjalon
2018-10-09 18:11       ` Neil Horman [this message]
2018-10-09  2:18 ` [dpdk-dev] [PATCH 3/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-09  9:06   ` Andrew Rybchenko
2018-10-09 12:38   ` Remy Horton
2018-10-09 13:25     ` Thomas Monjalon
2018-10-09  2:18 ` [dpdk-dev] [PATCH 4/4] ethdev: support representor id for iterating ports Thomas Monjalon
2018-10-09  9:14   ` Andrew Rybchenko
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-10 19:23   ` [dpdk-dev] [PATCH v2 1/4] kvargs: support list value Thomas Monjalon
2018-10-10 19:23   ` [dpdk-dev] [PATCH v2 2/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-10 19:23   ` [dpdk-dev] [PATCH v2 3/4] ethdev: support representor id as iterator filter Thomas Monjalon
2018-10-10 19:23   ` [dpdk-dev] [PATCH v2 4/4] ethdev: support MAC address " Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-22 13:15   ` [dpdk-dev] [PATCH v3 1/4] kvargs: support list value Thomas Monjalon
2018-10-22 13:15   ` [dpdk-dev] [PATCH v3 2/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-22 13:15   ` [dpdk-dev] [PATCH v3 3/4] ethdev: support representor id as iterator filter Thomas Monjalon
2018-10-22 13:15   ` [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address " Thomas Monjalon
2018-10-22 13:37     ` Andrew Rybchenko
2018-10-22 14:02       ` Thomas Monjalon
2018-10-22 14:18         ` Andrew Rybchenko
2018-10-22 21:24         ` Ananyev, Konstantin
2018-10-23  7:20           ` Thomas Monjalon
2018-10-23  8:33             ` Ananyev, Konstantin
2018-10-23  8:53               ` Thomas Monjalon
2018-10-23 21:45                 ` Ananyev, Konstantin
2018-10-22 14:25     ` Andrew Rybchenko
2018-10-24  8:27   ` [dpdk-dev] [PATCH v3 0/4] support more ethdev iterator filters Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009181120.GB17331@hmswarspite.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaetan.rivet@6wind.com \
    --cc=olivier.matz@6wind.com \
    --cc=ophirmu@mellanox.com \
    --cc=remy.horton@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).