From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id A71D91B454 for ; Tue, 9 Oct 2018 20:12:13 +0200 (CEST) Received: from cpe-2606-a000-111b-40fe-f1c6-eb46-ccca-fca5.dyn6.twc.com ([2606:a000:111b:40fe:f1c6:eb46:ccca:fca5] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1g9wU6-0006U6-HD; Tue, 09 Oct 2018 14:12:08 -0400 Date: Tue, 9 Oct 2018 14:11:20 -0400 From: Neil Horman To: Thomas Monjalon Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, olivier.matz@6wind.com, remy.horton@intel.com Message-ID: <20181009181120.GB17331@hmswarspite.think-freely.org> References: <20181009021858.19216-1-thomas@monjalon.net> <20181009021858.19216-3-thomas@monjalon.net> <20181009114320.GA17331@hmswarspite.think-freely.org> <4229908.dRXGeFGLpr@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4229908.dRXGeFGLpr@xps> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 2/4] mk: remove broken check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 18:12:13 -0000 On Tue, Oct 09, 2018 at 01:53:46PM +0200, Thomas Monjalon wrote: > 09/10/2018 13:43, Neil Horman: > > On Tue, Oct 09, 2018 at 04:18:56AM +0200, Thomas Monjalon wrote: > > > Next patch does not pass the experimental check > > > because it has an (unrelated) experimental function in his context. > > > > > > Cc: Neil Horman > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > mk/internal/rte.compile-pre.mk | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk > > > index a734cbbd0..acb9796fa 100644 > > > --- a/mk/internal/rte.compile-pre.mk > > > +++ b/mk/internal/rte.compile-pre.mk > > > @@ -75,7 +75,6 @@ C_TO_O_DO = @set -e; \ > > > echo $(C_TO_O_DISP); \ > > > $(C_TO_O) && \ > > > $(PMDINFO_TO_O) && \ > > > - $(CHECK_EXPERIMENTAL) && \ > > > echo $(C_TO_O_CMD) > $(call obj2cmd,$(@)) && \ > > > sed 's,'$@':,dep_'$@' =,' $(call obj2dep,$(@)).tmp > $(call obj2dep,$(@)) && \ > > > rm -f $(call obj2dep,$(@)).tmp > > > > NACK. > > Yes, of course. > I have added this patch in the series in order to allow building the patches. > > > Its a bit vague to get the meaning of your changelog, but based on the > > context of the actual other patch I think what you're saying is that patch 3/4 in > > this series has the __rte_experimental token in it as part of the context of a > > diff, rather than as a change itself, and the check-experimental-syms script is > > matching on that when it shouldn't. The correct fix is to teach the difference > > between changes and context to the check-experimental-syms.sh script, not to > > break the whole thing by just removing the call to the script. > > I agree, but I don't understand how the patch context is related > to the checks done in buildtools. > Please could you fix it? It is blocking the integration of this series. > Yeah, I'll get to it as soon as possible, but please lead with this rather than just dismantling the feature :) Neil > Thanks > > >