Re: [dpdk-dev] [PATCH] ethdev: add action to swap source and destination MAC to flow API

[Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>]

On Tuesday, October 10/09/18, 2018 at 20:19:54 +0530, Ferruh Yigit wrote:
> On 9/24/2018 9:29 AM, Rahul Lakkireddy wrote:
> > This action is useful for offloading loopback mode, where the hardware
> > will swap source and destination MAC addresses in the outermost Ethernet
> > header before looping back the packet. This action can be used in
> > conjunction with other rewrite actions to achieve MAC layer transparent
> > NAT where the MAC addresses are swapped before either the source or
> > destination MAC address is rewritten and NAT is performed.
> > 
> > Must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item.
> > Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error should be returned by the
> > PMDs.
> > 
> > Original work by Shagun Agrawal
> 
> Do you consider adding his sign off too, that is more formal way we do?
> 
> If would like to update we can do it on the next-net before it get pulled.
> 

Shagun is no longer working for Chelsio. He had done the original
implementation and I've re-spun the series incorporating review
comments. I couldn't add his Signed-off-by without his permission on
the later revision series. Hence, the reason for "Original work by"
line above.

> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> 
> 

Thanks,
Rahul