From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80050.outbound.protection.outlook.com [40.107.8.50]) by dpdk.org (Postfix) with ESMTP id 3EAC11B45A for ; Wed, 10 Oct 2018 02:38:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uggOGTB/H8qEVCThjmtiAK9LQBvj8+Lvx0u+m9KfGzs=; b=ugZzAUOkL4VtJwdeG6oWhrfKhVB+WkNEFXhD82MrnKIA8qJ5Uo1LABV21JV7+Ay1kTh0nsajpoOVG5HEWAd2/+xV+gm59xuz0pFTrSV3KXS4awEtqOQA5MjOf9kdvT1jCkVjnkGgSD8pVJQU7dGc++XN6oMD5EGBsCJ6dTAozQ4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4076.eurprd05.prod.outlook.com (52.134.66.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.27; Wed, 10 Oct 2018 00:38:37 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045%2]) with mapi id 15.20.1207.029; Wed, 10 Oct 2018 00:38:37 +0000 From: Yongseok Koh To: Dekel Peled CC: Shahaf Shuler , "dev@dpdk.org" , Ori Kam Thread-Topic: [PATCH v3 1/4] net/mlx5: add flow action functions to glue Thread-Index: AQHUYAvkvSujwbHPZ0G2mkGWXpmBgKUXowiA Date: Wed, 10 Oct 2018 00:38:37 +0000 Message-ID: <20181010003828.GE9031@mtidpdk.mti.labs.mlnx> References: <1538922308-9516-1-git-send-email-dekelp@mellanox.com> <1539113137-4914-2-git-send-email-dekelp@mellanox.com> In-Reply-To: <1539113137-4914-2-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BN6PR11CA0019.namprd11.prod.outlook.com (2603:10b6:405:2::29) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4076; 6:O8yBvZ+QLIFAP/GlJXMyIYoxYBzO7KDMTTJwho1uDAIAkP9Qy3URTivUUK7IwZmMaX8omMtTfNI4tB2J4SgZ6Z7u1KVGiA4YClGOAaAQ0jxCr9LBuDVaA7YQl/OpeRL0ftwMUpTci2SSlrpZavHghKKujZ/vB/liIiUL58DLjIHZY5Dfnd9LxnPscRYlNQLg0ouELq7jMXnPMEBDYK1UgKRMGGLP/zrfgpcWkbSOhm6dwNz7L+aWno4cRdMCjNJ5/5jbdUlAGSKGcCwFV0y7/spFTw/AZx4wQVzy1BLZgO8V6qd+b1m5wOs1YTlel8yu803IarQztPbH39s6LD2yyCNhRv65gxoPqoGH4hKxGjXaDbX4+u58koqESo1Cluk6assPT4aO2zIoZp/w7lFQc2QwgrxHogBhJd6eQw6H5/Gt7n+nU1LcFRURFMpw+y3AcIjHJEksIb4/yT0rpP5fzw==; 5:sKJZ9pHHI53iwODnJZL4ybgbOSzv2rW8oA3BOS7uhre61jo0QIuoL9KH7NKh0GL0XxuAYSAnT/Fued42YBK3OWXImUri7FS7EzjZiv2/G/1Z7KK4/9qlWbxU8pT5nzDM5GWlnusqW+ez/tL+nG0AMUng5hdotkUNvhrgmkEKlMw=; 7:ugLVhjdqc6mJo3D/bh5TR7riyi47m2irxQ5oIpxryXaWZ/P7wW1gGMVfTizXMo9sM10ExASAXbPNF1EXg4RMoiGo46CxzCmKNk/tmqdfxdzTpfUE+y8wW4ZF1nwi+8Pp2xMuTJoRs0eI4T44O7djX0n44NEmnAKMGr1ed2MKjNiNKx4AMvpG/XPmWQH5NWjCiGCvvv2n0e8BXVQcNh9gLzPUbrJ7mMZCM4ulx3TjqG549I6WDl51xpkQqDOtQtjb x-ms-office365-filtering-correlation-id: e011f916-abde-463d-0c79-08d62e48b76b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4076; x-ms-traffictypediagnostic: DB3PR0502MB4076: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991055); SRVR:DB3PR0502MB4076; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4076; x-forefront-prvs: 08213D42D3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(396003)(136003)(346002)(376002)(189003)(199004)(54906003)(6636002)(186003)(53936002)(68736007)(86362001)(9686003)(6512007)(5660300001)(106356001)(99286004)(66066001)(8936002)(81156014)(256004)(33656002)(14444005)(81166006)(8676002)(19627235002)(316002)(6246003)(6506007)(97736004)(6436002)(305945005)(2906002)(446003)(3846002)(14454004)(26005)(33896004)(71190400001)(5250100002)(105586002)(76176011)(52116002)(6116002)(102836004)(486006)(7736002)(386003)(11346002)(107886003)(6862004)(229853002)(1076002)(71200400001)(4326008)(25786009)(2900100001)(6486002)(478600001)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4076; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 9MK9rQGBOk2OGRrQj2R7a9Pd5EbOgak4WQjzgQv1kTWMN5r1EbaRlilWmVw2CvoaL88UOcO/+f4FaLhHMEz0E+ESax7finQWZIgQvdikOCui4tYUOCvr66etw4gHuqBfgWQKuiPIQCmz2GJ4UXRAtwTIh9I4/JS9y9SEkwB8GOenxLi8eX+Rd/Gy07kp0H/LiF7neR8qw2QsInO50I2BNq+Dvs90r3IYQIX1pSOrgS/pVNC5wEKRK75PIkTZWXj4xngRJa8AFm34H/6XWkWae93Wdkdv+JYEjaQlxqTOX9ZbFG4ANj78qoyp0aa69LYEdQ7J32BEhHZA2tOybZOay9IMxrRLheyIhRIf8ck3p88= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <862356D5B6A88447BE35F9A8A1F302AE@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e011f916-abde-463d-0c79-08d62e48b76b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2018 00:38:37.1904 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4076 Subject: Re: [dpdk-dev] [PATCH v3 1/4] net/mlx5: add flow action functions to glue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 00:38:38 -0000 On Tue, Oct 09, 2018 at 10:25:34PM +0300, Dekel Peled wrote: > This patch adds glue functions for operations: > - Create packet reformat (encap/decap) flow action. > - Destroy flow action. >=20 > The new operations depend on HAVE_IBV_FLOW_ACTION_DV_SUPPORT. >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/Makefile | 5 +++++ > drivers/net/mlx5/meson.build | 2 ++ > drivers/net/mlx5/mlx5_glue.c | 38 ++++++++++++++++++++++++++++++++++++++ > drivers/net/mlx5/mlx5_glue.h | 13 +++++++++++++ > 4 files changed, 58 insertions(+) >=20 > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > index 92bae9d..474ad42 100644 > --- a/drivers/net/mlx5/Makefile > +++ b/drivers/net/mlx5/Makefile > @@ -142,6 +142,11 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-conf= ig-h.sh > enum MLX5DV_FLOW_ACTION_TAG \ > $(AUTOCONF_OUTPUT) > $Q sh -- '$<' '$@' \ > + HAVE_IBV_FLOW_ACTION_DV_SUPPORT \ > + infiniband/mlx5dv.h \ > + func mlx5dv_create_flow_action_packet_reformat \ > + $(AUTOCONF_OUTPUT) > + $Q sh -- '$<' '$@' \ > HAVE_ETHTOOL_LINK_MODE_25G \ > /usr/include/linux/ethtool.h \ > enum ETHTOOL_LINK_MODE_25000baseCR_Full_BIT \ > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index 6966248..d555c3c 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -96,6 +96,8 @@ if build > 'MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP' ], > [ 'HAVE_IBV_FLOW_DV_SUPPORT', 'infiniband/mlx5dv.h', > 'MLX5DV_FLOW_ACTION_TAG' ], > + [ 'HAVE_IBV_FLOW_ACTION_DV_SUPPORT', 'infiniband/mlx5dv.h', > + 'mlx5dv_create_flow_action_packet_reformat' ], > [ 'HAVE_IBV_DEVICE_MPLS_SUPPORT', 'infiniband/verbs.h', > 'IBV_FLOW_SPEC_MPLS' ], > [ 'HAVE_IBV_WQ_FLAG_RX_END_PADDING', 'infiniband/verbs.h', > diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c > index 48590df..63fbab1 100644 > --- a/drivers/net/mlx5/mlx5_glue.c > +++ b/drivers/net/mlx5/mlx5_glue.c > @@ -174,6 +174,17 @@ > return ibv_destroy_flow(flow_id); > } > =20 > +static int > +mlx5_glue_destroy_flow_action(struct ibv_flow_action *action) > +{ > +#ifdef HAVE_IBV_FLOW_ACTION_DV_SUPPORT > + return ibv_destroy_flow_action(action); > +#else > + (void)action; > + return NULL; And this should be return ENOTSUP; Return type mismatches, you'll see a compiler warning. Thanks, Yongseok