From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 811DE1B3B3
 for <dev@dpdk.org>; Wed, 10 Oct 2018 22:19:57 +0200 (CEST)
Received: from cpe-2606-a000-111b-40fe-f1c6-eb46-ccca-fca5.dyn6.twc.com
 ([2606:a000:111b:40fe:f1c6:eb46:ccca:fca5] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1gAKxU-00017w-0J; Wed, 10 Oct 2018 16:19:54 -0400
Date: Wed, 10 Oct 2018 16:19:19 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <20181010201919.GA19761@hmswarspite.think-freely.org>
References: <20181010142928.11274-1-nhorman@tuxdriver.com>
 <1766289.2YrT9N83Jn@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1766289.2YrT9N83Jn@xps>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH] check-experimental-syms.sh: prevent symbol
 matches on substrings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Oct 2018 20:19:57 -0000

On Wed, Oct 10, 2018 at 04:43:14PM +0200, Thomas Monjalon wrote:
> 10/10/2018 16:29, Neil Horman:
> > Thomas attempted to submit this:
> > https://patches.dpdk.org/patch/46311/
> > 
> > The other day, because the other patches being submitted with it were
> > breaking on a false positive from the check-experimental-syms check.
> > 
> > The problem was that the experimental symbol check script matched on the
> > regexs "\.text.*$SYM" and "\.text\.experimental.*$SYM" which allows for
> > substring matches, and librte_ethdev recently introduced symbols that
> > are leading substrings of one another (e.g. symbol foo is a substring of
> > symbol foobar), and so we would match on symbols when we shouldn't
> > 
> > Instead of dropping the check, fix this properly by matching
> > additionally on the end of line so that symbols are an exact match.
> > 
> > Confirmed to build properly on Thomas' submitted patch set with the
> > experimental check patch reverted (so that the checking actually
> > happens)
> 
> That's great Neil!
> I would like to push it now.
> May I suggest to remove the details of how I (baldly) reported it?
> 
> I suggest this text:
> "
> The experimental symbol check script matched on the regexes
> "\.text.*$SYM" and "\.text\.experimental.*$SYM" which allows for
> substring matches.
> If a symbol is leading substring of another one (e.g. symbol foo
> is a substring of symbol foobar), it would match on symbols
> when it shouldn't.
> 
> It is fixed by matching additionally on the end of line
> so that symbols are an exact match.
> "
Sure, if you want to make that change on commit, I'm ok with it.
Neil

> 
> 
> 
>