DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
	jfreimann@redhat.com, nicknickolaev@gmail.com,
	i.maximets@samsung.com, bruce.richardson@intel.com,
	alejandro.lucero@netronome.com
Cc: dgilbert@redhat.com, stable@dpdk.org,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v6 10/19] vhost: add config flag for postcopy feature
Date: Thu, 11 Oct 2018 11:24:23 +0200	[thread overview]
Message-ID: <20181011092432.22275-11-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20181011092432.22275-1-maxime.coquelin@redhat.com>

Postcopy live-migration features relies on userfaultfd,
which was only introduced in kernel v4.3.

This patch introduces a new define to allow building vhost
library on kernels not supporting userfaultfd.

With legacy build system, user has to explicitly set
CONFIG_RTE_LIBRTE_VHOST_POSTCOPY to 'y'.

With Meson build system, RTE_LIBRTE_VHOST_POSTCOPY gets
automatically defined if userfaultfd kernel header is
present.

Suggested-by: Ilya Maximets <i.maximets@samsung.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Ilya Maximets <i.maximets@samsung.com>
---
 config/common_linuxapp       | 1 +
 lib/librte_vhost/meson.build | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/config/common_linuxapp b/config/common_linuxapp
index 485e1467d..424100a75 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -14,6 +14,7 @@ CONFIG_RTE_LIBRTE_KNI=y
 CONFIG_RTE_LIBRTE_PMD_KNI=y
 CONFIG_RTE_LIBRTE_VHOST=y
 CONFIG_RTE_LIBRTE_VHOST_NUMA=y
+CONFIG_RTE_LIBRTE_VHOST_POSTCOPY=n
 CONFIG_RTE_LIBRTE_PMD_VHOST=y
 CONFIG_RTE_LIBRTE_IFC_PMD=y
 CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y
diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build
index 9d25b4d88..e33e6fc16 100644
--- a/lib/librte_vhost/meson.build
+++ b/lib/librte_vhost/meson.build
@@ -7,6 +7,8 @@ endif
 if has_libnuma == 1
 	dpdk_conf.set10('RTE_LIBRTE_VHOST_NUMA', true)
 endif
+dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY',
+	      cc.has_header('linux/userfaultfd.h'))
 version = 4
 allow_experimental_apis = true
 cflags += '-fno-strict-aliasing'
-- 
2.17.1

  parent reply	other threads:[~2018-10-11  9:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  9:24 [dpdk-dev] [PATCH v6 00/19] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 01/19] vhost: fix messages results handling Maxime Coquelin
2018-10-11 16:18   ` Ilya Maximets
2018-10-12  9:03     ` Maxime Coquelin
2018-10-12  9:55       ` Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 02/19] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 03/19] vhost: clarify reply-ack in case a reply was already sent Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 04/19] vhost: fix payload size of reply Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 05/19] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 06/19] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 07/19] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-11 15:59   ` Ilya Maximets
2018-10-12  8:43     ` Maxime Coquelin
2018-10-12  8:45       ` Maxime Coquelin
2018-10-12  8:57         ` Maxime Coquelin
2018-10-12  9:53           ` Ilya Maximets
2018-10-12  9:52             ` Maxime Coquelin
2018-10-12 10:04               ` Ilya Maximets
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 08/19] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 09/19] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-11  9:24 ` Maxime Coquelin [this message]
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 11/19] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 12/19] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 13/19] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 14/19] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 15/19] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 16/19] vhost: add support to postcopy's end request Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 17/19] vhost: restrict postcopy live-migration enablement Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 18/19] net/vhost: add parameter to enable postcopy support Maxime Coquelin
2018-10-11  9:24 ` [dpdk-dev] [PATCH v6 19/19] vhost: enable postcopy protocol feature Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011092432.22275-11-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dgilbert@redhat.com \
    --cc=i.maximets@samsung.com \
    --cc=jfreimann@redhat.com \
    --cc=nicknickolaev@gmail.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).