From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 648891B14E for ; Thu, 11 Oct 2018 11:29:43 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181011092942euoutp02dbfe707254c70855f414589ae7b18d5c~cg_Kxm5Du2600726007euoutp02S for ; Thu, 11 Oct 2018 09:29:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181011092942euoutp02dbfe707254c70855f414589ae7b18d5c~cg_Kxm5Du2600726007euoutp02S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1539250182; bh=ZnDVMZx+Ttzu8HPuwYOenq7bmrzj8RoRKzpoj3+WRQ4=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=dmw7xPO+NNDaT4gxPtFLPXeeOic3BB5qTfFGTlrUCUzz9UMZDY5wUtjKFUdEO96H2 Al988P9I4YFeUesv73GiW1bIxn00MzKlg+dPg8D80+CLQxWNdz+GflTypj9srF4sc6 c2iJhU+a5h/hweG156GAJZTL8hzFhhTVsaHU0pOY= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181011092941eucas1p1ca463ba60e5992d1188062bada8ad352~cg_KRUKaN2342523425eucas1p1o; Thu, 11 Oct 2018 09:29:41 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id E1.0B.04441.5081FBB5; Thu, 11 Oct 2018 10:29:41 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181011092940eucas1p1653f28aef02291d7c7aa780bb66f1535~cg_JbJ5iE1007410074eucas1p1Z; Thu, 11 Oct 2018 09:29:40 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181011092940eusmtrp1c2b1327d192effd91fb5c2c1563aa949~cg_JJ_-Ss1667716677eusmtrp1F; Thu, 11 Oct 2018 09:29:40 +0000 (GMT) X-AuditID: cbfec7f2-5c9ff70000001159-2e-5bbf180579c2 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B4.B5.04284.4081FBB5; Thu, 11 Oct 2018 10:29:40 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181011092939eusmtip1daf5a17ec556813d5b8eec2e39efb4e2~cg_Iidbc30681406814eusmtip1s; Thu, 11 Oct 2018 09:29:39 +0000 (GMT) To: Maxime Coquelin , dev@dpdk.org, bruce.richardson@intel.com Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, alejandro.lucero@netronome.com, dgilbert@redhat.com, stable@dpdk.org From: Ilya Maximets Date: Thu, 11 Oct 2018 12:32:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeXfO2Tlqk+NUfDJDWDfS1KSM8yG0pHBgofmpNKuZhyluajte MpLEysxUxNtyiZfynhHWdCameEnLwSgx0bA0ykJNzXkBS2ZuR8lvv/f//J/LH14KE/cQzlR0 bAKripUpJEJrvKVv1eBBQGfY4fZsF8ZgrBEwIw1+zJxRJ2ByWr6QzNC9VZIxNFbjTN/9dpzR Vw7jjClzjWSa09YFzMsP+YITNtI/FdWE9JXmMyl90j4lkKoffMWk8x0fhdJcbQMKFoZaH49k FdFJrMrL94p1VPakQRBfbHVdmzuJp6EaMgtZUUAfha7BDiwLWVNiug5BYZVOyD+WEMyWNAvN LjG9iGBlIWaro7f2E8GbahFMVKkR/1hAoO0cs8y1p/3BNPkWN7MDfRFG9QuWDsy8Y+j9OjIX hPQhGHjau8EUhdP74G5RkFl2pM9D70SlxSKi7eBdyXfLHCvaF3Q/ygkzY7QTpC/Vb7Ir6GZL LRmAHiahrmCc5JuT4FuzcTPoKaiezhDybA/T/dpN3QX0Bdk4z7dg/M4U4gdlIlB3mwR8wQ+0 MwbSfChGH4TnbV68fBKmfi0TZhloWxiZtePvsYX8FjXGyyLIzBDz7r3wt6sW49kZRucWyTwk 0WxLqdmWTLMtmeb/3gqENyAnNpFTylnOO5ZN9uRkSi4xVu55NU75Am18Lb2p39iKlgcjuhFN IckOUfDujjAxIUviUpTdCChM4iDyerghiSJlKTdYVdxlVaKC5brRLgqXOIlqyprCxLRclsDG sGw8q9qqCigr5zRE+QTIA1TPJkLlKSkOyfGPVx9FK46NDc+rA1tREXgR5WvpF1Zs/OfzlFEr Z03hCqzJrWy5MTyw50hnY/3Pa6k+ITncgaIofV6Nk7Dy9k69SVeoy5rZE3Hac+C12pZIdTVd alMYE0qLi4LqPKJD3N84l93cn/tbfs59wTFbUnJGgnNRMm83TMXJ/gE2CP2OVgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t/xu7osEvujDeYuULI492kZk8WNVfYW 7z5tZ7Lo3XaP3eJK+092i3NrlrJYHOvcw2JxeuE1Fot/HX/YLbY2/Gey2HxxEpMDt8evBUtZ PXbOusvusXjPSyaP6d0PmT3e77vK5tG3ZRVjAFuUnk1RfmlJqkJGfnGJrVK0oYWRnqGlhZ6R iaWeobF5rJWRqZK+nU1Kak5mWWqRvl2CXkbP03NMBdM4K7b0PWVpYFzG3sXIySEhYCJxZPkt 1i5GLg4hgaWMEn9/HmGGSEhJ/Ph1gRXCFpb4c62LDaLoPaPE6aVrWEASwgJOEv+engCzRQRi JDoO/AcrYhZYwSjROeEWO0THX0aJt4v2M4JUsQnoSJxafQTM5hWwk5izaxqQzcHBIqAq0TrV HyQsKhAhsXr5C1aIEkGJkzOfgC3gBCrf/mw+WJxZQF3iz7xLzBC2uETTl5VQcXmJ7W/nME9g FJqFpH0WkpZZSFpmIWlZwMiyilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzBStx37uXkH46WN wYcYBTgYlXh4f0jtixZiTSwrrsw9xCjBwawkwqs/AyjEm5JYWZValB9fVJqTWnyI0RTot4nM UqLJ+cAkklcSb2hqaG5haWhubG5sZqEkznveoDJKSCA9sSQ1OzW1ILUIpo+Jg1OqgVFxzUIv 5unxyk8OF3kmmnJw2V34vHp1Qs6v17GLQzKqmdhry/br/PvF/6P5tmTLT93CeO7QPYx7X3/S Xu7xeEK/4m6VXMvq9q2z5qVFupZ33ny/wHdbU+Gtd1/b/13f5r8nNqVSLeniodbAaJ+DG0Tf uF6dFyE1+9D2bz/U7q6Myk09Lv/mYIgSS3FGoqEWc1FxIgCdAGOI6gIAAA== Message-Id: <20181011092940eucas1p1653f28aef02291d7c7aa780bb66f1535~cg_JbJ5iE1007410074eucas1p1Z@eucas1p1.samsung.com> X-CMS-MailID: 20181011092940eucas1p1653f28aef02291d7c7aa780bb66f1535 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181010072546epcas4p1c4650793aa034668781446742ff3b0d0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181010072546epcas4p1c4650793aa034668781446742ff3b0d0 References: <20181009205426.21219-1-maxime.coquelin@redhat.com> <20181009205426.21219-2-maxime.coquelin@redhat.com> Subject: Re: [dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 09:29:43 -0000 On 10.10.2018 10:25, Maxime Coquelin wrote: > Hi Ilya > > On 10/09/2018 10:54 PM, Maxime Coquelin wrote: >> Return of message handling has now changed to an enum that can >> take non-negative value that is not zero in case a reply is >> needed. But the code checking the variable afterwards has not >> been updated, leading to success messages handling being >> treated as errors. >> >> External post and pre callbacks return type needs also to be >> changed to the new enum, so that its handling is consistent. >> This is done in this patch alongside with the convertion of >> its only user, vhost-crypto backend. >> >> Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature") >> >> Signed-off-by: Maxime Coquelin >> Acked-by: Ilya Maximets > > Sorry, I just notice I forgot to remove your ack from the commit > message as it has quite changed since the previous version. > > Please let me know if the patch is OK to you. Hi. Sorry for delay. Had no time to check it yesterday. Will take a look at your new v6. Best regards, Ilya Maximets. > > Regards, > Maxime