* [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update
@ 2018-10-11 19:34 Jerin Jacob
2018-10-11 19:34 ` [dpdk-dev] [PATCH 2/2] mbuf: fix missing Tx outer UDP checksum flag name Jerin Jacob
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Jerin Jacob @ 2018-10-11 19:34 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, thomas, ferruh.yigit, arybchenko, Jerin Jacob, stable
Fix missing PKT_TX_UDP_SEG ol_flag name and list updatation.
Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
lib/librte_mbuf/rte_mbuf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index 5297beb51..a93995184 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -408,6 +408,7 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask)
case PKT_TX_TUNNEL_UDP: return "PKT_TX_TUNNEL_UDP";
case PKT_TX_MACSEC: return "PKT_TX_MACSEC";
case PKT_TX_SEC_OFFLOAD: return "PKT_TX_SEC_OFFLOAD";
+ case PKT_TX_UDP_SEG: return "PKT_TX_UDP_SEG";
default: return NULL;
}
}
@@ -448,6 +449,7 @@ rte_get_tx_ol_flag_list(uint64_t mask, char *buf, size_t buflen)
"PKT_TX_TUNNEL_NONE" },
{ PKT_TX_MACSEC, PKT_TX_MACSEC, NULL },
{ PKT_TX_SEC_OFFLOAD, PKT_TX_SEC_OFFLOAD, NULL },
+ { PKT_TX_UDP_SEG, PKT_TX_UDP_SEG, NULL },
{ PKT_TX_OUTER_UDP_CKSUM, PKT_TX_OUTER_UDP_CKSUM, NULL },
};
const char *name;
--
2.19.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH 2/2] mbuf: fix missing Tx outer UDP checksum flag name 2018-10-11 19:34 [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update Jerin Jacob @ 2018-10-11 19:34 ` Jerin Jacob 2018-10-12 11:25 ` [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update Ferruh Yigit 2018-10-16 12:45 ` [dpdk-dev] [PATCH v2 " Jerin Jacob 2 siblings, 0 replies; 7+ messages in thread From: Jerin Jacob @ 2018-10-11 19:34 UTC (permalink / raw) To: Olivier Matz; +Cc: dev, thomas, ferruh.yigit, arybchenko, Nithin Dabilpuram From: Nithin Dabilpuram <ndabilpuram@marvell.com> Fix missing Tx outer udp checksum flag name Fixes: e1b1ae51877c ("ethdev: add Tx offload outer UDP checksum definition") Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> --- This patch is based on next-net tree. We could stash this patch. --- lib/librte_mbuf/rte_mbuf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index a93995184..fb741f06b 100644 --- a/lib/librte_mbuf/rte_mbuf.c +++ b/lib/librte_mbuf/rte_mbuf.c @@ -409,6 +409,7 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask) case PKT_TX_MACSEC: return "PKT_TX_MACSEC"; case PKT_TX_SEC_OFFLOAD: return "PKT_TX_SEC_OFFLOAD"; case PKT_TX_UDP_SEG: return "PKT_TX_UDP_SEG"; + case PKT_TX_OUTER_UDP_CKSUM: return "PKT_TX_OUTER_UDP_CKSUM"; default: return NULL; } } -- 2.19.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update 2018-10-11 19:34 [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update Jerin Jacob 2018-10-11 19:34 ` [dpdk-dev] [PATCH 2/2] mbuf: fix missing Tx outer UDP checksum flag name Jerin Jacob @ 2018-10-12 11:25 ` Ferruh Yigit 2018-10-16 12:45 ` [dpdk-dev] [PATCH v2 " Jerin Jacob 2 siblings, 0 replies; 7+ messages in thread From: Ferruh Yigit @ 2018-10-12 11:25 UTC (permalink / raw) To: Jerin Jacob, Olivier Matz; +Cc: dev, thomas, arybchenko, stable On 10/11/2018 8:34 PM, Jerin Jacob wrote: > Fix missing PKT_TX_UDP_SEG ol_flag name and list updatation. Hi Jerin, Patchset looks good, only there are a few more missings, would you mind updating them too since you already touched: In Tx: PKT_TX_QINQ s/PKT_TX_VLAN_PKT/PKT_TX_VLAN In Rx: PKT_RX_FDIR_ID PKT_RX_FDIR_FLX In rte_get_tx_ol_flag_list(), in `tx_flags`, s/"PKT_TX_TUNNEL_NONE"/NULL Thanks, ferruh > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > --- > lib/librte_mbuf/rte_mbuf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > index 5297beb51..a93995184 100644 > --- a/lib/librte_mbuf/rte_mbuf.c > +++ b/lib/librte_mbuf/rte_mbuf.c > @@ -408,6 +408,7 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask) > case PKT_TX_TUNNEL_UDP: return "PKT_TX_TUNNEL_UDP"; > case PKT_TX_MACSEC: return "PKT_TX_MACSEC"; > case PKT_TX_SEC_OFFLOAD: return "PKT_TX_SEC_OFFLOAD"; > + case PKT_TX_UDP_SEG: return "PKT_TX_UDP_SEG"; > default: return NULL; > } > } > @@ -448,6 +449,7 @@ rte_get_tx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) > "PKT_TX_TUNNEL_NONE" }, > { PKT_TX_MACSEC, PKT_TX_MACSEC, NULL }, > { PKT_TX_SEC_OFFLOAD, PKT_TX_SEC_OFFLOAD, NULL }, > + { PKT_TX_UDP_SEG, PKT_TX_UDP_SEG, NULL }, > { PKT_TX_OUTER_UDP_CKSUM, PKT_TX_OUTER_UDP_CKSUM, NULL }, > }; > const char *name; > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update 2018-10-11 19:34 [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update Jerin Jacob 2018-10-11 19:34 ` [dpdk-dev] [PATCH 2/2] mbuf: fix missing Tx outer UDP checksum flag name Jerin Jacob 2018-10-12 11:25 ` [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update Ferruh Yigit @ 2018-10-16 12:45 ` Jerin Jacob 2018-10-16 12:45 ` [dpdk-dev] [PATCH v2 2/2] mbuf: fix missing Tx outer UDP checksum flag name Jerin Jacob 2018-10-16 13:42 ` [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update Ferruh Yigit 2 siblings, 2 replies; 7+ messages in thread From: Jerin Jacob @ 2018-10-16 12:45 UTC (permalink / raw) To: Olivier Matz; +Cc: dev, thomas, ferruh.yigit, arybchenko, Jacob, Jerin, stable Fix missing PKT_TX* ol_flag name and list updatation. Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") Fixes: 829a1c2c41dc ("mbuf: extend flow director field") Fixes: 63c0d74daaa9 ("mbuf: add Tx side tunneling type") Cc: stable@dpdk.org Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> --- v2: - Fix remaning PKT_TX* and PKT_RX flags name and list update(Ferruh Yigit) http://patches.dpdk.org/patch/46657/ --- lib/librte_mbuf/rte_mbuf.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index 5297beb51..bb95d3a5c 100644 --- a/lib/librte_mbuf/rte_mbuf.c +++ b/lib/librte_mbuf/rte_mbuf.c @@ -296,6 +296,8 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask) case PKT_RX_VLAN_STRIPPED: return "PKT_RX_VLAN_STRIPPED"; case PKT_RX_IEEE1588_PTP: return "PKT_RX_IEEE1588_PTP"; case PKT_RX_IEEE1588_TMST: return "PKT_RX_IEEE1588_TMST"; + case PKT_RX_FDIR_ID: return "PKT_RX_FDIR_ID"; + case PKT_RX_FDIR_FLX: return "PKT_RX_FDIR_FLX"; case PKT_RX_QINQ_STRIPPED: return "PKT_RX_QINQ_STRIPPED"; case PKT_RX_QINQ: return "PKT_RX_QINQ"; case PKT_RX_LRO: return "PKT_RX_LRO"; @@ -339,6 +341,8 @@ rte_get_rx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) { PKT_RX_VLAN_STRIPPED, PKT_RX_VLAN_STRIPPED, NULL }, { PKT_RX_IEEE1588_PTP, PKT_RX_IEEE1588_PTP, NULL }, { PKT_RX_IEEE1588_TMST, PKT_RX_IEEE1588_TMST, NULL }, + { PKT_RX_FDIR_ID, PKT_RX_FDIR_ID, NULL }, + { PKT_RX_FDIR_FLX, PKT_RX_FDIR_FLX, NULL }, { PKT_RX_QINQ_STRIPPED, PKT_RX_QINQ_STRIPPED, NULL }, { PKT_RX_LRO, PKT_RX_LRO, NULL }, { PKT_RX_TIMESTAMP, PKT_RX_TIMESTAMP, NULL }, @@ -386,7 +390,7 @@ rte_get_rx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) const char *rte_get_tx_ol_flag_name(uint64_t mask) { switch (mask) { - case PKT_TX_VLAN_PKT: return "PKT_TX_VLAN_PKT"; + case PKT_TX_VLAN: return "PKT_TX_VLAN"; case PKT_TX_IP_CKSUM: return "PKT_TX_IP_CKSUM"; case PKT_TX_TCP_CKSUM: return "PKT_TX_TCP_CKSUM"; case PKT_TX_SCTP_CKSUM: return "PKT_TX_SCTP_CKSUM"; @@ -406,8 +410,10 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask) case PKT_TX_TUNNEL_VXLAN_GPE: return "PKT_TX_TUNNEL_VXLAN_GPE"; case PKT_TX_TUNNEL_IP: return "PKT_TX_TUNNEL_IP"; case PKT_TX_TUNNEL_UDP: return "PKT_TX_TUNNEL_UDP"; + case PKT_TX_QINQ: return "PKT_TX_QINQ"; case PKT_TX_MACSEC: return "PKT_TX_MACSEC"; case PKT_TX_SEC_OFFLOAD: return "PKT_TX_SEC_OFFLOAD"; + case PKT_TX_UDP_SEG: return "PKT_TX_UDP_SEG"; default: return NULL; } } @@ -417,7 +423,7 @@ int rte_get_tx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) { const struct flag_mask tx_flags[] = { - { PKT_TX_VLAN_PKT, PKT_TX_VLAN_PKT, NULL }, + { PKT_TX_VLAN, PKT_TX_VLAN, NULL }, { PKT_TX_IP_CKSUM, PKT_TX_IP_CKSUM, NULL }, { PKT_TX_TCP_CKSUM, PKT_TX_L4_MASK, NULL }, { PKT_TX_SCTP_CKSUM, PKT_TX_L4_MASK, NULL }, @@ -430,24 +436,18 @@ rte_get_tx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) { PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IP_CKSUM, NULL }, { PKT_TX_OUTER_IPV4, PKT_TX_OUTER_IPV4, NULL }, { PKT_TX_OUTER_IPV6, PKT_TX_OUTER_IPV6, NULL }, - { PKT_TX_TUNNEL_VXLAN, PKT_TX_TUNNEL_MASK, - "PKT_TX_TUNNEL_NONE" }, - { PKT_TX_TUNNEL_GRE, PKT_TX_TUNNEL_MASK, - "PKT_TX_TUNNEL_NONE" }, - { PKT_TX_TUNNEL_IPIP, PKT_TX_TUNNEL_MASK, - "PKT_TX_TUNNEL_NONE" }, - { PKT_TX_TUNNEL_GENEVE, PKT_TX_TUNNEL_MASK, - "PKT_TX_TUNNEL_NONE" }, - { PKT_TX_TUNNEL_MPLSINUDP, PKT_TX_TUNNEL_MASK, - "PKT_TX_TUNNEL_NONE" }, - { PKT_TX_TUNNEL_VXLAN_GPE, PKT_TX_TUNNEL_MASK, - "PKT_TX_TUNNEL_NONE" }, - { PKT_TX_TUNNEL_IP, PKT_TX_TUNNEL_MASK, - "PKT_TX_TUNNEL_NONE" }, - { PKT_TX_TUNNEL_UDP, PKT_TX_TUNNEL_MASK, - "PKT_TX_TUNNEL_NONE" }, + { PKT_TX_TUNNEL_VXLAN, PKT_TX_TUNNEL_MASK, NULL }, + { PKT_TX_TUNNEL_GRE, PKT_TX_TUNNEL_MASK, NULL }, + { PKT_TX_TUNNEL_IPIP, PKT_TX_TUNNEL_MASK, NULL }, + { PKT_TX_TUNNEL_GENEVE, PKT_TX_TUNNEL_MASK, NULL }, + { PKT_TX_TUNNEL_MPLSINUDP, PKT_TX_TUNNEL_MASK, NULL }, + { PKT_TX_TUNNEL_VXLAN_GPE, PKT_TX_TUNNEL_MASK, NULL }, + { PKT_TX_TUNNEL_IP, PKT_TX_TUNNEL_MASK, NULL }, + { PKT_TX_TUNNEL_UDP, PKT_TX_TUNNEL_MASK, NULL }, + { PKT_TX_QINQ, PKT_TX_QINQ, NULL }, { PKT_TX_MACSEC, PKT_TX_MACSEC, NULL }, { PKT_TX_SEC_OFFLOAD, PKT_TX_SEC_OFFLOAD, NULL }, + { PKT_TX_UDP_SEG, PKT_TX_UDP_SEG, NULL }, { PKT_TX_OUTER_UDP_CKSUM, PKT_TX_OUTER_UDP_CKSUM, NULL }, }; const char *name; -- 2.19.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] mbuf: fix missing Tx outer UDP checksum flag name 2018-10-16 12:45 ` [dpdk-dev] [PATCH v2 " Jerin Jacob @ 2018-10-16 12:45 ` Jerin Jacob 2018-10-16 13:42 ` [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update Ferruh Yigit 1 sibling, 0 replies; 7+ messages in thread From: Jerin Jacob @ 2018-10-16 12:45 UTC (permalink / raw) To: Olivier Matz; +Cc: dev, thomas, ferruh.yigit, arybchenko, Nithin Dabilpuram From: Nithin Dabilpuram <ndabilpuram@marvell.com> Fix missing Tx outer udp checksum flag name Fixes: e1b1ae51877c ("ethdev: add Tx offload outer UDP checksum definition") Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> --- This patch is based on next-net tree. We could stash this patch. --- lib/librte_mbuf/rte_mbuf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index bb95d3a5c..3a1f3baa6 100644 --- a/lib/librte_mbuf/rte_mbuf.c +++ b/lib/librte_mbuf/rte_mbuf.c @@ -414,6 +414,7 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask) case PKT_TX_MACSEC: return "PKT_TX_MACSEC"; case PKT_TX_SEC_OFFLOAD: return "PKT_TX_SEC_OFFLOAD"; case PKT_TX_UDP_SEG: return "PKT_TX_UDP_SEG"; + case PKT_TX_OUTER_UDP_CKSUM: return "PKT_TX_OUTER_UDP_CKSUM"; default: return NULL; } } -- 2.19.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update 2018-10-16 12:45 ` [dpdk-dev] [PATCH v2 " Jerin Jacob 2018-10-16 12:45 ` [dpdk-dev] [PATCH v2 2/2] mbuf: fix missing Tx outer UDP checksum flag name Jerin Jacob @ 2018-10-16 13:42 ` Ferruh Yigit 2018-10-16 13:55 ` Ferruh Yigit 1 sibling, 1 reply; 7+ messages in thread From: Ferruh Yigit @ 2018-10-16 13:42 UTC (permalink / raw) To: Jerin Jacob, Olivier Matz; +Cc: dev, thomas, arybchenko, Jacob, Jerin, stable On 10/16/2018 1:45 PM, Jerin Jacob wrote: > Fix missing PKT_TX* ol_flag name and list updatation. > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Fixes: 829a1c2c41dc ("mbuf: extend flow director field") > Fixes: 63c0d74daaa9 ("mbuf: add Tx side tunneling type") > > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> For series, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> (since now updated for both Rx & Tx, patch title needs to be updated, I will do it while merging) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update 2018-10-16 13:42 ` [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update Ferruh Yigit @ 2018-10-16 13:55 ` Ferruh Yigit 0 siblings, 0 replies; 7+ messages in thread From: Ferruh Yigit @ 2018-10-16 13:55 UTC (permalink / raw) To: Jerin Jacob, Olivier Matz; +Cc: dev, thomas, arybchenko, Jacob, Jerin, stable On 10/16/2018 2:42 PM, Ferruh Yigit wrote: > On 10/16/2018 1:45 PM, Jerin Jacob wrote: >> Fix missing PKT_TX* ol_flag name and list updatation. >> >> Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") >> Fixes: 829a1c2c41dc ("mbuf: extend flow director field") >> Fixes: 63c0d74daaa9 ("mbuf: add Tx side tunneling type") >> >> Cc: stable@dpdk.org >> >> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > For series, > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > (since now updated for both Rx & Tx, patch title needs to be updated, I will do > it while merging) Series applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-16 13:55 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-11 19:34 [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update Jerin Jacob 2018-10-11 19:34 ` [dpdk-dev] [PATCH 2/2] mbuf: fix missing Tx outer UDP checksum flag name Jerin Jacob 2018-10-12 11:25 ` [dpdk-dev] [PATCH 1/2] mbuf: fix missing Tx offload flag name and list update Ferruh Yigit 2018-10-16 12:45 ` [dpdk-dev] [PATCH v2 " Jerin Jacob 2018-10-16 12:45 ` [dpdk-dev] [PATCH v2 2/2] mbuf: fix missing Tx outer UDP checksum flag name Jerin Jacob 2018-10-16 13:42 ` [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update Ferruh Yigit 2018-10-16 13:55 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).