From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690066.outbound.protection.outlook.com [40.107.69.66]) by dpdk.org (Postfix) with ESMTP id 83AFF1B207 for ; Fri, 12 Oct 2018 11:02:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HOfkwyXP5O2qXmTdGDhLkQXfDgU/qxiS6iqwQSzzx+A=; b=Zpuf1XuhJMPtxAzdA4Z6j2n/m32t+QYzPXn2rMHe6fJdXz5gOzgUDH2vDyLJQ8dEXajtbeaz0G8Y23FAwydmfKKsJpszEHjiH1VGPjupZWkw+10sZio4U9KInHi0efxtB9esU5eIQVh54LUdCC76VWPurrp9xQYBEszd/x6BQKQ= Received: from ltp-pvn (115.113.156.3) by BYAPR07MB4965.namprd07.prod.outlook.com (2603:10b6:a03:5b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.26; Fri, 12 Oct 2018 09:02:05 +0000 Date: Fri, 12 Oct 2018 14:31:43 +0530 From: Pavan Nikhilesh To: Shreyansh Jain , anatoly.burakov@intel.com, hemant.agrawal@nxp.com Cc: jkollanukkaran@caviumnetworks.com, dev@dpdk.org Message-ID: <20181012090142.GA15154@ltp-pvn> References: <20180925125423.7505-1-shreyansh.jain@nxp.com> <20181009112548.7025-1-shreyansh.jain@nxp.com> <20181009112548.7025-2-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181009112548.7025-2-shreyansh.jain@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0036.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::22) To BYAPR07MB4965.namprd07.prod.outlook.com (2603:10b6:a03:5b::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb85881e-6070-407d-1000-08d63021635b X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4965; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 3:mEIWbVn24TmxJ1M+U4IzXotXbRN8xj7GNKe/fIYATkW+GGslSTqT7wR4Vtw6XfS9mo3ucwUK/GuyE9KTpEheyz9RHnah9ukOQBnatH9OYHsvr8sa/IXEsPGTHWpZpVfYDJW2vkZPA0InsVzWGIgDwU4/F8WYkwhEekj1J2PDgjCYJQMpZMjvWIhqiUViReiarc91GaM7+Ijw+Eh/rTYbI6BaO1ikV5rxKxDa5RtrSnGIkAfwUOh9NfL61qzf7jQc; 25:cVEpaZSH3PqJmfOziQDf8NqXQTL0vYDV4r2w/92wCoUjKWnh9AOgvAl9U7C7fXhF9d5G6TT6nRRc11P+V47nas8SR/b0gWF4DT1mmpAeCbgfh74p+BAJgJMVKhSVddvLKqkYmW0w9tNkgyzK9Gt371Y1HerBXiSc5vFELuyRqZwwEZe/1ME3QFx08cwoZbG75DBFJT92mmUxNR6+I7I5TQPHPSHIrFTb9erijLPZO31IGK9wSj8vTIa3FCMT4igHNUABnsJWN3lKWo9wEtv7Uz01ZthppkQmHHICBIGzU1NrsUE+BlrQRAkVpY0ta7g/O1NIOzS4YHrwkoaXiScYag==; 31:V7GolKpNSbJNPoJXNTWXsCCOJ0huGG9JcdbSMpMRHf7RkGmQfOlu0lGOV0l/GXE+ozP/YeBRnLE0thKYRWtoMEyhQPES6I//NijB1l+np1amYWKL5urTvl+A+487Dg/s2UbDJAwKpfHh5LcXjS/EcBT50UItebcyYclV7hvtB6iTJvr5fKeT7wT4IyKGxaw2jgeafYgvKXOygaHe0fAfCBZVUc4cX8afQj1Y+9XAEeA= X-MS-TrafficTypeDiagnostic: BYAPR07MB4965: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 20:FK8sjpwEGcyQ6VNIhgBrwxQZRAOQcW/ST6rSdw0zBAgM8FXbj/lKZkPg5m0wnt1OtRxG5O4KYg80I1CGIYub7ZBmwUclmumexrEXVXdFNg9uCWEtjsZmYWrvALmSH9oFmTJY6g0A0Xseyin0kC5S8ME7mGX8Nb0Os91k1HntN9NcyZ84PQ5JkTuyxKu6Uf5L3Hf34bNDUNITils6hh7XIvSdy5zmRPCxMKNfl+PUsilh2dd8yGgJ1teoLgrXgZ/0XTLSsdgFnLCVO1jzGup53Di7GMAK6JGulVXDBGMxNDXdQU1ft6w9zLngC3K7fJ/YawufEHY5pC8fmrE1KYe31+tEXUouCW/f3ecw5W/l1wYdK6Yj/AiRByF7cuYZXVYt/IQ46qVwWZuJC5ZItU3ndLH2UFv3WtOfvMFdW1tdUuiKb/sRrwYmDYcHbhURReIuCwjVT0oh12SL5K5I9ZOSnaO75hbCnf7A9vnT5UBX/tEqryFXAfpmAGH9hYYR+Ho2vXmc5HNYhhlgd2ROhZ/T7Q/joKQD7Ik4up4D8V2IJiEao2x4egK7ibpyX+1xecOveart/ActwJA2pq7mmIYBSWUwBKxbbl6Kw2iclxJDvP0=; 4:/U1IVr3f+VL1PZE4gy+5dkuye3Qh0dTwLIL6Tu5DDMVzs3/xkFtlKiTUyzKSmvMOmOBdnVk1Zz5OOEkZJWdmLM01t4m2owJ1VNgGj8YFBV50n+BBVbFq60UmrEAS3F8UJOHzcKNahn5+x4XiK92qDbE/CUY8s3cMz6XJSya4NnZTvROkYxvxekQopyzuJvM/PNLJinzvSZJRnQhsW6IQ5gocLZrzeku3KexI0BIapyDvO5M4yJds7kEXToYE5NW42b1lFR+CThNgTyxtGXFodgGWiZNKKe7iZuORtvkTMjPZE3MM/e1WvMgn17X4UtIt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(149066)(150057)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991067); SRVR:BYAPR07MB4965; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4965; X-Forefront-PRVS: 0823A5777B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(376002)(39860400002)(136003)(346002)(199004)(189003)(9686003)(52116002)(5660300001)(33656002)(68736007)(6246003)(6496006)(7736002)(305945005)(106356001)(3846002)(23726003)(1076002)(33716001)(6116002)(76176011)(66066001)(25786009)(47776003)(105586002)(97736004)(33896004)(50466002)(14444005)(4326008)(386003)(72206003)(956004)(8936002)(11346002)(446003)(53936002)(476003)(229853002)(486006)(6666004)(26005)(8676002)(42882007)(55236004)(16526019)(186003)(81156014)(81166006)(58126008)(16586007)(2906002)(55016002)(478600001)(316002)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4965; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4965; 23:XGkJf0c7ISl+pm67Tu8y/XGP6N+wEZSM5MsDLXkZH?= =?us-ascii?Q?tfAofmCvIe31tyNIrH9h9wYHqRYxNBeRtMuaN3BvJA8bQ2tJy89owWyjn87P?= =?us-ascii?Q?5YmkvV7MSqJojfY/fYMRFaZI/yulyuqkumIGiuGzegPascvPpPg5hUuPhl82?= =?us-ascii?Q?fbCPoOVraloTJeA2yH+gsMmqIGEeByKUSekP4DdyzTEKzN4U74X7IStQiRF4?= =?us-ascii?Q?Vhx7zv94ajY+Uo4MezRM/+iKIN02mdt4RixmiTLek6B7t74ZkrzUtuPyO283?= =?us-ascii?Q?Pw9PFnqm5CN7yjhmsH7OwhJN/qeQcZjBLZuvUfAP3DeZiCdvKb1xGQHiAJn6?= =?us-ascii?Q?9nyCYxjf9PyYkkk84Rca+UuBGoIw0O0qXXOajktF9uPkENF9ie4uGQk5yIJG?= =?us-ascii?Q?BhpI2OLx/8rvKMSIwXYUXGRvfQq8AS80P1XMtMmR6uD9o2jr0/K+TDZJHPRo?= =?us-ascii?Q?to6IYY6aqfrbfx/pT8qpHPP3pCFy6ibJ/hOq1r1pyRNLpcazQJSgkFV615OJ?= =?us-ascii?Q?miG5ehJcWdgE54M4CYY/wXJPcEtMh3byFAf0fx+CcSDfwjcXglA7PMuj6Dd/?= =?us-ascii?Q?o51TwPiUflTF5v8PCLv/KIKpAkgkNCWKn+dkP0ZCSMXDBQvmz2qj9RG4UtCC?= =?us-ascii?Q?AOOb3FeLDWXrmw8L/gqn4saqZPq0wOdgFtKeLoqkmFB0VbPBmz90/XDVd2zi?= =?us-ascii?Q?4ycu9MdesRmf18IR7p2CFPxx3w4SQ7IFYfjO5tCTozuXKhT7+SGLNF2+m2Wi?= =?us-ascii?Q?QLNuBmr6OoLVYOPMQwirndz7aZTwFS8SwXL3Kj/+DPc+SxRfeLTuE2wfxBXh?= =?us-ascii?Q?HVA5ewVMeGDF816CHOYL70civjAe+vKzQrN7UPPMTbCViPMDQQw7UqVheEfL?= =?us-ascii?Q?0W6BE5PaNY02aj3tlmBhW5xvFQyIwoZF5wuWeJNETrKfs1NYPx95pAxsva50?= =?us-ascii?Q?rTKgZpmn0obaDl5D9J9kOAGvt77Zo1z1hoXyq3LX7ySsXVY5modWogRGmlrV?= =?us-ascii?Q?IGIJZzf/OGs3NLA2usO49XAi61TCm+UfpM/hcOdCav4P1t062yx2L60KqlIT?= =?us-ascii?Q?7G299mFPxVIvXTs+Ho/RYskoYQdk4fNs7PCyscGx7JDzy8u++u1+XOKsNwBa?= =?us-ascii?Q?VNPuGz8JQ7/qYW6eqag8xm+2TuMbgef4/VJ8XXYGmdOUhiAQXRVEyzEA9FvG?= =?us-ascii?Q?d9Wopf0e1yoZOmO4anvlvjDCz5xrCXqG5sWgFitUepdS8CPn/JPZlz0dBza+?= =?us-ascii?Q?D+irhlERelhAARo9rGH5r4V3SK9zolOZGGpYySreYU1OYkPnDeJGI/UNde8N?= =?us-ascii?Q?dBkg7gKiG5nJ0Y3B5U2+F8dWEQBfXjbSsb4ptq/OTCN7h61a7UTySj11GWfH?= =?us-ascii?Q?0uqgw=3D=3D?= X-Microsoft-Antispam-Message-Info: pXYWMR2akvCpRmmHKWASQDAEQm5KY10y5V/C297/ZR48ZuiJZYeMGhrmfEkOz6+ksDuO88/ozlS5FZqWQT1+QC9lHAbs2LbdWy9bpwZ4KPYfgn6SqVsTZcjDAmOnYnIG8+dD3Hu/jNp11fcTmP0AowkYrQ6v7G5sy3ILm0dxvjEjTyueV+rHn6dCUNetN30rk5fdq9f+EZYd1m3abRFKePn70mgmnCR0i9H18hI4maxVTSFaXTN1L+P7vd4nqEwvEtFYDvnQVinC9N3+fi7UNOpXbYPPVXkSrZFFiiZrEk9v12Vf5o+9gX6RF28MjfM8sV/Ksnn9MCIYXcQCdZr+gds5pCTeeVee0eHqWTt89ws= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 6:mC54s4kAc0FDFEhaUotq4AT0DXDttdJX3f2SG0XCoaxLf8MUEZ28X+VSyY1TiXBPyWAbc92WBG0xF8JOdHWzYwqZ8R23ZsWgjPECSOYM9jrFUJ3Ffvqmsxr8oOOqSQoi5UlGV9xv/TVk4g4TibV6HVa7XB1XPT7kUX/poP+pdJrvFF56d1nRxWlXkzyFuUQOhSCkmLnxWqog9EwXzl3/LlKkCYqoYRiwrPgDXmPk8HzZ31auZuz10NZD7EefzTp9RkU+BrWEV5ch2hv10j8/RtjKb2Q+YbH0k4MxsUQav6WaaYco0uZbBgL/l4o11MGB0meffPplmMFyzfb3/q2Ujwr8AaE6Mk0YbhJLz7j2PINktUJF3VbbfT92ndlJDBs15+dxMmcUrDY09mjtzzfmWibk7VaiOJhn0TT9Ut1ozmTTTfdLsVswXY5diPme8iP+rwVprQcWF5Pm0pYpRcDvmw==; 5:VXLN0YB66EkO0j2tw9s0efo62mjMCEF8qemIgsg8r5w9YiVqVWcTbyn5iMKoGpTo1HOZ79vqbqMVMW8mPNGlX7S5i2auIzPfNd+ll9lwel3Seq5+7VKpYtnPoTm5N849Jc+IgVZ5LmzvqFP9jtSq5Qa/i1mOe91VEuY6ghXTBoE=; 7:hJXktoGNlg0B7GNiT/06t5n3w5zpy9cGF4m5l2VNCi1FC+4ZC1R5PJpChhrdX31ps4c526OgMHrSZtLCFVmKuY3NH+i9kVPw8YMFfQU7EjF/lR/lVNwRZKO0DEsKspyiUQtWkhPk6ZLOmb9mhQxgzIqA2cgnLKeIFy32mEY1QE6A3SHc1hLh7SaeTke77f+aFlqSg/qzf2yq9EJ9cG5Y3AoKnu6rorbY/qBi3/kSllu7xLQv4N0YeqVVmgaELVhH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2018 09:02:05.4012 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb85881e-6070-407d-1000-08d63021635b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4965 Subject: Re: [dpdk-dev] [PATCH v2 1/5] bus/fslmc: fix physical addressing check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 09:02:11 -0000 Hi Shreyansh, On Tue, Oct 09, 2018 at 04:55:44PM +0530, Shreyansh Jain wrote: > In case RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is enabled, only supported > class is RTE_IOVA_PA. > > Fixes: f7768afac101 ("bus/fslmc: support dynamic IOVA") > Cc: hemant.agrawal@nxp.com > > Signed-off-by: Shreyansh Jain > --- > drivers/bus/fslmc/fslmc_bus.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c > index bfe81e236..a4f9a9eee 100644 > --- a/drivers/bus/fslmc/fslmc_bus.c > +++ b/drivers/bus/fslmc/fslmc_bus.c > @@ -491,6 +491,10 @@ rte_dpaa2_get_iommu_class(void) > bool is_vfio_noiommu_enabled = 1; > bool has_iova_va; > > +#ifdef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA > + return RTE_IOVA_PA; > +#endif > + As, RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is set to true by default[1] and fslmc bus being always registered[2] irrespective of the underlying platform, the IOVA class will be always returned as PA. This will break multiple platforms as some work only when IOVA as VA. I think you need to verify if the underlying platform is really FLMC similar to DPAA[3] [1] ->[master]ltp-pvn[dpdk] $ grep -nir "RTE_LIBRTE_DPAA2_USE_PHYS_IOVA" config/ config/meson.build:86:dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true) config/common_base:218:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y [2] config/common_linuxapp:45:CONFIG_RTE_LIBRTE_FSLMC_BUS=y [3] static enum rte_iova_mode rte_dpaa_get_iommu_class(void) { if ((access(DPAA_DEV_PATH1, F_OK) != 0) && (access(DPAA_DEV_PATH2, F_OK) != 0)) { return RTE_IOVA_DC; } return RTE_IOVA_PA; } > if (TAILQ_EMPTY(&rte_fslmc_bus.device_list)) > return RTE_IOVA_DC; > > -- > 2.17.1 > Thanks, Pavan.