DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
	jfreimann@redhat.com, nicknickolaev@gmail.com,
	i.maximets@samsung.com, bruce.richardson@intel.com,
	alejandro.lucero@netronome.com
Cc: dgilbert@redhat.com, stable@dpdk.org,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v7 16/19] vhost: add support to postcopy's end request
Date: Fri, 12 Oct 2018 14:40:44 +0200	[thread overview]
Message-ID: <20181012124047.17884-17-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20181012124047.17884-1-maxime.coquelin@redhat.com>

The master sends this message before stopping handling
userfaults, so that the backend closes the userfaultfd.

The master waits for the slave to acknowledge the request
with an empty 64bits payload for synchronization purpose.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/librte_vhost/vhost_user.c | 21 +++++++++++++++++++++
 lib/librte_vhost/vhost_user.h |  3 ++-
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 8890abbe8..0560f2f96 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -77,6 +77,7 @@ static const char *vhost_message_str[VHOST_USER_MAX] = {
 	[VHOST_USER_CRYPTO_CLOSE_SESS] = "VHOST_USER_CRYPTO_CLOSE_SESS",
 	[VHOST_USER_POSTCOPY_ADVISE]  = "VHOST_USER_POSTCOPY_ADVISE",
 	[VHOST_USER_POSTCOPY_LISTEN]  = "VHOST_USER_POSTCOPY_LISTEN",
+	[VHOST_USER_POSTCOPY_END]  = "VHOST_USER_POSTCOPY_END",
 };
 
 static int send_vhost_reply(int sockfd, struct VhostUserMsg *msg);
@@ -1636,6 +1637,25 @@ vhost_user_set_postcopy_listen(struct virtio_net **pdev,
 	return VH_RESULT_OK;
 }
 
+static int
+vhost_user_postcopy_end(struct virtio_net **pdev, struct VhostUserMsg *msg,
+			int main_fd __rte_unused)
+{
+	struct virtio_net *dev = *pdev;
+
+	dev->postcopy_listening = 0;
+	if (dev->postcopy_ufd >= 0) {
+		close(dev->postcopy_ufd);
+		dev->postcopy_ufd = -1;
+	}
+
+	msg->payload.u64 = 0;
+	msg->size = sizeof(msg->payload.u64);
+	msg->fd_num = 0;
+
+	return VH_RESULT_REPLY;
+}
+
 typedef int (*vhost_message_handler_t)(struct virtio_net **pdev,
 					struct VhostUserMsg *msg,
 					int main_fd);
@@ -1665,6 +1685,7 @@ static vhost_message_handler_t vhost_message_handlers[VHOST_USER_MAX] = {
 	[VHOST_USER_IOTLB_MSG] = vhost_user_iotlb_msg,
 	[VHOST_USER_POSTCOPY_ADVISE] = vhost_user_set_postcopy_advise,
 	[VHOST_USER_POSTCOPY_LISTEN] = vhost_user_set_postcopy_listen,
+	[VHOST_USER_POSTCOPY_END] = vhost_user_postcopy_end,
 };
 
 
diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
index 55d8659ba..73b1fe2b9 100644
--- a/lib/librte_vhost/vhost_user.h
+++ b/lib/librte_vhost/vhost_user.h
@@ -52,7 +52,8 @@ typedef enum VhostUserRequest {
 	VHOST_USER_CRYPTO_CLOSE_SESS = 27,
 	VHOST_USER_POSTCOPY_ADVISE = 28,
 	VHOST_USER_POSTCOPY_LISTEN = 29,
-	VHOST_USER_MAX = 30
+	VHOST_USER_POSTCOPY_END = 30,
+	VHOST_USER_MAX = 31
 } VhostUserRequest;
 
 typedef enum VhostUserSlaveRequest {
-- 
2.17.1

  parent reply	other threads:[~2018-10-12 12:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 12:40 [dpdk-dev] [PATCH v7 00/19] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 01/19] vhost: fix messages results handling Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 02/19] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 03/19] vhost: clarify reply-ack in case a reply was already sent Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 04/19] vhost: fix payload size of reply Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 05/19] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 06/19] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 07/19] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 08/19] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 09/19] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 10/19] vhost: add config flag for postcopy feature Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 11/19] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 12/19] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 13/19] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 14/19] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 15/19] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-12 12:40 ` Maxime Coquelin [this message]
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 17/19] vhost: restrict postcopy live-migration enablement Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 18/19] net/vhost: add parameter to enable postcopy support Maxime Coquelin
2018-10-12 12:40 ` [dpdk-dev] [PATCH v7 19/19] vhost: enable postcopy protocol feature Maxime Coquelin
2018-10-16  8:37 ` [dpdk-dev] [PATCH v7 00/19] vhost: add postcopy live-migration support Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012124047.17884-17-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dgilbert@redhat.com \
    --cc=i.maximets@samsung.com \
    --cc=jfreimann@redhat.com \
    --cc=nicknickolaev@gmail.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).