From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0063.outbound.protection.outlook.com [104.47.0.63]) by dpdk.org (Postfix) with ESMTP id 5CBB2374 for ; Mon, 15 Oct 2018 03:45:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NWhzsanPO+JogEX+rL8IozqEpHWdGc4bb6a8Ptz/n7I=; b=EtabmNAfR1RDzaNQ4ISU5ULugk03GkDA9Ghscp0Ng7O9EPnCo4LJnVA0Ezf3nYt7yCYxF0hsyIygv3BdBOybjT2314ZrOZOHXS5KWX9hL1Y+mL8mpQA0msAwurFg/swN7SEfvfLbG/lgaMxYwXTdizE6v4hhbcLQLTRAzigHCzg= Received: from DB6PR0501MB2023.eurprd05.prod.outlook.com (10.168.9.17) by DB6PR0501MB2454.eurprd05.prod.outlook.com (10.168.73.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.26; Mon, 15 Oct 2018 01:45:24 +0000 Received: from DB6PR0501MB2023.eurprd05.prod.outlook.com ([fe80::b1fb:bad3:b5b1:f913]) by DB6PR0501MB2023.eurprd05.prod.outlook.com ([fe80::b1fb:bad3:b5b1:f913%3]) with mapi id 15.20.1228.027; Mon, 15 Oct 2018 01:45:24 +0000 From: Jack Min To: Shahaf Shuler , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix compiling issue of zero-size array Thread-Index: AQHUZCi9X+MJHICFUkiIYhu5d/5Rbg== Date: Mon, 15 Oct 2018 01:45:23 +0000 Message-ID: <20181015014500.6004-1-jackmin@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR03CA0038.apcprd03.prod.outlook.com (2603:1096:203:2f::26) To DB6PR0501MB2023.eurprd05.prod.outlook.com (2603:10a6:4:6::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jackmin@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [118.201.220.138] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0501MB2454; 6:AEbyl1XxhnqDJ5fnJj0EQkFO2RWmbp3Q9Kmcypsu/C4kWdZhRFm9URF/9SyBUs7T++n4IrQA1CAD6fCkZItUVRoLPO22X8U3qOYyE2igoFPJKf702Mi9zlpbnvhYfI0pLzuYYu3NUoXJ0BuLGdSXQTFYrHnKYsfEGo18JNtRf/3sonxkGpzsl1tcTDg7V8GE/c6dGfsg3jg7ktD2vnwH+cK5aRgakYrN7x0U2yi61vvo8UF28t41GTC9vvySXFrxl8z9mDEb1Qe0BGB0ZhOcmp0V1FppWm5dPh2cj5gLBXNc1iBE6xNoikNe+9j4BVNAjQ2N4TaxD1yGQymNcrn8yaybq2O4d3pVrK2o4eFi6ksHnVWtNOG5rST6lSr/ClzDoCMW1jwxV2pweXFIRs7oA4RZtZKsNzB5v3D4+xn/g1ml06UztV4NHm3aJlnX8ARf/1ztDadM1mDq4JT7U3ykvg==; 5:91GcETiezkyiRuN9nPn8UHFwbMKtdQRNawDZHvSKCITJKZwQEjD6+sx20RrbwMPdiS58GSzGgvqpekU4eJkI9xrtvEk7GVRcf9i5k6ZfoNrOKWCgy6IJHP2a1qxstpVVqu4gpwflZynpsS9V5MU4XO1UJzpZpHEDWPozVhxKNw4=; 7:doZ/3uVAX8byTt5lapXqPDSmrT5hClCxkK+DEHcbL1q/+7zuz5Tgbeh/u+HjQ0Dw1bPuc1z+cTUvwp0lx4+imCv/RlVOuBIB2tZXc+3eN0vAqk9i9FGEndTrNSmT1lAq6VgopX3d4teMPhzp2oiiA6fhGuBN4Q+gtXaDhZXA0C8+1151gekNTv0D6t5o6B+t+2MZDbH+l9X2lxEst7QliaTvjZ9oq/KvHXxtohhjphJNeLL/Wkmy2dKIbvYpOOeO x-ms-office365-filtering-correlation-id: ae92d58f-6c76-49dc-a479-08d6323fdf58 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0501MB2454; x-ms-traffictypediagnostic: DB6PR0501MB2454: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:DB6PR0501MB2454; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2454; x-forefront-prvs: 0826B2F01B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(39860400002)(396003)(366004)(346002)(199004)(189003)(174874002)(6512007)(5250100002)(186003)(6486002)(386003)(14454004)(26005)(478600001)(256004)(68736007)(2900100001)(305945005)(2906002)(7736002)(25786009)(53936002)(6506007)(86362001)(85306007)(66066001)(105586002)(81156014)(71190400001)(8936002)(52116002)(71200400001)(36756003)(1857600001)(97736004)(8676002)(81166006)(99286004)(6436002)(2616005)(476003)(102836004)(1076002)(110136005)(106356001)(6636002)(4326008)(486006)(6116002)(3846002)(5660300001)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2454; H:DB6PR0501MB2023.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: tADtoKiLsGl8ckVNQ81LGwIO0bM3ikhcszDrTL02AlY4vDMPiBgeg/aFyXTrMH+HIr/1rr9gx8XJssnUZYqOZMH54SMJk5/gzByw9TvcxvNMgL30qv1gjfx38yeBIN3GF51teWDYke6J3fRnuLfKOT/Wylipq4iT/Jm6Kryrd1IKdr6gIdDI/k0ZfwW1XTQhQGsob2EcJIIgBtUqYHcx+fkbrcVN5pxMgNJS5DDsiiLsr/xEaVNp1APYYxqIPwUFUt1CXnp50qBOVCnOFG8paFWbZ5uQ75XjF3veFMFzCs5su5hZvoOpAuznA5ar1foo1skKuIySYsmFDgvoCcw6xg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae92d58f-6c76-49dc-a479-08d6323fdf58 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2018 01:45:23.8148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2454 Subject: [dpdk-dev] [PATCH] net/mlx5: fix compiling issue of zero-size array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 01:45:26 -0000 If the build environment hasn't 'linux/tc_act/tc_pedit.h', compiler will use needed structs defined in mlx5_flow_tcf.c. However, there is a zero-size array defined in one struct and ISO C forbids this when -Wpedantic is set by debug mode. Simply put __extension__ keyword before the struct in question. Fixes: e696b2051c8c ("net/mlx5: rewrite IP address UDP/TCP port by E-Switch= ") Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow_tcf.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_= tcf.c index aaafaf52d..da4bc632d 100644 --- a/drivers/net/mlx5/mlx5_flow_tcf.c +++ b/drivers/net/mlx5/mlx5_flow_tcf.c @@ -93,19 +93,20 @@ enum pedit_cmd { }; =20 struct tc_pedit_key { - __u32 mask; /* AND */ - __u32 val; /*XOR */ - __u32 off; /*offset */ - __u32 at; - __u32 offmask; - __u32 shift; + __u32 mask; /* AND */ + __u32 val; /*XOR */ + __u32 off; /*offset */ + __u32 at; + __u32 offmask; + __u32 shift; }; =20 +__extension__ struct tc_pedit_sel { tc_gen; - unsigned char nkeys; - unsigned char flags; - struct tc_pedit_key keys[0]; + unsigned char nkeys; + unsigned char flags; + struct tc_pedit_key keys[0]; }; =20 #endif /* HAVE_TC_ACT_VLAN */ --=20 2.17.1