From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D451C58EC for ; Wed, 17 Oct 2018 03:54:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7143D220FD; Tue, 16 Oct 2018 21:54:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 16 Oct 2018 21:54:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=dmoITQJ5Xf daVFsITYzAIqrRY518SYAIaM+l/GLe2qc=; b=fvNDJt2wwvEd6Dqz6tgP7IoMjG r2MVEAOG6ZNJuf1qA0IsnFR2C/fLltcDeSCz5Sf3jLB59DYjRK81tgQR+98r3gT7 dVd017j8ZJyOc4LKfpqQD3zbRXSiiNedbfTgEOWpqzc3cyNk7POvzlBmTdfaaIbK GDgdbDYMGx5tbo8eY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=dmoITQJ5XfdaVFsITYzAIqrRY518SYAIaM+l/GLe2qc=; b=DQ+MkB2C PtghZJFptks6JsakYzN0ftZilCoAxjTq+67uVD+qnX2yOrRRuUG8FkACMoTudVwB EdjSPNUxpQybipVhllyMAYFiavtVPUwksENvi2lr0OC41VDrNVDSGqcR4K3pz1mL nfQV37c0KdlmOcr8BAyguZfyL9y7ogWxggUg6PS1lBahgXv1Ur1zYiHv6cAENfdg od5Y8L4f4B+pfXPhAhMgZ5UOfSFZ4UkI66eBZTecmyYlq233GbmIg0UvRqTsomhZ srTmu1OhsajWmXhGupHzwwJwQv/bERzy2i98SJ5yJkH92+66FhId5iEOZ37i9GPA X7bPxZ88lXZg2w== X-ME-Sender: X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 19C3A102DD; Tue, 16 Oct 2018 21:54:49 -0400 (EDT) From: Thomas Monjalon To: ferruh.yigit@intel.com, arybchenko@solarflare.com Cc: dev@dpdk.org, ophirmu@mellanox.com Date: Wed, 17 Oct 2018 03:54:46 +0200 Message-Id: <20181017015450.15783-1-thomas@monjalon.net> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180907233929.21950-1-thomas@monjalon.net> References: <20180907233929.21950-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 0/4] ethdev port freeing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 01:54:51 -0000 The function rte_eth_dev_detach() is freeing a port and its underlying rte_device object. The issue is that we may have several ports associated to the same rte_device. The right replacement is to free the port, and free the rte_device if no more ports. At ethdev level, the public function for port freeing is rte_eth_dev_close(). The only miss is rte_eth_dev_release_port() to free all port resources. This patchset does a cleanup by moving as much ethdev data freeing as possible in an unique function rte_eth_dev_release_port(), and call this function in rte_eth_dev_close(). Changes in v4: - do not free data fields which are not dynamically allocated blocks - remove rte_eth_dev_release_port_secondary() - remove testpmd check to detach without closing Changes in v3: - free queues, MAC addresses and private structure in rte_eth_dev_release_port. Note: this patchset depends on multi-process hotplug series by Qi Zhang, which is accepted but waiting for an unrelated DPAA compilation issue to be fixed, before landing on master tree. Thomas Monjalon (4): app/testpmd: allow detaching a port not closed ethdev: free all common data when releasing port ethdev: remove release function for secondary process ethdev: complete closing of port app/test-pmd/testpmd.c | 22 ++--------- drivers/net/af_packet/rte_eth_af_packet.c | 11 ++++-- drivers/net/ark/ark_ethdev.c | 1 - drivers/net/avf/avf_ethdev.c | 3 -- drivers/net/avp/avp_ethdev.c | 5 --- drivers/net/axgbe/axgbe_ethdev.c | 3 -- drivers/net/bnxt/bnxt_ethdev.c | 8 ---- drivers/net/bonding/rte_eth_bond_pmd.c | 9 +---- drivers/net/cxgbe/cxgbe_main.c | 16 +------- drivers/net/cxgbe/cxgbevf_main.c | 9 +---- drivers/net/dpaa/dpaa_ethdev.c | 10 ----- drivers/net/dpaa2/dpaa2_ethdev.c | 10 ----- drivers/net/e1000/em_ethdev.c | 3 -- drivers/net/e1000/igb_ethdev.c | 6 --- drivers/net/enetc/enetc_ethdev.c | 4 +- drivers/net/failsafe/failsafe.c | 6 ++- drivers/net/failsafe/failsafe_ops.c | 2 + drivers/net/fm10k/fm10k_ethdev.c | 8 ---- drivers/net/i40e/i40e_ethdev.c | 3 -- drivers/net/i40e/i40e_ethdev_vf.c | 3 -- drivers/net/i40e/i40e_vf_representor.c | 5 ++- drivers/net/ixgbe/ixgbe_ethdev.c | 9 ----- drivers/net/ixgbe/ixgbe_vf_representor.c | 5 ++- drivers/net/kni/rte_eth_kni.c | 7 ++-- drivers/net/liquidio/lio_ethdev.c | 3 -- drivers/net/mlx4/mlx4.c | 7 +++- drivers/net/mlx5/mlx5.c | 11 ++++-- drivers/net/mvneta/mvneta_ethdev.c | 16 +++----- drivers/net/mvpp2/mrvl_ethdev.c | 16 +++----- drivers/net/netvsc/hn_ethdev.c | 20 +++------- drivers/net/null/rte_eth_null.c | 7 +--- drivers/net/octeontx/octeontx_ethdev.c | 31 ++++++---------- drivers/net/pcap/rte_eth_pcap.c | 16 ++++---- drivers/net/qede/qede_ethdev.c | 5 --- drivers/net/ring/rte_eth_ring.c | 6 +-- drivers/net/sfc/sfc_ethdev.c | 3 -- drivers/net/softnic/rte_eth_softnic.c | 10 ++--- drivers/net/szedata2/rte_eth_szedata2.c | 1 - drivers/net/tap/rte_eth_tap.c | 11 +++++- drivers/net/vhost/rte_eth_vhost.c | 15 ++------ drivers/net/virtio/virtio_ethdev.c | 3 -- drivers/net/virtio/virtio_user_ethdev.c | 3 -- drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 -- lib/librte_ethdev/rte_ethdev.c | 45 +++++++---------------- lib/librte_ethdev/rte_ethdev.h | 3 +- lib/librte_ethdev/rte_ethdev_driver.h | 25 +++++-------- lib/librte_ethdev/rte_ethdev_pci.h | 17 --------- lib/librte_ethdev/rte_ethdev_version.map | 7 ---- 48 files changed, 129 insertions(+), 323 deletions(-) -- 2.19.0