From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8F87E1B136 for ; Wed, 17 Oct 2018 12:57:42 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 03:57:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,392,1534834800"; d="scan'208";a="92717504" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga003.jf.intel.com with SMTP; 17 Oct 2018 03:57:39 -0700 Received: by (sSMTP sendmail emulation); Wed, 17 Oct 2018 11:57:38 +0100 Date: Wed, 17 Oct 2018 11:57:38 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20181017105737.GA22712@bricha3-MOBL.ger.corp.intel.com> References: <20180827165240.28322-1-bluca@debian.org> <20180828101240.12597-1-bluca@debian.org> <1539770338.25451.7.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1539770338.25451.7.camel@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v6 1/2] bus/pci: harmonize and document rte_pci_read_config return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 10:57:43 -0000 On Wed, Oct 17, 2018 at 10:58:58AM +0100, Luca Boccassi wrote: > On Tue, 2018-08-28 at 11:12 +0100, Luca Boccassi wrote: > > On Linux, rte_pci_read_config on success returns the number of read > > bytes, but on BSD it returns 0. > > Document the return values, and have BSD behave as Linux does. > > > > At least one case (bnx2x PMD) treats 0 as an error, so the change > > makes sense also for that. > > > > Signed-off-by: Luca Boccassi > > --- Acked-by: Bruce Richardson