DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] [pktgen] Fix the compiling with Lua from source
@ 2018-10-17 13:46 Bing Zhao
  0 siblings, 0 replies; only message in thread
From: Bing Zhao @ 2018-10-17 13:46 UTC (permalink / raw)
  To: keith.wiles, dev; +Cc: bing.zhao, Bing Zhao

In some other distributions excpet Ubuntu, the Lua verison is quite old
and some interfaces show incompatible. If manually building Lua version
5.3 from source code. By default, only the static library is generated for
using. Then due to the fact that there is some dependence between
library files and the order of them in the command line should be take
into consideration. "liblua.a" must be after "pktgen_lua.a" if no group
feature is used. Then we can split the pkg-config infomation into two
parts to fix the building in CentOS.

P.S. the name convention of Lua .pc file was discussed serveral years ago,
but it seemed that there is no agreement and each distribution will use
their own name style. When using CentOS, I need to make the .pc file by
myself.

Signed-off-by: Bing Zhao <ilovethull@163.com>
---
 app/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/Makefile b/app/Makefile
index 3949e51..a78ea7d 100644
--- a/app/Makefile
+++ b/app/Makefile
@@ -89,8 +89,8 @@ endif
 
 ifeq ($(CONFIG_RTE_LIBRTE_LUA),y)
 else
-MYLIBS     += -lpktgen_lua
-MYLIB_PATH += -L$(LUA_LIB) $(shell pkg-config --libs lua5.3)
+MYLIBS     += -lpktgen_lua $(shell pkg-config --libs-only-l lua5.3)
+MYLIB_PATH += -L$(LUA_LIB) $(shell pkg-config --libs-only-L lua5.3)
 
 CFLAGS     += -I/usr/include/lua5.3
 CFLAGS     += -I$(RTE_SRCDIR)/../lib/lua/
-- 
2.11.0.windows.1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-10-17 13:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-17 13:46 [dpdk-dev] [PATCH] [pktgen] Fix the compiling with Lua from source Bing Zhao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).