DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] devargs: fix variadic parsing memory leak
@ 2018-10-17 14:30 Gaetan Rivet
  2018-10-25  6:53 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Gaetan Rivet @ 2018-10-17 14:30 UTC (permalink / raw)
  To: dev; +Cc: Gaetan Rivet, stable

rte_devargs_parsef will leak memory each time it is called.
The device string must be freed.

Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function")
CC: stable@dpdk.org
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
 lib/librte_eal/common/eal_common_devargs.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c
index 69e9e32e9..c1b06095e 100644
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -237,6 +237,7 @@ rte_devargs_parsef(struct rte_devargs *da, const char *format, ...)
 	va_list ap;
 	size_t len;
 	char *dev;
+	int ret;
 
 	if (da == NULL)
 		return -EINVAL;
@@ -255,7 +256,10 @@ rte_devargs_parsef(struct rte_devargs *da, const char *format, ...)
 	vsnprintf(dev, len + 1, format, ap);
 	va_end(ap);
 
-	return rte_devargs_parse(da, dev);
+	ret = rte_devargs_parse(da, dev);
+
+	free(dev);
+	return ret;
 }
 
 int __rte_experimental
-- 
2.19.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v1] devargs: fix variadic parsing memory leak
  2018-10-17 14:30 [dpdk-dev] [PATCH v1] devargs: fix variadic parsing memory leak Gaetan Rivet
@ 2018-10-25  6:53 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-10-25  6:53 UTC (permalink / raw)
  To: Gaetan Rivet; +Cc: stable, dev

17/10/2018 16:30, Gaetan Rivet:
> rte_devargs_parsef will leak memory each time it is called.
> The device string must be freed.
> 
> Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function")
> CC: stable@dpdk.org
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-25  6:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-17 14:30 [dpdk-dev] [PATCH v1] devargs: fix variadic parsing memory leak Gaetan Rivet
2018-10-25  6:53 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).