* [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message
@ 2018-10-18 22:34 Stephen Hemminger
2018-10-18 23:19 ` Van Haaren, Harry
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2018-10-18 22:34 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
examples/vdpa/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
index c5e8f58ec6d2..2ffbf2d8b4a3 100644
--- a/examples/vdpa/main.c
+++ b/examples/vdpa/main.c
@@ -334,7 +334,7 @@ static void cmd_create_vdpa_port_parsed(void *parsed_result,
addr.type = PCI_ADDR;
did = rte_vdpa_find_device_id(&addr);
if (did < 0) {
- cmdline_printf(cl, "Unable to find vdpa devide id.\n");
+ cmdline_printf(cl, "Unable to find vdpa divide id.\n");
return;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message
2018-10-18 22:34 [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message Stephen Hemminger
@ 2018-10-18 23:19 ` Van Haaren, Harry
2018-10-19 17:20 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: Van Haaren, Harry @ 2018-10-18 23:19 UTC (permalink / raw)
To: Stephen Hemminger, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Thursday, October 18, 2018 3:35 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> examples/vdpa/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
> index c5e8f58ec6d2..2ffbf2d8b4a3 100644
> --- a/examples/vdpa/main.c
> +++ b/examples/vdpa/main.c
> @@ -334,7 +334,7 @@ static void cmd_create_vdpa_port_parsed(void
> *parsed_result,
> addr.type = PCI_ADDR;
> did = rte_vdpa_find_device_id(&addr);
> if (did < 0) {
> - cmdline_printf(cl, "Unable to find vdpa devide id.\n");
> + cmdline_printf(cl, "Unable to find vdpa divide id.\n");
<nit>
I'd guess this fix was meant to be "device" not "divide".
</nit>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message
2018-10-18 23:19 ` Van Haaren, Harry
@ 2018-10-19 17:20 ` Stephen Hemminger
2018-10-22 13:53 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2018-10-19 17:20 UTC (permalink / raw)
To: Van Haaren, Harry; +Cc: dev
On Thu, 18 Oct 2018 23:19:18 +0000
"Van Haaren, Harry" <harry.van.haaren@intel.com> wrote:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Thursday, October 18, 2018 3:35 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > Subject: [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > examples/vdpa/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
> > index c5e8f58ec6d2..2ffbf2d8b4a3 100644
> > --- a/examples/vdpa/main.c
> > +++ b/examples/vdpa/main.c
> > @@ -334,7 +334,7 @@ static void cmd_create_vdpa_port_parsed(void
> > *parsed_result,
> > addr.type = PCI_ADDR;
> > did = rte_vdpa_find_device_id(&addr);
> > if (did < 0) {
> > - cmdline_printf(cl, "Unable to find vdpa devide id.\n");
> > + cmdline_printf(cl, "Unable to find vdpa divide id.\n");
>
> <nit>
> I'd guess this fix was meant to be "device" not "divide".
> </nit>
Damn you autocorrect...
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message
2018-10-19 17:20 ` Stephen Hemminger
@ 2018-10-22 13:53 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2018-10-22 13:53 UTC (permalink / raw)
To: Stephen Hemminger, Van Haaren, Harry; +Cc: dev
On 10/19/2018 6:20 PM, Stephen Hemminger wrote:
> On Thu, 18 Oct 2018 23:19:18 +0000
> "Van Haaren, Harry" <harry.van.haaren@intel.com> wrote:
>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
>>> Sent: Thursday, October 18, 2018 3:35 PM
>>> To: dev@dpdk.org
>>> Cc: Stephen Hemminger <stephen@networkplumber.org>
>>> Subject: [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message
>>>
>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>> ---
>>> examples/vdpa/main.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
>>> index c5e8f58ec6d2..2ffbf2d8b4a3 100644
>>> --- a/examples/vdpa/main.c
>>> +++ b/examples/vdpa/main.c
>>> @@ -334,7 +334,7 @@ static void cmd_create_vdpa_port_parsed(void
>>> *parsed_result,
>>> addr.type = PCI_ADDR;
>>> did = rte_vdpa_find_device_id(&addr);
>>> if (did < 0) {
>>> - cmdline_printf(cl, "Unable to find vdpa devide id.\n");
>>> + cmdline_printf(cl, "Unable to find vdpa divide id.\n");
>>
>> <nit>
>> I'd guess this fix was meant to be "device" not "divide".
>> </nit>
>
> Damn you autocorrect...
>
Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for vDPA")
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
(used suggested fix by Harry)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-22 13:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18 22:34 [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message Stephen Hemminger
2018-10-18 23:19 ` Van Haaren, Harry
2018-10-19 17:20 ` Stephen Hemminger
2018-10-22 13:53 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).