From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 528241B481 for ; Fri, 19 Oct 2018 11:45:46 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id a8-v6so3053795wmf.1 for ; Fri, 19 Oct 2018 02:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E97swbqyfTKbscuB2dOQa9RZVQZldh45ilEhNWiKPfY=; b=OkV2MvIsaMGI+kOsPqlD7fmKbgIZcraKv5sZ6s8J9YxxMz4aQs+yGi2eB9iKRJGi6X +SzEhzxwume7K0EtTneUt5St26HDEw4/kU6ZV4f90FHAxzBfUzj1cbwXwAAyU5/bhRQ/ 5112n+TZie5NOkwIBXsNpo14AvUXU9F8hRWtyZ1vAd6gmIOOAJU7LPHfa8jBpMJ+ohBf qx33gQZRDtDehcG5uJ/ALQ0ipvhoAT+vthc6oVnI5gps0Bss+1rFtnPLInvzo7v8m540 rgG2chRGKjyqRbY2x/bGGu1MU+N9tZfXEhMDVCDcpGSSvD+jFtOaLnofLJ/gUA5RwJDK S2Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E97swbqyfTKbscuB2dOQa9RZVQZldh45ilEhNWiKPfY=; b=XRWbO+RGV5oHah/GzKRggvnkNwSlIXy4oZ9A3JhUvL1ZRoSHZPFOQi19Kij+O0ryrJ tpn1t+xmOyUz1viKfu3CIHCqy3NLTgztHvEJQEJyA0TeXseSh7HfCf9ojmS2Exs5P16D 2q2kOz58pu4EA6Fzx+uIt3roBZ5i59XQlEzhtnVn1c4BmVb0pSx45E1d3+navHjvUiw2 kEiMa1Ye9JljHBHwXtFRMC5/FlukSHGvq7zbeCywetmtpYM/XvGY2zI95rqpiqPfJvWN casCj/wjSpKNFQ3dyS9srWyuU1PX6zKdM+iiVxW3cDNTQM5GuCVD4dPHa/wGUiZtbKMJ yHuA== X-Gm-Message-State: ABuFfoioqPohA3tzb+8WI7zVwb8dZiKVeI4UXGQoZc/ppjEW8Z6bTA7m HLTpJteVJgTMTrovhwx3XKyDb+tpPNU= X-Google-Smtp-Source: ACcGV63DMM7J+t3pBDJ2gZbnnbcUAM3BAZk+itwWv+UWauGrsXPytST/ofdhtSrda/pSRUjTz9kzOg== X-Received: by 2002:a1c:1a52:: with SMTP id a79-v6mr4079611wma.119.1539942345897; Fri, 19 Oct 2018 02:45:45 -0700 (PDT) Received: from cougar.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 143-v6sm4180081wmv.6.2018.10.19.02.45.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Oct 2018 02:45:45 -0700 (PDT) From: Huaibin Wang To: dev@dpdk.org Cc: Beilei Xing , Qi Zhang , huaibin Wang , Laurent Hardy Date: Fri, 19 Oct 2018 11:45:21 +0200 Message-Id: <20181019094521.7069-1-huaibin.wang@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181016032737.28869-1-huaibin.wang@6wind.com> References: <20181016032737.28869-1-huaibin.wang@6wind.com> Subject: [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2018 09:45:46 -0000 From: huaibin Wang Promisc should not be disabled if the all multicast mode is enabled. Patch keeps the promiscuous on if all multicast mode is on, this behavior is also consistent with the implementation done on ixgbe pmd. Signed-off-by: huaibin Wang Signed-off-by: Laurent Hardy --- Cc: Beilei Xing Cc: Qi Zhang drivers/net/i40e/i40e_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index f7a685c8c..6c503debc 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous"); + /* must remain in all_multicast mode */ + if (dev->data->all_multicast == 1) + return; + status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid, false, NULL); if (status != I40E_SUCCESS) -- 2.11.0