From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Liang Ma <liang.j.ma@intel.com>
Subject: Re: [dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script issue
Date: Fri, 19 Oct 2018 07:38:16 -0400 [thread overview]
Message-ID: <20181019113815.GA30254@hmswarspite.think-freely.org> (raw)
In-Reply-To: <5107033.R7BcetJnk1@xps>
On Fri, Oct 19, 2018 at 12:48:57PM +0200, Thomas Monjalon wrote:
> Hi Neil,
>
> Are you OK with this patch?
>
>
> 04/10/2018 17:18, Liang Ma:
> > There is a issue inside check-symbol-changes.sh awk script.
> > When the script try to parse the section name from patch,
> > The script put char "+" into the section name.
> >
> > Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> > ---
> > devtools/check-symbol-change.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> > index c0d2a6d..4a0f4d8 100755
> > --- a/devtools/check-symbol-change.sh
> > +++ b/devtools/check-symbol-change.sh
> > @@ -30,7 +30,7 @@ build_map_changes()
> > # the rest of the line with the + and { symbols remvoed.
> > # Triggering this rule sets in_sec to 1, which actives the
> > # symbol rule below
> > - /^.*{/ {
> > + /^[^-+]*{/ {
> > if (in_map == 1) {
> > sec=$(NF-1); in_sec=1;
> > }
>
>
>
>
I don't think so. The section name might get a + in front of it on lines like
this:
+EXPERIMENTAL {
But the above change just skips matching on it, which I don't think is what we
want. The right fix I think would be to match on it, then strip the leading
plus with a sed operation in the body of the match rule.
Neil
next prev parent reply other threads:[~2018-10-19 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 15:18 Liang Ma
2018-10-19 10:48 ` Thomas Monjalon
2018-10-19 11:38 ` Neil Horman [this message]
2018-10-19 13:09 ` Liang, Ma
2018-10-19 20:32 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019113815.GA30254@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=liang.j.ma@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).