From: Ali Alnubani <alialnu@mellanox.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>
Subject: [dpdk-dev] [PATCH] test/test_external_mem: fix loop initialization
Date: Tue, 23 Oct 2018 07:35:50 +0000 [thread overview]
Message-ID: <20181023073535.16441-1-alialnu@mellanox.com> (raw)
Loop initial declarations are only allowed in C99 mode,
which causes a compilation failure on non C99 compliant systems:
test/test/test_external_mem.c: In function ‘test_external_mem’:
test/test/test_external_mem.c:375:2: error: ‘for’
loop initial declarations are only allowed in C99 mode
for (int i = 0; i < n_pages; i++) {
^
Reproduces on RHEL 7.4 with GCC 4.8.5 20150623 (Red Hat 4.8.5-16).
Fixes: b270daa43b3d ("test: support external memory")
Cc: anatoly.burakov@intel.com
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
test/test/test_external_mem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/test/test_external_mem.c b/test/test/test_external_mem.c
index d0837aa35..d740960ce 100644
--- a/test/test/test_external_mem.c
+++ b/test/test/test_external_mem.c
@@ -361,7 +361,7 @@ test_external_mem(void)
size_t pgsz = RTE_PGSIZE_4K;
rte_iova_t iova[len / pgsz];
void *addr;
- int ret, n_pages;
+ int ret, n_pages, i;
/* create external memory area */
n_pages = RTE_DIM(iova);
@@ -372,7 +372,7 @@ test_external_mem(void)
__func__, __LINE__);
return -1;
}
- for (int i = 0; i < n_pages; i++) {
+ for (i = 0; i < n_pages; i++) {
/* arbitrary IOVA */
rte_iova_t tmp = 0x100000000 + i * pgsz;
iova[i] = tmp;
--
2.19.1
next reply other threads:[~2018-10-23 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 7:35 Ali Alnubani [this message]
2018-10-23 9:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023073535.16441-1-alialnu@mellanox.com \
--to=alialnu@mellanox.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).