From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id ECEF85B38 for ; Tue, 23 Oct 2018 10:28:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 71C522200D; Tue, 23 Oct 2018 04:28:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 23 Oct 2018 04:28:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=0nTSHiC4km 7uWbxB0m7l8c6fSoCf18epch/sZwMWiI0=; b=WVVH90Kwy5RKdko+tEMOObrwHd 1aTIwUCjV5LQKC2HWIo6WsxAQeiHe6ZH6okQxhjf4sLL1/d4xFa1sXYHhz7pAIXO 0U4jk6pbqzRfwMqdq0VASVauUDyeGVHU8dS3H7YTn9L0QI1UGfx55xb8Cnt0Lzq+ oyZ1eHNjLPMjGSeuM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=0nTSHiC4km7uWbxB0m7l8c6fSoCf18epch/sZwMWiI0=; b=L94GM0A+ CZ76MC+OC/tmGSw8bVnxvbGw2fAcxnLS2VWwwLiN8W1RX9am8vikFwX7w/PmeBJ1 wUsjJyAvyKyEB4o6TpL8Lg658YMwHyc5MX1DT3wT9FXhZGo9W4HfOO0pRiPmL7Wh LHZKEkudE1vYDdOYV1yjt9f7dG2pgN1MgXigvMTfron+k6oEbl+/ebzhW1waiLth FDzrRTzLmbjJlM5Eykryw1NVpFvlq/VQkNYkPxXTh5eWwzJHWIXNqSSJU4FlB9KB 8Tn1UeziFi9qqbFCQ2MKiWUs2u0KC7TBsy5UmjDorfs1oSd4vxOSk25fG14tncJH VgU4fldXHmgVIA== X-ME-Sender: X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 17165E484F; Tue, 23 Oct 2018 04:28:42 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, wisamm@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, bernard.iremonger@intel.com Date: Tue, 23 Oct 2018 10:28:35 +0200 Message-Id: <20181023082842.7963-1-thomas@monjalon.net> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181007222554.4886-1-thomas@monjalon.net> References: <20181007222554.4886-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v7 0/7] replace attach/detach functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 08:28:45 -0000 The functions for EAL attach/detach had already some replacements, so they are removed. The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs. rte_eth_dev_attach(devargs, &port_id) is replaced by: rte_dev_probe(devargs); RTE_ETH_FOREACH_MATCHING_DEV(port_id, devargs, &iterator) { do what you want with the new port_id } The biggest benefit is to be able to manage devargs string matching several ports to probe. Changes in v7: - remove use of eth_dev->data->name after detach in testpmd Changes in v6: - improve testpmd logs - update testpmd port_status when detaching multiple ports Changes in v5: - check double detach in testpmd Changes in v4: - fix compilation (due to stricter checks in v3) Changes in v3 - after Andrew's review: - coding rules compliance - stricter checks for snprintf - rte_eth_iterator_free() becomes rte_eth_iterator_cleanup() - add rte_eth_iterator_cleanup in .map Changes in v2 - after Andrew's review: - return only 0 or -1 in vdev_dev_match() - fix freeing of strings in the iterator - add rte_eth_iterator_free() - tolerate extra parameters from old syntax - add more comments - separate contributing guide patch Thomas Monjalon (7): bus/vdev: add iteration filter on name ethdev: add iterator to match devargs input ethdev: allow iterating with pure class filter doc: replace doxygen example in contribution guide ethdev: remove deprecated attach/detach functions eal: remove deprecated attach/detach functions app/testpmd: check not detaching device twice app/test-pmd/testpmd.c | 42 +++- doc/guides/contributing/documentation.rst | 15 +- doc/guides/prog_guide/index.rst | 1 - .../prog_guide/port_hotplug_framework.rst | 106 --------- doc/guides/rel_notes/deprecation.rst | 12 - doc/guides/rel_notes/release_18_11.rst | 12 + drivers/bus/vdev/vdev_params.c | 19 +- drivers/net/virtio/virtio_user_ethdev.c | 1 - lib/librte_eal/common/eal_common_dev.c | 53 ----- lib/librte_eal/common/include/rte_common.h | 6 + lib/librte_eal/common/include/rte_dev.h | 27 --- lib/librte_eal/rte_eal_version.map | 2 - lib/librte_ethdev/ethdev_private.c | 10 +- lib/librte_ethdev/ethdev_private.h | 6 + lib/librte_ethdev/rte_class_eth.c | 9 +- lib/librte_ethdev/rte_ethdev.c | 223 +++++++++++------- lib/librte_ethdev/rte_ethdev.h | 110 ++++++--- lib/librte_ethdev/rte_ethdev_version.map | 5 +- 18 files changed, 321 insertions(+), 338 deletions(-) delete mode 100644 doc/guides/prog_guide/port_hotplug_framework.rst -- 2.19.0