From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EDB7E1B486 for ; Tue, 23 Oct 2018 12:30:10 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 03:30:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,415,1534834800"; d="scan'208";a="80222961" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga007.fm.intel.com with SMTP; 23 Oct 2018 03:30:07 -0700 Received: by (sSMTP sendmail emulation); Tue, 23 Oct 2018 11:30:06 +0100 Date: Tue, 23 Oct 2018 11:30:06 +0100 From: Bruce Richardson To: Honnappa Nagarahalli Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org, yipeng1.wang@intel.com, gavin.hu@arm.com, dharmik.thakkar@arm.com, nd@arm.com Message-ID: <20181023103005.GB18800@bricha3-MOBL.ger.corp.intel.com> References: <1540268524-126673-1-git-send-email-honnappa.nagarahalli@arm.com> <1540268524-126673-3-git-send-email-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1540268524-126673-3-git-send-email-honnappa.nagarahalli@arm.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v5 2/5] hash: support do not free on delete X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 10:30:11 -0000 On Mon, Oct 22, 2018 at 11:22:01PM -0500, Honnappa Nagarahalli wrote: > rte_hash_lookup_xxx APIs return the index of slot in > the key store. Application(reader) can use that index to reference > other data structures in its scope. Because of this, the > index should not be freed till the application completes > using the index. > RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is introduced to support this. > When this flag is enabled rte_hash_del_xxx APIs do not free the > key-store index/internal memory associated with the deleted > entry. The new API rte_hash_free_key_with_position should be called > to free the key-store index/internal memory after calling > rte_hash_del_xxx APIs. > > Suggested-by: Yipeng Wang > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > Reviewed-by: Yipeng Wang > --- As before, fix email in reviewed-by. Acked-by: Bruce Richardson