From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 706231B518 for ; Tue, 23 Oct 2018 16:21:04 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 07:21:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,416,1534834800"; d="scan'208";a="102590466" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga002.jf.intel.com with SMTP; 23 Oct 2018 07:21:00 -0700 Received: by (sSMTP sendmail emulation); Tue, 23 Oct 2018 15:20:59 +0100 Date: Tue, 23 Oct 2018 15:20:58 +0100 From: Bruce Richardson To: Honnappa Nagarahalli Cc: "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "yipeng1.wang@intel.com" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , nd Message-ID: <20181023142058.GA4496@bricha3-MOBL.ger.corp.intel.com> References: <1540268524-126673-1-git-send-email-honnappa.nagarahalli@arm.com> <1540268524-126673-6-git-send-email-honnappa.nagarahalli@arm.com> <20181023115403.GE18800@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 14:21:05 -0000 On Tue, Oct 23, 2018 at 02:15:30PM +0000, Honnappa Nagarahalli wrote: > Hi Bruce, > Thank you for the review. > > > > - hash lookup on existing keys NOT likely to be on shift-path with: > > > - hash add causing key-shifts of existing keys in the table > > > > > > - hash lookup on non-existing keys with: > > > - hash add causing NO key-shifts of existing keys in the table > > > - hash add causing key-shifts of existing keys in the table > > > > > > - hash lookup on keys likely to be on shift-path with: > > > - multiple writers causing key-shifts of existing keys in the table > > > > > > Signed-off-by: Dharmik Thakkar > > > Reviewed-by: Honnappa Nagarahalli > > > Reviewed-by: Gavin Hu > > > Reviewed-by: Yipeng Wang > > > --- > > > > Does this need to be done via a completely new test case? Given the number > > of unit tests for the hash table structure, I'm wondering if we can consolidate > > things a bit. Any thoughts? > > > Are you concerned about new test case or new test case file? > From a new test case perspective, we are testing a new use case, hence we need it. May be few parts can be combined such as generating the keys. > From a new test case file perspective, combining this use case with existing files was making the code difficult to manage. Hence we decided to add a new file. > > There are more test cases because of multiple configuration options present in hash table. > Ok. That makes sense. Can you fix the couple of missing items for make/meson in this patch, then you can add my ack. Acked-by: Bruce Richardson