From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10086.outbound.protection.outlook.com [40.107.1.86]) by dpdk.org (Postfix) with ESMTP id 9F52A1B3EA for ; Tue, 23 Oct 2018 18:52:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SqDAQJN/teR0HCHF5Fk7w2GGTOVsrL8xiKvTsNaVcm0=; b=v7uf2H9CWdkZcTrdC+5pEtBXEPLvLHXcB6OtsmeGaLBvsv9DadGWkaaNBfs+pwMJC0ySmW3DgV0sP4c62jYxzmMhhOUQDJYFeWruFvRJiAY6VpcwtzLQ8zVQWQw39F258j6E7WP76J6pUGpg/eqRi/ChuMFi1QS/ZGo4YL/6aHA= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3995.eurprd05.prod.outlook.com (52.134.72.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.20; Tue, 23 Oct 2018 16:52:09 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::f8a1:fcab:94f0:97cc]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::f8a1:fcab:94f0:97cc%4]) with mapi id 15.20.1250.028; Tue, 23 Oct 2018 16:52:09 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" , Yongseok Koh , Ori Kam Thread-Topic: [PATCH v2 1/5] net/mlx5: add warning message for Direct Verbs flow Thread-Index: AQHUavC8AmWmxeiEkUSeOtscF5Vf/Q== Date: Tue, 23 Oct 2018 16:52:09 +0000 Message-ID: <20181023165200.2454-2-yskoh@mellanox.com> References: <20181017020739.11203-1-yskoh@mellanox.com> <20181023165200.2454-1-yskoh@mellanox.com> In-Reply-To: <20181023165200.2454-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR08CA0009.namprd08.prod.outlook.com (2603:10b6:a03:100::22) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB3995; 6:tlLPWpvomhEzGcPfqG7MImHGk7zs2sOVc7ZEq1Ix67pOVG5a4V4oCi4ZeuQEAKj1AVzmlDqnJDptRk/DwsDdx9Oyn/rNdJJ8vOKMTSs0lLwjEd82xu+jyXCVbzV9p84vKWGHPr/rWZ33QJv0NJTn5o0OF+mT1oVT9nRbV9NhyRwxShjx26k0NGLYMdiN5oCgIqfbg0t2h+M6SI1p9j714G2w0y24E44G8mxVCoDuj6pY0qQmNTdOzx0NDXo9P4ai6PGDlhMtYyH75DML7FQZVzODk/kKEyLNDqawzohQu3aMlWwKnZ5bMCJNYBk/FXdmnX48SsKtI6E4eECUYLONT/+2kENThu7ImuAGjR631uiMEQ/iLQzXx4FDsJ/RwQ0ORCzSkW55CVpJ1yxuePoI34YgftfjNPwQldcoKv+d93EyPiXbhsgXnkaSS/w1NF6oD6b1CeLaptXGaiuFWu3evA==; 5:SLC221FKMTXTcK5Fi2LEtpT2qY/Ngxq8X88EimkLVGt/LvxrpHmMmKefJX3JlMg/ntTm1ecn8RRNLlqlpWpWGa7NupoJD8170hDjB8BFkOcQir5MED+/VpplRBo6nbpTm6aNe9yD3W3RQPiqcwW830IkyYHGFBAH+A7ER55yXTs=; 7:g7oELqqTK2e2nWbkY8WtqihTBValodxKKbNpAWmSXDYS4taYv9P3vLQ/fZ8NjJlTylwoOTHKivAbwleECxXV/ydG6dgHJlZ5zV9ADCwtPdU82AlkjkO5vkogwVpsb6qfNuPOvDDEWsac7shPSsxIazRppci4zSw9gFzV/ty9awW80uaXTYIB/oDuKKbJeMBpOYNl8mMymKn9QXb4h5kjKKHq6qMwBFTQ6igC5A6SPWERH1QIHT62kWaYcaJGJgco x-ms-office365-filtering-correlation-id: 872a0381-7333-434b-28a7-08d63907df44 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3995; x-ms-traffictypediagnostic: DB3PR0502MB3995: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:DB3PR0502MB3995; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3995; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(376002)(366004)(136003)(199004)(189003)(54906003)(105586002)(8936002)(6116002)(11346002)(5660300001)(26005)(106356001)(66066001)(2616005)(3846002)(6636002)(446003)(6486002)(53936002)(1076002)(6512007)(71200400001)(186003)(97736004)(52116002)(478600001)(99286004)(71190400001)(76176011)(107886003)(102836004)(4326008)(25786009)(2900100001)(14444005)(256004)(386003)(6436002)(6506007)(14454004)(86362001)(2906002)(15650500001)(486006)(37006003)(476003)(68736007)(305945005)(8676002)(81166006)(6862004)(36756003)(316002)(81156014)(5250100002)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3995; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /CuEnOiaM3bTVGBzSAb5DfjnXvG4+csgKS7LEetwlWLxWDWvesDmKYFPd4ee1IQIWj4v3S6if0bgs8+ATIrkc/lRcaL8ioJmdginfjssqE4LjNhok7E25ILqNQjqWYaPpvbAdJWY0OPW9YktdNC2c1N56yfKiL81AANBOjqZlCISog43l8Gc8pE8VQrNPN8J5w04fdwRQylL8oXJYk7HRlgbMdJ7Y88LM+3uNF8H+vGEnEG7YvgIMGsv3dn4YPow7fGXV06ultnYKrirxi7KHt4DY37kVq8fhtk3zMC8EqmjsWMjD3Ecn2g9/uOsIHW5gxo/BJU5LD1YWXZvXo99a1MXfm2g+OW1/yYUTdVdqoQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 872a0381-7333-434b-28a7-08d63907df44 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 16:52:09.5476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3995 Subject: [dpdk-dev] [PATCH v2 1/5] net/mlx5: add warning message for Direct Verbs flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 16:52:10 -0000 In case that the library doesn't support DV flow, if enabled by 'dv_flow_en=3D1', print out a warning message and disable it. Fixes: 51e72d386c99 ("net/mlx5: add runtime parameter to enable Direct Verb= s") Cc: orika@mellanox.com Signed-off-by: Yongseok Koh Acked-by: Ori Kam --- drivers/net/mlx5/mlx5.c | 6 ++++++ drivers/net/mlx5/mlx5_flow.c | 20 +++++++------------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 97be494de9..10a724e944 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1016,6 +1016,12 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, cs_desc.counter_type, cs_desc.num_of_cs, cs_desc.attributes); #endif +#ifndef HAVE_IBV_FLOW_DV_SUPPORT + if (config.dv_flow_en) { + DRV_LOG(WARNING, "DV flow is not supported"); + config.dv_flow_en =3D 0; + } +#endif config.ind_table_max_size =3D attr.rss_caps.max_rwq_indirection_table_size; /* diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index df5c34e81c..6219c9d68a 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1685,25 +1685,19 @@ const struct mlx5_flow_driver_ops mlx5_flow_null_dr= v_ops =3D { * Pointer to the flow attributes. * * @return - * flow driver type if supported, MLX5_FLOW_TYPE_MAX otherwise. + * flow driver type, MLX5_FLOW_TYPE_MAX otherwise. */ static enum mlx5_flow_drv_type -flow_get_drv_type(struct rte_eth_dev *dev __rte_unused, - const struct rte_flow_attr *attr) +flow_get_drv_type(struct rte_eth_dev *dev, const struct rte_flow_attr *att= r) { - struct priv *priv __rte_unused =3D dev->data->dev_private; + struct priv *priv =3D dev->data->dev_private; enum mlx5_flow_drv_type type =3D MLX5_FLOW_TYPE_MAX; =20 - if (attr->transfer) { + if (attr->transfer) type =3D MLX5_FLOW_TYPE_TCF; - } else { -#ifdef HAVE_IBV_FLOW_DV_SUPPORT - type =3D priv->config.dv_flow_en ? MLX5_FLOW_TYPE_DV : - MLX5_FLOW_TYPE_VERBS; -#else - type =3D MLX5_FLOW_TYPE_VERBS; -#endif - } + else + type =3D priv->config.dv_flow_en ? MLX5_FLOW_TYPE_DV : + MLX5_FLOW_TYPE_VERBS; return type; } =20 --=20 2.11.0