DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Change ether_addr to avoid conflict
@ 2018-10-24 12:35 Lewis Donzis
  2018-10-24 16:11 ` Stephen Hemminger
  0 siblings, 1 reply; 5+ messages in thread
From: Lewis Donzis @ 2018-10-24 12:35 UTC (permalink / raw)
  To: dev

Please consider changing "struct ether_addr" in rte_ether.h to "struct rte_ether_addr", in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h.

Sometimes, there is need to include /usr/include/net/ethernet.h, but it conflicts with the same structure name in rte_ether.h.  Was there a reason this structure wasn't given the standard rte_ prefix?

Thanks,
lew

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] Change ether_addr to avoid conflict
  2018-10-24 12:35 [dpdk-dev] Change ether_addr to avoid conflict Lewis Donzis
@ 2018-10-24 16:11 ` Stephen Hemminger
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2018-10-24 16:11 UTC (permalink / raw)
  To: Lewis Donzis; +Cc: dev

On Wed, 24 Oct 2018 07:35:28 -0500
Lewis Donzis <lew@perftech.com> wrote:

> Please consider changing "struct ether_addr" in rte_ether.h to "struct rte_ether_addr", in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h.
> 
> Sometimes, there is need to include /usr/include/net/ethernet.h, but it conflicts with the same structure name in rte_ether.h.  Was there a reason this structure wasn't given the standard rte_ prefix?
> 
> Thanks,
> lew

Only history, remember EAL was first running on bare metal.

Changing to 'struct rte_ether_addr' breaks source of lots of applications.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] Change ether_addr to avoid conflict
  2018-10-22 15:06 ` Wiles, Keith
@ 2018-10-23  8:37   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-10-23  8:37 UTC (permalink / raw)
  To: Lewis Donzis; +Cc: dev, Wiles, Keith

22/10/2018 17:06, Wiles, Keith:
> 
> > On Oct 21, 2018, at 8:39 AM, Lewis Donzis <lew@perftech.com> wrote:
> > 
> > Please consider changing “struct ether_addr” in rte_ether.h to “struct rte_ether_addr”, in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h.
> > 
> > This is kind of a pain for us since we would like to include ethernet.h in order to get some other definitions, but we can’t because it conflicts with the same structure name in rte_ether.h.
> 
> I agree, but it will require a deprecation notice as a lot of code uses it.

Yes, it is a very long standing issue.

During the last technical board meeting, we discussed a plan to fix it:
	http://mails.dpdk.org/archives/dev/2018-October/116695.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] Change ether_addr to avoid conflict
  2018-10-21 15:39 Lewis Donzis
@ 2018-10-22 15:06 ` Wiles, Keith
  2018-10-23  8:37   ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Wiles, Keith @ 2018-10-22 15:06 UTC (permalink / raw)
  To: Lewis Donzis; +Cc: dpdk-dev



> On Oct 21, 2018, at 8:39 AM, Lewis Donzis <lew@perftech.com> wrote:
> 
> Please consider changing “struct ether_addr” in rte_ether.h to “struct rte_ether_addr”, in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h.
> 
> This is kind of a pain for us since we would like to include ethernet.h in order to get some other definitions, but we can’t because it conflicts with the same structure name in rte_ether.h.

I agree, but it will require a deprecation notice as a lot of code uses it.

> 
> Thanks,
> lew

Regards,
Keith


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] Change ether_addr to avoid conflict
@ 2018-10-21 15:39 Lewis Donzis
  2018-10-22 15:06 ` Wiles, Keith
  0 siblings, 1 reply; 5+ messages in thread
From: Lewis Donzis @ 2018-10-21 15:39 UTC (permalink / raw)
  To: dev

Please consider changing “struct ether_addr” in rte_ether.h to “struct rte_ether_addr”, in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h.

This is kind of a pain for us since we would like to include ethernet.h in order to get some other definitions, but we can’t because it conflicts with the same structure name in rte_ether.h.

Thanks,
lew

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-10-24 16:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 12:35 [dpdk-dev] Change ether_addr to avoid conflict Lewis Donzis
2018-10-24 16:11 ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2018-10-21 15:39 Lewis Donzis
2018-10-22 15:06 ` Wiles, Keith
2018-10-23  8:37   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).