From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 75739683E for ; Wed, 24 Oct 2018 18:13:26 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id a5-v6so1647497pgt.13 for ; Wed, 24 Oct 2018 09:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7NnBZS89JBvjkpAtHeaU9Rc5X3Lv6rzz/7hfxzr3FTE=; b=tsqXccnzTwMGTX4vHJ8pXXJMPv0PSwpJU3UNe6NW8i+jRYeeHzcKNGmToufo0fRYde zb6bQahFO2MevenLXL4SLQ4O3J6ELtNPWzoaMaOdOvxKRXTeQuDgsru16xuPBlsfKQ/P k/UDRkQLHos3TYHeogqscImUqaKbwX4GgCYhDuYAdTQgINpBP2qxOWPH5GbOp+PRQIc2 GgIYgJ1h+ZwdmA+frsAyTiH3eAEt92HnawIXTXY6rmdBebovaeXF824TYHGLssAT0nYg Fc9ujj1YgjjGsWbRBzKPEAMjn8ec1vkDaQ6Az6xP8cjCdu1kTVLcjbGow107lLyGJEQ2 DY9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7NnBZS89JBvjkpAtHeaU9Rc5X3Lv6rzz/7hfxzr3FTE=; b=XD+ETWOiVJ8ANND26nV2kyqfI8rbi1wBjx05Rw//WfrDzqJCZZqt+96kNpPPtIKzyx aaS8f0mQtJ/9n5Wr1VdFS3XkdqsYnEnaQ5JHHq78elaEdpJO0yX0/pvXh/GxGxTlvWxg QRVojNZjkdrrq1ppN11JQ7Cjv5zq7WPVPXxXr7BDcJdv+UqEmaWaxQAH2+ITy0H/NiHc 6Cd/gZMjrIUcC7vvu3VQF/EoJjsNKr/aTa0XBN7sY0BtomU5qR1S3lQN5NLuwXaabZLz 9L7BnYWG662vWOpEuzRfTF0wvZFNJae6snbgaSAjfuhcr8BZfpZpHawhg8f5Qlx4QbMp cUJg== X-Gm-Message-State: AGRZ1gKUeS/SdwrtU9bekKffie7weghEHqUYGyFmajBlB0KZJdwgpTfC 0d5QDeBstffOvP40PL7WWELBnS6NDGw= X-Google-Smtp-Source: AJdET5eCH1RjYZyvDXafoJUoumCVZUm+51IW+Z/MGNzRT0BORrnkBKytdWFd7TYeaOU2/HIdddgcxA== X-Received: by 2002:a63:81c7:: with SMTP id t190mr3110233pgd.393.1540397605493; Wed, 24 Oct 2018 09:13:25 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l16-v6sm7690427pfb.75.2018.10.24.09.13.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Oct 2018 09:13:25 -0700 (PDT) Date: Wed, 24 Oct 2018 09:11:38 -0700 From: Stephen Hemminger To: Lewis Donzis Cc: dev@dpdk.org Message-ID: <20181024091138.132d78c5@xeon-e3> In-Reply-To: <905F0B17-2987-4847-A054-C94501ACBC2D@perftech.com> References: <905F0B17-2987-4847-A054-C94501ACBC2D@perftech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] Change ether_addr to avoid conflict X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 16:13:26 -0000 On Wed, 24 Oct 2018 07:35:28 -0500 Lewis Donzis wrote: > Please consider changing "struct ether_addr" in rte_ether.h to "struct rte_ether_addr", in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h. > > Sometimes, there is need to include /usr/include/net/ethernet.h, but it conflicts with the same structure name in rte_ether.h. Was there a reason this structure wasn't given the standard rte_ prefix? > > Thanks, > lew Only history, remember EAL was first running on bare metal. Changing to 'struct rte_ether_addr' breaks source of lots of applications.