From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kvargs: fix processing a null list
Date: Wed, 24 Oct 2018 11:34:36 +0200 [thread overview]
Message-ID: <20181024093436.c6ak47y6ckofyofm@platinum> (raw)
In-Reply-To: <20181023162454.15519-1-thomas@monjalon.net>
On Tue, Oct 23, 2018 at 06:24:54PM +0200, Thomas Monjalon wrote:
> In the doxygen description of rte_kvargs_process(), it is said:
> If *kvlist* is NULL function does nothing.
> It has been added by mistake here instead of rte_kvargs_free().
> Anyway, null list should be correctly handled in both functions.
>
> Comments are fixed in both functions and NULL handling is added
> to rte_kvargs_process().
>
> Fixes: c34af7424e09 ("kvargs: fix freeing behaviour for null")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
> @@ -119,11 +119,10 @@ void rte_kvargs_free(struct rte_kvargs *kvlist);
> *
> * For each key/value association that matches the given key, calls the
> * handler function with the for a given arg_name passing the value on the
> - * dictionary for that key and a given extra argument. If *kvlist* is NULL
> - * function does nothing.
> + * dictionary for that key and a given extra argument.
It looks the rest of the api documentation is perfectible :)
I'll send a fix in another patch.
Thanks,
Olivier
next prev parent reply other threads:[~2018-10-24 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 16:24 Thomas Monjalon
2018-10-24 9:34 ` Olivier Matz [this message]
2018-10-24 13:08 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024093436.c6ak47y6ckofyofm@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).